意外的语法错误

时间:2011-08-16 12:40:23

标签: ruby-on-rails ruby syntax-error

从我的自定义模型中提供以下代码:

  def categorize
    @cv = Cv.find(params[:cv_id], :include => [:desired_occupations, :past_occupations, :educational_skills])
    @menu = :second
    @language = Language.resolve(:code => :en, :name => :en)
    categorizer = CvCategorizer.new @cv, @language
    categorizer.prepare_occupations
    categorizer.prepare_occupation_skills
    categorizer.prepare_education_skills

    # fetch the data
    @occupation_hashes = categorizer.occupations
    @skill_hashes = categorizer.skills

    # Sort the hashes
    @occupation_hashes.sort! { |x,y| y.score <=> x.score}
    @skill_hashes.sort! { |x,y| y.score <=> x.score}
    @max = @skill_hashes.first.score
    @min = @skill_hashes.last.score
  end

代码创建CvCategorizer类的新实例,并按顺序调用三个prepare方法。他们都从数据库中检索数据做了时髦的事情。代码如下:

# = CvCategorizer
# This class will handle the categorizing of a CV based upon the skills and occupations found in
# the CV. Because the controller originally had a huge chunk of code, this class will break up that
# login into seperate function calls and keep everything inside variables for easy access.
class CvCategorizer
  # initializes a new instance of the CvCategorizer
  def initialize cv, language
    @cv = cv
    @language = language
    @occupations = []
    @skills = []
  end

  # Prepares the occupation array by looking at the stored CV and collecting
  # all the desired occupations and past occupations. These are stored inside
  # the internal occupation array as a uniq list.
  def prepare_occupations
    all_occupations = @cv.desired_occupations.all(:include => :labels) + @cv.past_occupations.all(:include => :labels)
    all_occupations.each do |occupation|
      oc = OccupationCategory.new
      oc.is_desired_work?= @cv.desired_occupations.include?(occupation)
      oc.is_work_experience?= @cv.past_occupations.include?(occupation)
      oc.occupation = occupation

      if !@occupations.include?(oc)
        @occupations << oc
      else
        obj = @occupations.select(oc)
        obj.score += 1
        obj.occupations= (obj.occupations & oc).uniq
      end
    end
=begin
    all_occupations = @cv.desired_occupations.all(:include => :labels) + @cv.past_occupations.all(:include => :labels)
    all_occupations.each do |occupation|
      section = []
      section << "Desired Work" if @cv.desired_occupations.include? occupation
      section << "Work experience" if @cv.past_occupations.include? occupation

      unless (array = @occupations.assoc(occupation)).blank?
        array[1]+= 1
        array[2] = (array[2] & section).uniq
      else
        @occupations << [occupation, 1, section, []]
      end
    end
=end
  end

  # Prepares the occupation skills of the CV by looping over all the stored
  # occupations and retrieving the skills for them and storing them in the
  # skills array.
  def prepare_occupation_skills
    # Loop over all the OccupationCategory objects currently present in the Categorizer.
    @occupations.each do |oc|
      # For each OccupationCategory object, retrieve all the associated skills, and
      # include their label as well.
      oc.occupation.skills.all(:include => :labels).each do |skill|
        # Get the label of the current concept we're working with.
        label = oc.occupation.concept.label(@language).value
        # Check if the @skills array already contains a SkillCategory object with the
        # skill we're currently checking.
        if (sc = @skills.select{|scs| scs.skill == skill}).blank?
          # The skill was not found, so create a new entry with the SkillCategory class and set the
          # correct values for the various properties
          sc = SkillCategory.new
          sc.labels << label
          sc.score= 1
          sc.is_occupation_skill? = true
          sc.skill= skill
        else
          # The skill was found in one of the SkillCategory objects. So we update the score by
          # 1 and store the label of the current concept, unless that label is already present.
          sc.labels << label unless sc.labels.include?(label)
          sc.is_occupation_skill?= true
          sc.score+= 1
        end
      end
    end
=begin
    @occupations.each do |array|
      array[0].skills.all(:include => :labels).each do |skill|
        unless (skill_array = @skills.assoc skill).blank?
          label = array[0].concept.label(@language).value
          skill_array[1]+= 1
          skill_array[3] << label unless skill_array[3].include? label
        else
          @skills << [skill, 1, [], [array[0].concept.label(@language).value]]
        end
      end
    end
=end
  end

  # Prepares the education skills by checking the CV and adding them to the
  # skills array
  def prepare_education_skills
    # Loop over all the educational skills that are currently associated to the CV.
    @cv.educational_skills.all(:include => :labels).each do |skill|
      # Check if the @skills array already contains a SkillCategory object with the
      # skill we're currently checking.
      if (sc = @skills.select{|scs| scs.skill == skill}).blank?
        # The skill was not found, so create a new entry with the SkillCategory class and set the
        # correct values for the various properties
        sc = SkillCategory.new
        sc.labels << 'Education skills' unless sc.labels.include?('Education skills')
        sc.score= 1
        sc.is_educational_skill?= true
        sc.skill= skill
      else
        # The skill was found in one of the SkillCategory objects. So we update the score by
        # 1 and store the label of the current concept, unless that label is already present.
        sc.labels << 'Education skills' unless sc.labels.include?('Education skills')
        sc.is_educational_skill?= true
        sc.score+= 1
      end
    end
=begin
    @cv.educational_skills.all(:include => :labels).each do |skill|
      unless (array = @skills.assoc skill).blank?
        array[1]+= 1
        array[3] << 'Education skills' unless array[3].include? 'Education skills'
      else
        @skills << [skill, 1, ['Education skills'], []]
      end
    end
=end
  end

  # Returns all uniq skills with their score and section found.
  # array structure for each element
  # - 0 : the skill object
  # - 1 : the score for the skill
  # - 2 : CV location of the skill
  # - 3 : ESCO group of the skill
  def skills
    @skills
  end

  # Returns all uniq occupations with their score and section found.
  # array structure for each element
  # - 0 : the occupation object
  # - 1 : the score for the occupation
  # - 2 : the CV location of the occupation
  # - 3 : empty array for occupations
  def occupations
    @occupations
  end
end

当浏览到应用程序中的相关视图时,我从服务器收到以下错误消息:

  

/home/arne.de.herdt/RubymineProjects/ESCO/app/models/cv_categorizer.rb:21:   语法错误,意外的tIVAR,期待kEND         oc.is_desired_work?= @ cv.desired_occupations.include?(...                                 ^   /home/arne.de.herdt/RubymineProjects/ESCO/app/models/cv_categorizer.rb:22:   语法错误,意外的tIVAR,期待kEND ...
  oc.is_work_experience?= @ cv.past_occupations.include?(occ ...                                 ^   /home/arne.de.herdt/RubymineProjects/ESCO/app/models/cv_categorizer.rb:69:   语法错误,意外'=',期待kEND             sc.is_occupation_skill? =真                                      ^   /home/arne.de.herdt/RubymineProjects/ESCO/app/models/cv_categorizer.rb:75:   语法错误,意外的kTRUE,期待kEND   /home/arne.de.herdt/RubymineProjects/ESCO/app/models/cv_categorizer.rb:108:   语法错误,意外的kTRUE,期待kEND   /home/arne.de.herdt/RubymineProjects/ESCO/app/models/cv_categorizer.rb:114:   语法错误,意外的kTRUE,期待kEND

似乎我在CvCategorize类中遗漏了一些东西,但我找不到丢失的东西。 IDE未显示错误,例如缺少结尾或任何内容。

2 个答案:

答案 0 :(得分:3)

删除oc.is_desired_work上的问号?和oc.is_work_experience?在第21和22行。

答案 1 :(得分:1)

ruby​​允许方法名称中的问号,而不是变量(任何类型)或对象属性。

ruby​​方法是将实例方法添加到您的OccupationCategory类中,如下所示:

class OccupationCategory

  def is_desired_work?
    ...
  end

  def is_work_experience?
    ...
  end

end

所以你以后可以像

一样使用它
oc.is_desired_work? 
oc.is_work_experience?