Android应用程序没有关闭游标或数据库

时间:2011-08-02 16:34:36

标签: android sqlite cursor

我遇到了将项目插入数据库的问题。奇怪的是,程序将运行4行并插入它们很好,但在第5行它崩溃,我得到三个应用程序报告没有关闭光标或数据库。在我的代码中,我正在关闭并重新打开游标和数据库,所以我真的很困惑这是怎么回事。这是代码。

public void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    switch(requestCode) {
        case REQUEST_CODE_NEW:
            if (resultCode == -1) {
                Integer chapterId = data.getIntExtra("chapterId", -1);
                Toast toast = Toast.makeText(this, "Selected Chapter: " + chapterId.toString(), Toast.LENGTH_LONG);
                if (chapterId != -1) {
                    DbHelper db = new DbHelper(this);
                    for (int i = 0; i < questions.getTitle().size(); i++) {
                        db.insertQuestion(chapterId.toString(), questions.getTitle().get(i), questions.getAnswer().get(i), questions.getAr().get(i));
                    }
                }
                toast.show();
            }
            break;
    }
}

这就是通过dbhelper类调用数据库。这是数据库助手

public void insertQuestion(String cat_id, String title, String answer, String article) {
    db.execSQL("INSERT INTO " + QUESTION_TABLE_NAME + " (title,answer,article,picture) VALUES ('" + title + "','" + answer + "','" + article + "','none')"); 
    String id = getQuestionId(title);
    db.execSQL("INSERT INTO " + REL_TABLE_NAME + " (question_id, cat_id) VALUES (" + id + "," + cat_id + ")");

}
public String getQuestionId(String title) {
    String id;
    cursor = this.db.rawQuery("SELECT question_id FROM " + QUESTION_TABLE_NAME + " WHERE title = '" + title + "' LIMIT 1", null);
    cursor.moveToFirst();
    id = cursor.getString(0);
    cursor.close();
    db.close();
    return id;
}

我把光标放在班级,所以我可以尝试更好地管理它,但仍无济于事。它在4次查询后仍然崩溃。

1 个答案:

答案 0 :(得分:1)

试试这个“修复”:

DbHelper db = new DbHelper(this);
try{
                    for (int i = 0; i < questions.getTitle().size(); i++) {
                        db.insertQuestion(chapterId.toString(), questions.getTitle().get(i), questions.getAnswer().get(i), questions.getAr().get(i));
                    }
}catch(Exception e1){
   android.util.Log.v("DbHelper Error","Crash: "+e1.getMessage(), e1);
}finally{
db.close();
}