Rails 3:在创建身份验证时更新用户属性

时间:2011-06-25 03:43:35

标签: ruby-on-rails-3 omniauth railscasts

我按照Railscast#235和#236设置了使用omniauth创建用户身份验证。 http://railscasts.com/episodes/235-omniauth-part-1 http://railscasts.com/episodes/236-omniauth-part-2

我在用户模型上有2个布尔属性:facebok_share和:twitter_share我想在创建新身份验证时设置为true。

当我创建一个新用户时,我有这个工作,但如果现有用户添加了身份验证,我无法将布尔值更新为true。

当调用apply_omniauth(omniauth)时,它会在我的用户模型中设置self.facebook_share = true或self.twitter_share = true。

我尝试添加一个名为apply_share的新方法,根据提供程序更改布尔值,我正在尝试调用current_user.apply_share(omniauth),但数据库中没有发生任何事情。

我做错了什么?谢谢!

##身份验证控制器

class AuthenticationsController < ApplicationController

  def index
    @title = "Authentications"
    @authentications = current_user.authentications if current_user
  end

  def create
    # creates omniauth hash and looks for an previously established authentication
    omniauth = request.env["omniauth.auth"]
    authentication = Authentication.find_by_provider_and_uid(omniauth['provider'], omniauth['uid'])
    # if previous authentication found, sign in user
    if authentication
      flash[:notice] = "Signed in successfully"
      sign_in_and_redirect(:user, authentication.user)
    #  for users already signed in (current_user), create a new authentication for the user
    elsif current_user
      current_user.apply_share(omniauth)
      current_user.authentications.create(:provider => omniauth['provider'], :uid => omniauth['uid'], :token => (omniauth['credentials']['token'] rescue nil),
                                           :secret => (omniauth['credentials']['secret'] rescue nil))
      flash[:notice] = "authentications successful"
      redirect_to authentications_url
    # new user is created and authentications are built through apply_omniauth(omniauth)
    else
      user = User.new
      user.apply_omniauth(omniauth)
      if user.save
        flash[:notice] = "Signed in successfully"
        sign_in_and_redirect(:user, user)
      # if validations fail to save user, redirects to new user registration page 
      # new twitter authentications redirect so user can enter their password
      else
        session[:omniauth] = omniauth
        redirect_to new_user_registration_url
      end
     end
   end

  def destroy
    @authentication = current_user.authentications.find(params[:id])
    @authentication.destroy
    flash[:notice] = "Successfully destroyed authentication."
    redirect_to authentications_url
  end

end

## user model

 # set share booleans to true depending on 'provider' type
  def apply_share(omniauth)
    case omniauth['provider']
      when 'facebook'
        self.facebook_share = true
      when 'twitter'
        self.twitter_share = true
     end
   end

 # from authentications controller, new user split into type of provider
 def apply_omniauth(omniauth)
   case omniauth['provider']
   when 'facebook'
     self.apply_facebook(omniauth)
   when 'twitter'
     self.apply_twitter(omniauth)
   end
   # builds authentication with provider, uid, token, and secret
   authentications.build(hash_from_omniauth(omniauth))
  end

 protected

 # sets new user attributes from facebook
 def apply_facebook(omniauth)
   self.name = omniauth['user_info']['name']
   self.email = omniauth['user_info']['email'] if email.blank?
   self.facebook_share = true
 end

 # sets new user attributes from twitter 
 def apply_twitter(omniauth)
   if (extra = omniauth['extra']['user_hash'] rescue false)
     # Example fetching extra data. Needs migration to User model:
     # self.firstname = (extra['name'] rescue '')
     self.name = (extra['name'] rescue '')
     self.bio = (extra['description'] rescue '') 
   end
   self.twitter_share = true

 end

 # set authentication attributes to those from 'omniauth' hash
 def hash_from_omniauth(omniauth)
   {
     :provider => omniauth['provider'],
     :uid => omniauth['uid'],
     :token => (omniauth['credentials']['token'] rescue nil),
     :secret => (omniauth['credentials']['secret'] rescue nil)
   }
 end
end


## new methid with :before add => :apply_share
def apply_share(authentication) 
  case authentication['provider'] 
    when 'facebook' 
      self.facebook_share = true 
    when 'twitter'
      self.twitter_share = true 
    end 
  self.save
end

2 个答案:

答案 0 :(得分:2)

我相信你永远不会真正保存current_user。因此,将属性设置为true,然后重定向。该关联存储在身份验证模型中,因此Rails尝试提供帮助,不会更新current_user,只会更新新的身份验证实例

尝试:

current_user.apply_share(omniauth)
current_user.save

并查看是否修复了它。现在,如果确实如此,我强烈建议使用回调。看看这里:

http://guides.rubyonrails.org/association_basics.html

关于关联回调的第4.5节。您可以对has_many身份验证关联执行before_add回调,以便从控制器中删除该代码,因为它变得非常臃肿。

   class User < ActiveRecord::Base
     has_many :authentications, :before_add => :apply_share

     def apply_share(authentication)
      #update attributes
      #save model
     end
   end

答案 1 :(得分:1)

设置#save属性后,您需要在User对象上调用*_share

has_many集合中添加新项会自动保存集合项,但不会触发父项(belongs_to)上的保存操作。