我正在尝试执行以下操作:
•从用户接收3个整数:size1,size2,size3。
•创建一个size1 * size2矩阵和一个size2 * size3矩阵。
•将2个矩阵相乘。
•打印结果矩阵。
•释放所有动态内存。
在输入两个矩阵之后,BUT 我希望程序显示矩阵的乘法,但它会在FreeMatrix函数中导致断点,并这样写: 在Project8.exe中的0x0F82AC1D(ucrtbased.dll)处引发异常:0xC0000005:访问冲突读取位置0xCCCCCCC4。
代码:
#define _CRT_SECURE_NO_WARNINGS
#include <stdlib.h>
#include <stdio.h>
void BuildMatrix(int*** pMat, int row, int col);
void FreeMatrix(int*** matrix, int row);
void PrintMatrix(int** pMat, int row, int col);
int** MultiplyMatrixes(int** a, int** b, int size1, int size2, int size3);
int main() {
int** matrix1 = NULL, ** matrix2 = NULL, ** matrix3 = NULL;
int* newCol = NULL;
int size1, size2, size3, newRow;
printf("-How many rows in the first matrix?: ");
scanf("%d", &size1);
printf("-How many columns in the first matrix and rows in the second matrix?[size2, size3]: ");
scanf("%d", &size2); /*size2 = rows of matrix2.*/
printf("-How many columns in the second matrix?: ");
scanf("%d", &size3);
/*Build both matrices*/
printf("-First matrix input.\n");
BuildMatrix(&matrix1, size1, size2);
PrintMatrix(matrix1, size1, size2);
printf("-Second matrix input.\n");
BuildMatrix(&matrix2, size2, size3);
PrintMatrix(matrix2, size2, size3);
/*Combine the 2 matrices to a new matrix*/
matrix3 = MultiplyMatrixes(matrix1, matrix2, size1, size2, size3);
FreeMatrix(&matrix2, size2); //Free the second matrix
printf("\n-Multiplied matrix: \n");
PrintMatrix(matrix3, size1, size3);
FreeMatrix(&matrix3, size1);
FreeMatrix(&matrix1, size1);
}
void BuildMatrix(int*** pMat, int row, int col)
{
int i, j;
(*pMat) = (int**)malloc(row * sizeof(int*));
if (*pMat == NULL)
{
free(pMat);
printf("*Not enough RAM.\nTerminating.\n");
exit(1);
}
for (i = 0; i < row; i++)
{
(*pMat)[i] = malloc(col * sizeof(int));
if ((*pMat)[i] == NULL) {
printf("*Not enough RAM.\nTerminating.\n");
FreeMatrix(pMat, row);
exit(1);
}
for (j = 0; j < col; j++) {
printf("-Enter %d element in %d row: ", j + 1, i + 1);
scanf("%d", &(*pMat)[i][j]);
}
printf("\n");
}
//FreeMatrix(pMat, row);
}
void FreeMatrix(int*** matrix, int row)
{
for (int i = 0; i < row; i++)
{
free((matrix)[i]);
}
free(matrix);
}
void PrintMatrix(int** pMat, int row, int col)
{
for (int i = 0; i < row; ++i)
{
for (int j = 0; j < col; ++j)
{
printf("%d ", (pMat[i][j]));
}
printf("\n");
}
}
int** MultiplyMatrixes(int** a, int** b, int size1, int size2, int size3)
{
int i, j, k, ** c = NULL;
c = (int**)malloc(size1 * sizeof(int*));
if (c == NULL)
{
free(*c);
printf("*Not enough RAM.\nTerminating.\n");
exit(1);
}
for (i = 0; i < size1; i++) {
c[i] = malloc(size3 * sizeof(int));
if (c[i] == NULL)
{
printf("*Not enough RAM.\nTerminating.\n");
FreeMatrix(&c, size1);
exit(1);
}
for (j = 0; j < size3; j++)
{
c[i][j] = 0;
for (k = 0; k < size2; k++)
{
c[i][j] += (a[i][k] * b[k][j]);
}
}
}
}
答案 0 :(得分:0)
就像您为BuildMatrix
中的矩阵分配时一样:
(*pMat) = (int**)malloc(row * sizeof(int*));
for (i = 0; i < row; i++)
{
(*pMat)[i] = malloc(col * sizeof(int));
...
}
因此,在FreeMatrix
中,您的代码应更改为:
void FreeMatrix(int*** matrix, int row)
{
for (int i = 0; i < row; i++)
{
free((*matrix)[i]); // using *matrix instead of matrix
}
free(*matrix); // using *matrix instead of matrix also
}
您还忘记了返回MultiplyMatrixes
函数的值。它应在函数末尾返回矩阵c
。
您不需要释放NULL
指针,因为如果指针为NULL,则不会执行任何操作,例如,在您的代码中:
(*pMat) = (int**)malloc(row * sizeof(int*));
if (*pMat == NULL)
{
free(pMat); // it's not necessary
printf("*Not enough RAM.\nTerminating.\n");
exit(1);
}
答案 1 :(得分:0)
此代码中有两个问题。
第一个问题,导致您在df1
函数中的异常:
您传递了FreeMatrix
,但没有取消引用第一个指针。
int***
应该是:
void FreeMatrix(int*** matrix, int row)
{
for (int i = 0; i < row; i++)
{
free((matrix)[i]); // Type inside free is int**, not int*
}
free(matrix); // Type inside free is int***, not int**
}
在解决此问题之后,您的代码中的void FreeMatrix(int*** matrix, int row)
{
for (int i = 0; i < row; i++)
{
free((*matrix)[i]); // Type inside free is int*
}
free(*matrix); // Type inside free is int**
}
值也有问题。
您缺少matrix3
函数中的return
语句和MultiplyMatrixes
变量未分配。
应该是:
matrix3
我也建议您将矩阵分配为指针行和连续数组。 像这样:
int** MultiplyMatrixes(int** a, int** b, int size1, int size2, int size3)
{
int i, j, k, ** c = NULL;
c = (int**)malloc(size1 * sizeof(int*));
if (c == NULL)
{
free(*c);
printf("*Not enough RAM.\nTerminating.\n");
exit(1);
}
for (i = 0; i < size1; i++) {
c[i] = malloc(size3 * sizeof(int));
if (c[i] == NULL)
{
printf("*Not enough RAM.\nTerminating.\n");
FreeMatrix(&c, size1);
exit(1);
}
for (j = 0; j < size3; j++)
{
c[i][j] = 0;
for (k = 0; k < size2; k++)
{
c[i][j] += (a[i][k] * b[k][j]);
}
}
}
return c; // <====
}
元素访问权限:
int** matrix = (int*)malloc(sizeof(int*) * rows); // pointers to rows
matrix[0] = (int*)malloc(rows * cols); // single chunk of memory for all elems
for(int i = 0; i < rows; ++i)
matrix[i] = matrix[0] + i * cols;
释放:
elem = matrix[row_index][col_index];
另一个选择是将矩阵分配为连续数组。
赞:
if (rows)
free(matrix[0]);
free(matrix);
元素访问权限:
int** matrix = (int*)malloc(sizeof(int*) * cols * rows); // single chunk of memory for all elems
在这种方法中,解除分配更加简单:
elem = matrix[row_index * row_size + col_index];
将内存分配为一个简单的内存块可以简化内存的分配,并且这样的代码对缓存更友好。
答案 2 :(得分:0)
这里是工作代码已修改。
基本上,乘法功能没有返回分配的地址
三重指针pMat不匹配。
此外,在处理错误的已分配内存时,您应格外小心。
只需将您的代码与我的代码并排比较即可。
我试图添加有用的评论。
#include <stdlib.h>
#include <stdio.h>
void BuildMatrix(int*** pMat, int row, int col);
void FreeMatrix(int*** matrix, int row);
void PrintMatrix(int** pMat, int row, int col);
int** MultiplyMatrixes(int** a, int** b, int size1, int size2, int size3);
int main() {
int** matrix1 = NULL, ** matrix2 = NULL, ** matrix3 = NULL;
int* newCol = NULL;
int size1, size2, size3, newRow;
printf("-How many rows in the first matrix?: ");
scanf("%d", &size1);
printf("-How many columns in the first matrix and rows in the second matrix?[size2, size3]: ");
scanf("%d", &size2); /*size2 = rows of matrix2.*/
printf("-How many columns in the second matrix?: ");
scanf("%d", &size3);
/*Build both matrices*/
printf("-First matrix input.\n");
BuildMatrix(&matrix1, size1, size2);
PrintMatrix(matrix1, size1, size2);
printf("-Second matrix input.\n");
BuildMatrix(&matrix2, size2, size3);
PrintMatrix(matrix2, size2, size3);
/*Combine the 2 matrices to a new matrix*/
matrix3 = MultiplyMatrixes(matrix1, matrix2, size1, size2, size3);
FreeMatrix(&matrix2, size2); //Free the second matrix
printf("\n-Multiplied matrix: \n");
PrintMatrix(matrix3, size1, size3);
FreeMatrix(&matrix3, size1);
FreeMatrix(&matrix1, size1);
}
void BuildMatrix(int*** pMat, int row, int col)
{
int i, j;
(*pMat) = (int**)malloc(row * sizeof(int*));
if (*pMat == NULL)
{
// pMat is a pointer to the "whole" matrix and mirrors
// the calling parameter matrix1, e.g. So always use it dereferenced.
// If *pMat is NULL there is nothing to free (at NULL).
//free(*pMat);
printf("*Not enough RAM.\nTerminating.\n");
exit(1);
}
for (i = 0; i < row; i++)
{
(*pMat)[i] = malloc(col * sizeof(int));
//if(i == 1) //to try exception handling code
if ((*pMat)[i] == NULL)
{
int d;
printf("*Not enough RAM.\nTerminating.\n");
//FreeMatrix(pMat, row);
// Your new matrix isn't complete so you should free *pMat here,
// and free (*pMat)[?] with ? from 0 to i-1
for (d = 0; d < i; ++d) free((*pMat)[d]); free(*pMat);
exit(1);
}
for (j = 0; j < col; j++) {
printf("-Enter %d element in %d row: ", j + 1, i + 1);
scanf("%d", &(*pMat)[i][j]);
}
printf("\n");
}
//FreeMatrix(pMat, row);
}
void FreeMatrix(int*** matrix, int row)
{
for (int i = 0; i < row; i++)
{
// pMat is a pointer to the "whole" matrix and mirrors
// the calling parameter matrix1, e.g. So always use it dereferenced.
free((*matrix)[i]);
}
free(*matrix);
}
void PrintMatrix(int** pMat, int row, int col)
{
for (int i = 0; i < row; ++i)
{
for (int j = 0; j < col; ++j)
{
printf("%d ", (pMat[i][j]));
}
printf("\n");
}
}
int** MultiplyMatrixes(int** a, int** b, int size1, int size2, int size3)
{
int i, j, k, ** c = NULL;
c = (int**)malloc(size1 * sizeof(int*));
if (c == NULL)
{
// If c is NULL there is nothing to free (at NULL).
//free(c);
printf("*Not enough RAM.\nTerminating.\n");
exit(1);
}
for (i = 0; i < size1; i++) {
c[i] = malloc(size3 * sizeof(int));
//if(i == 1) //to try exception handling code
if (c[i] == NULL)
{
int d;
printf("*Not enough RAM.\nTerminating.\n");
//FreeMatrix(&c, size1);
// Your new matrix isn't complete so you should free c here,
// and free c[?] with ? from 0 to i-1
for (d =0; d < i; ++d) free(c[d]); free(c);
exit(1);
}
for (j = 0; j < size3; j++)
{
c[i][j] = 0;
for (k = 0; k < size2; k++)
{
c[i][j] += (a[i][k] * b[k][j]);
}
}
}
return c;
}