Question

我在下面定义了一个模型，该模型在clean（）方法中调用管理器。

from django.core.exceptions import ValidationError
from django.db import models
from re import sub

class Vessel(models.Model):
    name = models.CharField(max_length=50)
    stripped_name = models.CharField(
        max_length=50, unique=True, null=True, blank=True
    )

    def save(self, *args, **kwargs):
        stripped_name = sub(r'\s+', ' ', str(self.name).upper().strip())
        stripped_name = sub(r'^M[^a-zA-Z]*V\s*', '', stripped_name)
        stripped_name = sub(r'[^\w]', '', str(stripped_name).upper())
        self.stripped_name = stripped_name
        super().save(*args, **kwargs)

    def clean(self):
        stripped_name = sub(r'\s+', ' ', str(self.name).upper().strip())
        stripped_name = sub(r'^M[^a-zA-Z]*V\s*', '', stripped_name)
        stripped_name = sub(r'[^\w]', '', str(stripped_name).upper())
        if Vessel.objects.all().filter(stripped_name = stripped_name).exists():
            return ValidationError("Vessel name exists.")

在刚冲洗过的外壳中，可以很好地提高IntegrityError。

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.save() # Raises IntegrityError

即使ValidationError也会很好地显示。

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.clean() # Raises ValidationError

但是在自动测试中，不会引发ValidationError。

from django.core.exceptions import ValidationError
from django.db.utils import IntegrityError
from django.test import TestCase

from my_random_app.models import Vessel

class  VesselTest(TestCase):

    def setUp(self):
        pass

    def test_a(self):
        vessel = Vessel(name='PM Hayabusa')
        vessel.save()
        vessel = Vessel(name=' M/V PM-HAYABUSA')
        self.assertRaises(IntegrityError, vessel.save)

    def test_b(self):
        vessel = Vessel(name='PM Hayabusa')
        vessel.save()
        vessel = Vessel(name=' M/V PM-HAYABUSA')

        # This line FAILS!
        self.assertRaises(ValidationError, vessel.clean)

这与我在clean（）方法中调用管理器有关吗？为什么验证错误会在外壳程序中而不是测试中出现？

Answer 1

您所做的几乎是完美的：）

ValidationError是一个异常，有些事情要提出，而不是要返回的。

如果替换return-> raise，您的问题将得到解决。

        if Vessel.objects.all().filter(stripped_name = stripped_name).exists():
            raise ValidationError("Vessel name exists.")

在shell clean方法中执行此操作时，会返回错误，因此您认为它可以正常运行，但实际上并非如此。

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.clean() # Returns ValidationError
ValidationError(['Vessel name exists.'])

当它升起时，就变成了流动的东西：

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.clean()
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/***/**/myapp/models.py", line 25, in clean
    raise ValidationError("Vessel name exists.")
django.core.exceptions.ValidationError: ['Vessel name exists.']

django ValidationError在测试中未引发，但在外壳中引发

1 个答案: