所以我遇到的问题是,将类House
中的对象相互比较时。
def __init__(self, door: str, address: str, rooms: List[room],
garaje=None, number=None):
self.door = door
self.address = address
# ensure and deserialize if needed the list of rooms
try:
if all(isinstance(room, dict) for room in rooms):
rooms = list(map(room.from_json, rooms))
# deserialize rooms
assert all(isinstance(room, Room) for room in rooms)
except AssertionError as e:
logger.error("Rooms incorrect")
raise e
self.rooms = rooms
self.garaje = garaje
self.number = number
def __eq__(self, other):
'''
Two houses instances will be equal when at least following values match:
door,
address
rooms
'''
if not isinstance(other, House):
return NotImplemented
return (self.door == other.door and
self.address == other.address and
self.rooms == other.rooms)
def __hash__(self):
return hash((self.door, self.address, self.rooms))
@classmethod
def from_json(cls, data):
return cls(**data)
类House
包含一个基于房间类别的房间对象列表:
class Room():
def __init__(self, name: str, description: str, windows: list = None, bahtroom: bool = True,
, room_id: int = None, house_number: int = None):
self.name = name
self.description = description
self.windows = windows
self.bathroom = bathroom
self.room_id = room_id
self.house_number = house_number
def __eq__(self, other):
"""Two room instances will be equal when at least following values match
name,
description,
windows,
bathroom
"""
if not isinstance(other, Room):
return NotImplemented
return (self.name == other.name and
self.description == other.description and
self.windows == other.windows and
self.bathroom == other.bathroom
)
def __hash__(self):
return hash((self.name, self.descritpion, self.windows, self.bathroom))
@classmethod
def from_json(cls, data):
return cls(**data)
在比较房屋结果时,由于“房间”列表中的差异,它们不相等。 在列表中进行比较时,房间有所不同:
自己27个房间
[<housing.classes.Room object at 0x7f465f6f83c8>, <housing.classes.Room object at 0x7f465f6f8710>, <housing.classes.Room object at 0x7f465f6f8550>, <housing.classes.Room object at 0x7f465f6f8978>, <housing.classes.Room object at 0x7f465f6f8048>, <housing.classes.Room object at 0x7f465f6f8a20>, <housing.classes.Room object at 0x7f465f6f8518>, <housing.classes.Room object at 0x7f465f6f8898>, <housing.classes.Room object at 0x7f465f6f87b8>, <housing.classes.Room object at 0x7f465f6f84a8>, <housing.classes.Room object at 0x7f465f6f8278>, <housing.classes.Room object at 0x7f465f6f8c50>, <housing.classes.Room object at 0x7f465f6f8940>, <housing.classes.Room object at 0x7f465f6f86a0>, <housing.classes.Room object at 0x7f465f6f8320>, <housing.classes.Room object at 0x7f465f6f8c18>, <housing.classes.Room object at 0x7f465f6f8a58>, <housing.classes.Room object at 0x7f465f6f80b8>, <housing.classes.Room object at 0x7f465f6f8828>, <housing.classes.Room object at 0x7f465f6f8b70>, <housing.classes.Room object at 0x7f465f6f85f8>, <housing.classes.Room object at 0x7f465f6f81d0>, <housing.classes.Room object at 0x7f465f6f8358>, <housing.classes.Room object at 0x7f465f6f8240>, <housing.classes.Room object at 0x7f465f6f8128>, <housing.classes.Room object at 0x7f465f6f8400>, <housing.classes.Room object at 0x7f465f6f8668>]
其他27个房间
[<housing.classes.Room object at 0x7f465f6f1470>, <housing.classes.Room object at 0x7f465f6f1978>, <housing.classes.Room object at 0x7f465f6f1f98>, <housing.classes.Room object at 0x7f465f6f1d68>, <housing.classes.Room object at 0x7f465f6f1a58>, <housing.classes.Room object at 0x7f465f6f1cf8>, <housing.classes.Room object at 0x7f465f6f11d0>, <housing.classes.Room object at 0x7f465f6f1438>, <housing.classes.Room object at 0x7f465f6f1898>, <housing.classes.Room object at 0x7f465f6f1ef0>, <housing.classes.Room object at 0x7f465f6f10f0>, <housing.classes.Room object at 0x7f465f6f1198>, <housing.classes.Room object at 0x7f465f6f1240>, <housing.classes.Room object at 0x7f465f6f18d0>, <housing.classes.Room object at 0x7f465f6f17f0>, <housing.classes.Room object at 0x7f465f6f15c0>, <housing.classes.Room object at 0x7f465f6f1828>, <housing.classes.Room object at 0x7f465f6f1518>, <housing.classes.Room object at 0x7f465f6f13c8>, <housing.classes.Room object at 0x7f465f6f1f28>, <housing.classes.Room object at 0x7f465f6f1160>, <housing.classes.Room object at 0x7f465f6f1860>, <housing.classes.Room object at 0x7f465f6f12e8>, <housing.classes.Room object at 0x7f465f6f17b8>, <housing.classes.Room object at 0x7f465f6f1ba8>, <housing.classes.Room object at 0x7f465f6f1400>, <housing.classes.Room object at 0x7f465f6f14a8>]
但是在比较每个“房间”列表中的“房间”时,我不断发现self
中的所有房间都在other
中。
在变通方法中,我在House
的{{1}}类中添加了一个讨厌的检查,看起来像这样:
__eq__
执行此操作的好方法是什么?为什么直接比较但不在列表中比较时我的房间对象相等?
谢谢。
答案 0 :(得分:1)
这两个房间的清单很可能不是以相同的方式订购的? (您的代码没有显示如何构建它们。)
您可以先对2个列表进行排序,然后他们比较排序后的列表。
return (self.door == other.door and
self.address == other.address and
sorted(self.rooms) == sorted(other.rooms))