Question

我用C ++编写了一个小型文件处理程序类

它具有管理RAII文件关闭的基类，以及两个派生类，一个用于写，一个用于读。派生类具有2种写入或读取值以及写入或读取向量的方法。

#include <vector>
#include <fstream>
#include <iostream>
#include <algorithm>


class File{
protected:
    std::streampos offset;
    std::fstream file;

public:
    File(){
        offset = 0;
    }

    virtual ~File(){
        file.close();
    }
};

class oFile : public File{
public:
    oFile(std::string const& filename) {
        file.open(filename, std::ios::out|std::ios::binary);
    }

    template <typename T>
    void write_value(T value){
        file.seekp(offset);
        file.write(reinterpret_cast<char*> (&value), sizeof(T));
        offset += sizeof(T);
        std::cout<< "wrote a value: " << value << "  current offset: " << offset << std::endl;
    }

    template <typename T>
    void write_vector(std::vector<T> v){

        write_value(v.size());

        std::for_each(v.begin(), v.end(), [this](T& i){write_value(i);});
    }
};

class iFile : public File{
public:

    iFile(std::string const& filename){
        file.open(filename, std::ios::in|std::ios::binary);
    }

    template <typename T>
    void read_value(T& v){
        file.seekg(offset);
        file.read(reinterpret_cast<char*> (&v), sizeof(T));
        offset += sizeof(T);
        std::cout << "value read: " << v << " current offset: " << offset << std::endl;
    }

    template <typename T>
    void read_vector(std::vector<T>& v){
        typename std::vector<T>::size_type vsize;
        read_value(vsize);

        std::cout << "size of vector: " << vsize << std::endl;

        for(typename std::vector<T>::size_type i = 0; i < vsize; ++i){
            T value;
            read_value(value);

            v.push_back(value);
        }
    }
};

要测试我编写此函数的类：

    oFile file("test.ndf");

    double b = 12.;
    file.write_value(b);

    std::vector<double> v{1., 2., 3., 4., 6., 10., 15.};

    file.write_vector(v);

    iFile ifile("test.ndf");

    double ib;
    ifile.read_value(ib);

    std::cout << ib << std::endl;

    std::vector<double> iv;
    ifile.read_vector(iv);

    std::cout << "vector size: " << iv.size() << std::endl;

    for(auto val : iv){
        std::cout << val << " ";
    }
    std::cout << "last val: " << iv[iv.size() - 1] << std::endl;
}

但是输出有问题

wrote a value: 7 offset: 12
wrote a value: 1 offset: 20
wrote a value: 2 offset: 28
wrote a value: 3 offset: 36
wrote a value: 4 offset: 44
wrote a value: 6 offset: 52
wrote a value: 10 offset: 60
wrote a value: 15 offset: 68 <--- tells me he wrote 15
value read: 12 offset: 8
12
value read: 7 offset: 12
size of vector: 7
value read: 1 offset: 20
value read: 2 offset: 28
value read: 3 offset: 36
value read: 4 offset: 44
value read: 6 offset: 52
value read: 10 offset: 60
value read: 10 offset: 68 <--- problem
vector size: 7
1 2 3 4 6 10 10 last val: 10 <--- last value should be 15
Hello world!

输出的最后一行是矢量内容，尽管在write方法中告诉我它写入了正确的值（15），但重复了最后一个值。

我不明白为什么它要写入或读取最后一个值2次？我的文件处理程序解决方案好吗？有没有更好的办法？

使用MinGW（v9.2.0）与Code :: Blocks（v20.03）编译

Answer 1

我的文件处理程序解决方案好吗？

RAII用于资源管理是一种很好的建议方法。

但是，对于RAII，应该更仔细地考虑变量的范围（以及生命周期）。

在OP的公开代码中：

int main()
{
    oFile file("test.ndf");

    double b = 12.;
    file.write_value(b);

    std::vector<double> v{1., 2., 3., 4., 6., 10., 15.};

    file.write_vector(v);

    iFile ifile("test.ndf");

    double ib;
    ifile.read_value(ib);

    std::cout << ib << std::endl;

    std::vector<double> iv;
    ifile.read_vector(iv);

    std::cout << "vector size: " << iv.size() << std::endl;

    for(auto val : iv){
        std::cout << val << " ";
    }
    std::cout << "last val: " << iv[iv.size() - 1] << std::endl;
} // <-- all local variables incl. file will be destroyed here

ofile file实例生存到main结束。

wrote a value: 12  current offset: 8
wrote a value: 7  current offset: 16
wrote a value: 1  current offset: 24
wrote a value: 2  current offset: 32
wrote a value: 3  current offset: 40
wrote a value: 4  current offset: 48
wrote a value: 6  current offset: 56
wrote a value: 10  current offset: 64
wrote a value: 15  current offset: 72
value read: 12 current offset: 8
12
value read: 7 current offset: 16
size of vector: 7
value read: 1 current offset: 24
value read: 2 current offset: 32
value read: 3 current offset: 40
value read: 4 current offset: 48
value read: 6 current offset: 56
value read: 10 current offset: 64
value read: 10 current offset: 72
vector size: 7
1 2 3 4 6 10 10 last val: 10

Live Demo on coliru（我在其中转载了OP的问题）。

当内部流在ofile的析构函数中关闭时，到目前为止，尽管流会将其报告为已写入，但可能会有内部缓冲的内容（即未刷新）。

解决方案很简单： ofile file的范围必须受到限制。

固定代码：

int main()
{
    std::vector<double> v{1., 2., 3., 4., 6., 10., 15.};

    { // start new scope
        oFile file("test.ndf");

        double b = 12.;
        file.write_value(b);

        file.write_vector(v);
    } // close scope -> destroy file (and b)

    iFile ifile("test.ndf");

    double ib;
    ifile.read_value(ib);

    std::cout << ib << std::endl;

    std::vector<double> iv;
    ifile.read_vector(iv);

    std::cout << "vector size: " << iv.size() << std::endl;

    for(auto val : iv){
        std::cout << val << " ";
    }
    std::cout << "last val: " << iv[iv.size() - 1] << std::endl;
}

输出：

wrote a value: 12  current offset: 8
wrote a value: 7  current offset: 16
wrote a value: 1  current offset: 24
wrote a value: 2  current offset: 32
wrote a value: 3  current offset: 40
wrote a value: 4  current offset: 48
wrote a value: 6  current offset: 56
wrote a value: 10  current offset: 64
wrote a value: 15  current offset: 72
value read: 12 current offset: 8
12
value read: 7 current offset: 16
size of vector: 7
value read: 1 current offset: 24
value read: 2 current offset: 32
value read: 3 current offset: 40
value read: 4 current offset: 48
value read: 6 current offset: 56
value read: 10 current offset: 64
value read: 15 current offset: 72
vector size: 7
1 2 3 4 6 10 15 last val: 15

Live Demo on coliru

我不明白为什么它要写入或读取最后一个值2次？

直到我意识到我太专注于读取最后一个值2次，这对我来说还是不清楚的。

实际上，它不是– 它只是无法读取最后一个值，而再次错误地报告了先前的值。

要检查这一点，我在iFile::read_value中添加了一个最小的“错误处理”：

    template <typename T>
    void read_value(T& v){
        file.seekg(offset);
        file.read(reinterpret_cast<char*> (&v), sizeof(T));
        if (!file) std::cerr << "AARG! Input failed. :-(\n";
        offset += sizeof(T);
        std::cout << "value read: " << v << " current offset: " << offset << std::endl;
    }

输出：

wrote a value: 12  current offset: 8
wrote a value: 7  current offset: 16
wrote a value: 1  current offset: 24
wrote a value: 2  current offset: 32
wrote a value: 3  current offset: 40
wrote a value: 4  current offset: 48
wrote a value: 6  current offset: 56
wrote a value: 10  current offset: 64
wrote a value: 15  current offset: 72
value read: 12 current offset: 8
12
value read: 7 current offset: 16
size of vector: 7
value read: 1 current offset: 24
value read: 2 current offset: 32
value read: 3 current offset: 40
value read: 4 current offset: 48
value read: 6 current offset: 56
value read: 10 current offset: 64
AARG! Input failed. :-(
value read: 10 current offset: 72
vector size: 7
1 2 3 4 6 10 10 last val: 10

Live Demo on coliru

当然，文件I / O可能由于各种原因而失败。因此，应始终检查文件操作是否成功。

二进制文件处理程序未写入最后一个值

1 个答案: