我正在开发一个异步任务处理器。我需要高性能处理器,因此使用的同步原语应尽可能低级别。处理器应该拥有一个线程,该线程在没有任务时会休眠,在任务出现时会唤醒。任务处理和任务添加应在不同的线程中执行。
我尝试使用AutoResetEvent
实现,但它具有竞争条件:
public class Processor
{
ConcurrentQueue<Action> _workItemQueue = new ConcurrentQueue<Action>();
AutoResetEvent _newWorkItemAutoResetEvent = new AutoResetEvent(false);
private bool _disposed;
Thread _thread;
public void Do(Action action)
{
_workItemQueue.Enqueue(action);
_newWorkItemAutoResetEvent.Set();
}
public Processor()
{
_workerThread = new Thread(() =>
{
while (!_disposed)
{
_newWorkItemAutoResetEvent.WaitOne(); //
while (_workItemQueue.TryDequeue(out Action action))
{
action();
}
// at this "bad" moment another thread calls Do method.
// New action has been enqueued, but when we call
// _newWorkIteManualAutoEvent.WaitOne() we fall asleep.
}
});
_thread.Start();
}
}
然后我尝试使用ManualResetEvent
实现:
public class Processor
{
ConcurrentQueue<Action> _workItemQueue = new ConcurrentQueue<Action>();
ManualResetEventSlim _newWorkItemManualResetEvent = new ManualResetEventSlim(false);
private bool _disposed;
Thread _thread;
public void Do(Action action)
{
_workItemQueue.Enqueue(action);
_newWorkItemManualResetEvent.Set();
}
public Processor()
{
_workerThread = new Thread(() =>
{
while (!_disposed)
{
_newWorkItemManualResetEvent.WaitOne();
_newWorkItemManualResetEvent.Reset();
while (_workItemQueue.TryDequeue(out Action action))
{
action();
}
}
});
_thread.Start();
}
}
使用ManualResetEvent
时,我看不到任何竞争条件。
问题:对吗?还是我需要另一个同步原语?我正在考虑Count 向上事件(反向CountdownEvent
)。当其计数大于零时发出信号,而当其计数等于零时不发出信号。计数向上事件的计数与要执行的任务的计数相对应。
答案 0 :(得分:1)
方便的BlockingCollection将为您处理大部分操作。
类似的东西:
public sealed class Processor : IDisposable
{
//set a max queue depth to provide back pressure to the request rate
BlockingCollection<Action> _workItemQueue = new BlockingCollection<Action>(32);
private bool _disposed = false;
private Thread _workerThread;
private CancellationTokenSource _cancelTokenSource = new CancellationTokenSource();
public void Do(Action action)
{
_workItemQueue.Add(action);
}
public void Dispose()
{
if (!_disposed)
{
_workItemQueue.CompleteAdding();
_cancelTokenSource.Cancel();
_disposed = true;
}
}
public Processor()
{
_workerThread = new Thread(() =>
{
while (!_workItemQueue.IsCompleted)
{
if (_workItemQueue.TryTake(out Action action, 1000*2,_cancelTokenSource.Token))
{
action();
}
}
});
_workerThread.Start();
}
}