SVN：Python预提交脚本总是失败

Question

我找到了一个示例python脚本并修改了它以在预提交中检查注释。我的问题是由python解析的注释文本总是空白。

• 环境：Windows XP
• SVN版本：svn，版本1.5.6（r36142）编译于2009年3月6日，14：54：47
• Python 2.7

预commit.bat

C:\Python27\python %1\hooks\pre-commit.py %1 %2

pre-commit.py

import sys, os, string, re

SVNLOOK='C:\\SVN\\bin\\svnlook.exe'


# return true or false if this passed string is a valid comment
def check(comment):
    #define regular expression
    print comment
    p = re.match("[bB][uU][gG]\s([0-9]+|NONE)+", comment)
    print p
    return (p != None) #returns false if doesn't match

def result(r, txn, repos, log_msg, log_cmd):
    if r == 1:
        sys.stderr.write ("File: " + repos + " Comment: " + txn + "\n" +\
                          "Log Msg: " + log_msg + "\n" +\
                          "Log Cmd: " + log_cmd + "\n" +\
                            "Comments must have the format of \n'Bug X' \n" +\
                          "'Comment text' where X is the issue number.\n" +\
                          "Use comma to separatemultiple bug id's\n" +\
                          "Example:\nBug 1234, 1235\nComment: Fixed things\n" +\
                          "Use 'NONE' if there is no bug ID")
        sys.exit(r)

def main(repos, txn):
    log_cmd = '%s log %s -t %s' % (SVNLOOK, txn, repos)
    log_msg = os.popen(log_cmd, 'r').readline().rstrip('\n')

    if check(log_msg):
        result(0, txn, repos, log_msg, log_cmd)
    else:
        result(1, txn, repos, log_msg, log_cmd)

if __name__ == '__main__':
    if len(sys.argv) < 3:
        sys.stderr.write("Usage: %s REPOS TXN\n" % (sys.argv[0]))
    else:
        main(sys.argv[1], sys.argv[2])

我已将vars的打印输出添加到错误消息中以进行调试。

令人讨厌的是，如果我使用bat文件命令，事情似乎工作正常：

pre-commit.bat，仅检查空白提交消息：

@echo off  
:: Stops commits that have empty log messages.        
@echo off  

setlocal  

rem Subversion sends through the path to the repository and transaction id  
set REPOS=%1  
set TXN=%2           


rem line below ensures at least one character ".", 5 characters require change to "....."
C:\SVN\bin\svnlook.exe log %REPOS% -t %TXN% | findstr . > nul  
if %errorlevel% gtr 0 (goto err) else exit 0  

:err  
echo. 1>&2  
echo Your commit has been blocked because you didn't enter a comment. 1>&2  
echo Write a log message describing the changes made and try again. 1>&2
echo Thanks 1>&2
exit 1

我做错了什么？

Answer 1

当您通过Python运行它时，批处理文件中将忽略由Python设置的错误代码;你会想要这样做：

C:\Python27\python %1\hooks\pre-commit.py %1 %2
exit %ERRORLEVEL%

引用你的vaules也是一个好主意，以确保它们完整地通过Python：

C:\Python27\python "%1\hooks\pre-commit.py" "%1" "%2"
exit %ERRORLEVEL%