在同一过程中进行加密和解密时,如何解决“填充无效且无法删除”

时间:2019-06-01 10:18:16

标签: c# encryption aes rijndael

我正在尝试加密和解密xml文件。该程序尝试打开,编辑和重新加密数据,但出现错误“ System.Security.Cryptography.CryptographicException:填充无效,无法删除。”当我加密时,然后解密运行该程序两次,它工作正常,但同时执行这两个程序时会出错。

这是一个非常常见的错误,也是一个非常模糊的错误,带有许多不同的“方案”。我已经搜索了一种修复它的方法,并且我已经在线尝试了所有“修复”。还没有一个工作。

class Program
    {
        static void Main(string[] args)
        {
        }
        public static void encFile(string input, string password)
        {
            GCHandle gch = GCHandle.Alloc(password, GCHandleType.Pinned);

            FileEncrypt(input, password);

            ZeroMemory(gch.AddrOfPinnedObject(), password.Length * 2);
            gch.Free();
        }
        public static string output;
        public static void decFile(string input, string password)
        {
            GCHandle gch = GCHandle.Alloc(password, GCHandleType.Pinned);

            // Decrypt the file
            output = FileDecrypt(input, password);

        }

        [DllImport("KERNEL32.DLL", EntryPoint = "RtlZeroMemory")]
        public static extern bool ZeroMemory(IntPtr Destination, int Length);

        /// <summary>
        /// Encrypts a file from its path and a plain password.
        /// </summary>
        /// <param name="inputFile"></param>
        /// <param name="password"></param>
        private static void FileEncrypt(string inputFile, string password)
        {
            File.WriteAllText(Path.GetDirectoryName(inputFile) + "\\" + Path.GetFileNameWithoutExtension(inputFile) + ".dat", Crypto.EncryptStringAES(File.ReadAllText(inputFile), "Password123!"));
        }

        /// <summary>
        /// Decrypts an encrypted file with the FileEncrypt method through its path and the plain password.
        /// </summary>
        /// <param name="inputFile"></param>
        /// <param name="outputFile"></param>
        /// <param name="password"></param>
        private static string FileDecrypt(string inputFile, string password)
        {
            return Crypto.DecryptStringAES(File.ReadAllText(inputFile), password);
        }
    }
    public class Crypto
    {

        //While an app specific salt is not the best practice for
        //password based encryption, it's probably safe enough as long as
        //it is truly uncommon. Also too much work to alter this answer otherwise.
        private static byte[] _salt = Encoding.ASCII.GetBytes("rxONBa*&e03!%76N9mBlbR#@Xl&A&w");

        /// <summary>
        /// Encrypt the given string using AES.  The string can be decrypted using 
        /// DecryptStringAES().  The sharedSecret parameters must match.
        /// </summary>
        /// <param name="plainText">The text to encrypt.</param>
        /// <param name="sharedSecret">A password used to generate a key for encryption.</param>
        public static string EncryptStringAES(string plainText, string sharedSecret)
        {
            if (string.IsNullOrEmpty(plainText))
                throw new ArgumentNullException("plainText");
            if (string.IsNullOrEmpty(sharedSecret))
                throw new ArgumentNullException("sharedSecret");

            string outStr = null;                       // Encrypted string to return
            RijndaelManaged aesAlg = null;              // RijndaelManaged object used to encrypt the data.

            try
            {
                // generate the key from the shared secret and the salt
                Rfc2898DeriveBytes key = new Rfc2898DeriveBytes(sharedSecret, _salt);

                // Create a RijndaelManaged object
                aesAlg = new RijndaelManaged();
                aesAlg.Key = key.GetBytes(aesAlg.KeySize / 8);
                aesAlg.Padding = PaddingMode.PKCS7;
                // Create a decryptor to perform the stream transform.
                ICryptoTransform encryptor = aesAlg.CreateEncryptor(aesAlg.Key, aesAlg.IV);

                // Create the streams used for encryption.
                using (MemoryStream msEncrypt = new MemoryStream())
                {
                    // prepend the IV
                    msEncrypt.Write(BitConverter.GetBytes(aesAlg.IV.Length), 0, sizeof(int));
                    msEncrypt.Write(aesAlg.IV, 0, aesAlg.IV.Length);
                    using (CryptoStream csEncrypt = new CryptoStream(msEncrypt, encryptor, CryptoStreamMode.Write))
                    {
                        using (StreamWriter swEncrypt = new StreamWriter(csEncrypt))
                        {
                            //Write all data to the stream.
                            swEncrypt.Write(plainText);
                        }
                    }
                    outStr = Convert.ToBase64String(msEncrypt.ToArray());
                }
            }
            finally
            {
                // Clear the RijndaelManaged object.
                if (aesAlg != null)
                    aesAlg.Clear();
            }

            // Return the encrypted bytes from the memory stream.
            return outStr;
        }

        /// <summary>
        /// Decrypt the given string.  Assumes the string was encrypted using 
        /// EncryptStringAES(), using an identical sharedSecret.
        /// </summary>
        /// <param name="cipherText">The text to decrypt.</param>
        /// <param name="sharedSecret">A password used to generate a key for decryption.</param>
        public static string DecryptStringAES(string cipherText, string sharedSecret)
        {
            if (string.IsNullOrEmpty(cipherText))
                throw new ArgumentNullException("cipherText");
            if (string.IsNullOrEmpty(sharedSecret))
                throw new ArgumentNullException("sharedSecret");

            // Declare the RijndaelManaged object
            // used to decrypt the data.
            RijndaelManaged aesAlg = null;

            // Declare the string used to hold
            // the decrypted text.
            string plaintext = null;

            try
            {
                // generate the key from the shared secret and the salt
                Rfc2898DeriveBytes key = new Rfc2898DeriveBytes(sharedSecret, _salt);

                // Create the streams used for decryption.                
                byte[] bytes = Convert.FromBase64String(cipherText);
                using (MemoryStream msDecrypt = new MemoryStream(bytes))
                {
                    // Create a RijndaelManaged object
                    // with the specified key and IV.
                    aesAlg = new RijndaelManaged();
                    aesAlg.Key = key.GetBytes(aesAlg.KeySize / 8);
                    // Get the initialization vector from the encrypted stream
                    aesAlg.IV = ReadByteArray(msDecrypt);
                    aesAlg.Padding = PaddingMode.PKCS7;
                    // Create a decrytor to perform the stream transform.
                    ICryptoTransform decryptor = aesAlg.CreateDecryptor(aesAlg.Key, aesAlg.IV);
                    using (CryptoStream csDecrypt = new CryptoStream(msDecrypt, decryptor, CryptoStreamMode.Read))
                    {
                        using (StreamReader srDecrypt = new StreamReader(csDecrypt))

                            // Read the decrypted bytes from the decrypting stream
                            // and place them in a string.
                            plaintext = srDecrypt.ReadToEnd();
                    }
                }
            }
            finally
            {
                // Clear the RijndaelManaged object.
                if (aesAlg != null)
                    aesAlg.Clear();
            }

            return plaintext;
        }

        private static byte[] ReadByteArray(Stream s)
        {
            byte[] rawLength = new byte[sizeof(int)];
            if (s.Read(rawLength, 0, rawLength.Length) != rawLength.Length)
            {
                throw new SystemException("Stream did not contain properly formatted byte array");
            }

            byte[] buffer = new byte[BitConverter.ToInt32(rawLength, 0)];
            if (s.Read(buffer, 0, buffer.Length) != buffer.Length)
            {
                throw new SystemException("Did not read byte array properly");
            }

            return buffer;
        }
    }

运行以下先加密然后解密的代码将产生错误:

static void Main(string[] args)
        {
            string password = "Password123!";
            encFile(@"C:\KaliPatriot\test.xml", password);
            decFile(@"C:\KaliPatriot\test.dat", password);
            Console.WriteLine(output);
        }

但是,如果您尝试先运行以下仅加密文件的代码:

static void Main(string[] args)
        {
            string password = "Password123!";
            encFile(@"C:\KaliPatriot\test.xml", password);
        }

,然后在加密后在另一个过程中解密文件:

static void Main(string[] args)
        {
            string password = "Password123!";
            decFile(@"C:\KaliPatriot\test.dat", password);
            Console.WriteLine(output);
        }

然后程序将正确输出内容,而不会出现错误。

如何在一次运行中对文件进行加密和解密,而不会出现任何错误。

1 个答案:

答案 0 :(得分:1)

变量password和具有相同名称的参数指向相同的常量字符串。您的第一个方法会将该字符串归零。

    static void Main(string[] args)
    {
        string password = "Password123!";
        string password2 = "Password123!";

        encFile(@"C:\KaliPatriot\test.xml", password);
        // password is now "\0\0\0\0\0\0\0\0\0"
        // password2 is also "\0\0\0\0\0\0\0\0\0", depending on Framework and settings

        decFile(@"C:\KaliPatriot\test.dat", password);
        Console.WriteLine(output);
    }

使用这样的字符串非常危险。假定字符串是(并且假定)不可变的,并且.NET还使用字符串的Interning。

您已经设法用C#获得UB(未定义行为),这不是值得骄傲的事情。