双线程释放中的卷曲请求

时间:2019-03-15 09:27:51

标签: c curl pthreads malloc free

当我运行N个线程,并且在每个线程中,我使用curl响应char*来动态分配请求时,我都会遇到问题。 有时,当我自由回复时,遇到错误double free or corruption (fasttop)。下面的代码:

static void* crawler_threadHandler(void* _arg) 
{
    size_t thisId = (size_t)_arg;
    crawler_thread* thisThread = &crawler.threads[thisId];
    CURL *curl = curl_easy_init();

    if (crawler.prepareRequestCommon != NULL)
    {
        crawler.prepareRequestCommon(curl);
    }

    while(thisThread->stopRequest == false)
    {
        crawler_runRequest(curl);

        sleep(1);
    }

    curl_easy_cleanup(curl);
    thisThread->isRunning = false;

    return NULL;
}

static void crawler_runRequest(CURL* curl)
{
    CURLcode res;
    struct curl_slist* headers = NULL;
    char* response = (char*) malloc(1);

    if (crawler.prepareRequestEach != NULL)
    {
        crawler.prepareRequestEach(curl, headers);
    }

    curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, crawler_reponseWriteCallback);
    curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void*) response);
    curl_easy_setopt(curl, CURLOPT_HTTPHEADER, headers);
    res = curl_easy_perform(curl);
    curl_slist_free_all(headers);

    if(res != CURLE_OK)
    {
        fprintf(
            stderr, 
            "curl_easy_perform() failed: %s\n",
            curl_easy_strerror(res)
        );
    }
    else
    {
        if (crawler.parseResponse != NULL)
        {
            crawler.parseResponse(response);
        }
    }

    if (response != NULL)
    {
        free(response); //Here is crash
    }
}

static size_t crawler_reponseWriteCallback(void *contents, size_t size, size_t nmemb, void *userp)
{
    size_t realsize = size * nmemb;

    userp = realloc(userp, realsize + 1);

    if (userp == NULL)
    {
        fprintf(
            stderr, 
            "No space left in head for allocate response, bytes: %zu\n", 
            realsize
        );
        realsize = 0;
    }
    else
    {
        char terminateNull = '\0';
        memcpy(userp, contents, realsize);
        memcpy(userp + realsize, &terminateNull, 1);
    }

    return realsize;
}

函数crawler_threadHandler

的pthread处理程序调用
errno = pthread_create(&thread.pthread, NULL, crawler_threadHandler, (void*) i);

我的意思是有时会崩溃:当我运行3个线程时,崩溃会发生1或2次。

请帮助我不知道错误在哪里。

编辑:更改后有效:

//crawler_runRequest
curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void*) &response);

...

//crawler_reponseWriteCallback
void** responsePtr = userp;
*responsePtr = realloc(*responsePtr, realsize + 1);

...

memcpy(*responsePtr, contents, realsize);
memcpy(*responsePtr + realsize, &terminateNull, 1);

0 个答案:

没有答案