Question

大家！我是编程方面的新手，但无法为该问题找到合适的答案。我会尽力解释一下：

我想知道是否有任何方法可以缩短我的代码，以免在以下情况下如此重复。

class vehicle:
    colour = 0
    turbo = 0
    quality = 1
    type = 0

    def create_vehicle(self, pick_colour, add_turbo, define_quality, pick_type):
        self.colour = pick_colour
        self.turbo = add_turbo
        self.quality = define_quality
        self.type = pick_type
        return (self.colour, self.turbo, self.quality, self.type)

#This is the part I want to shorten up#

    def check_vehicle(self):
        if self.type == 0:
            self.type = "motorbike"
        elif self.type == 1:
            self.type = "car"
        elif self.type == 2:
            self.type = "van"
        if self.quality == 1:
            self.quality = "basic"
        elif self.quality == 2:
            self.quality = "normal"
        elif self.quality == 3:
            self.quality = "good"
        elif self.quality == 4:
            self.quality = "superior"
        if self.colour == 0:
            self.colour = "white"
        elif self.colour == 1:
            self.colour = "red"
        elif self.colour == 2:
            self.colour = "yellow"
        elif self.colour == 3:
            self.colour = "blue"
        elif self.colour == 4:
            self.colour = "green"
        elif self.colour == 5:
            self.colour = "black"
        elif self.colour == 6:
            self.colour = "orange"
        elif self.colour == 7:
            self.colour = "grey"
        if self.turbo == 0:
            self.turbo = "does not have"
        elif self.turbo == 1:
            self.turbo = "has"
        print("The %s I've created has a %s quality. It is %s and %s turbo" % (self.type, self.quality, self.colour, self.turbo))

"""
Types:
    0 = Motorbike
    1 = Car
    2 = Van
Quality:
    From 1 to 4
    Increases general stats of the vehicle (Speed, Appearance, Maneuverability)
    1 = Basic
    2 = Normal
    3 = Good
    4 = Superior
Colour:
    0 = White
    1 = Red
    2 = Yellow
    3 = Blue
    4 = Green
    5 = Black
    6 = Orange
    7 = Grey
"""

vehicle1 = vehicle()
vehicle1.create_vehicle(5, 1, 4, 0)
vehicle1.check_vehicle()

我检查了一下自己，这段代码输出以下内容：

The motorbike I've created has a superior quality. It is black and has turbo

有效！好极了！但是，问题是我想缩短上面上面突出显示的部分代码。谢谢您的帮助

Answer 1

如果您使用的是Python 2.7，则需要从Object继承。即

class vehicle:

应该成为

class vehicle(Object):

有关为什么查看Python class inherits object

的信息

根据您的用例，最好定义一个构造函数（aka init ），而不是create_vehicle（..）。

有关更多信息，请参见https://micropyramid.com/blog/understand-self-and-init-method-in-python-class/

对于 check_vehicle ，我通过使用字典来简化。例如

types = {
    1: "motorbike",
    2: "car",
    3:......etc
}

然后

def check_vehicle(self):
    if self.type in types:
        self.type = types[self.type]
    else:
        print "My error message"

https://www.w3schools.com/python/python_dictionaries.asp

Answer 2

您可以使用列表或词典将代码转换为描述。但是，我建议您只想打印描述，就避免更新对象的成员。

def check_vehicle(self):
    types     = [ "motorbike", "car", "van" ]
    qualities = [ "", "basic", "normal", "good", "superior" ]
    colours   = [ "white", "red", "yellow", "blue", "green", "black" ]
    hasTurbo  = ["does not have","has"]
    self.type    = types[self.type]
    self.quality = qualities[self.quality]
    self.colour  = colours[self.colour]
    self.turbo   = hasTurbo[self.turbo]
    print("The %s I've created has a %s quality. It is %s and %s turbo" % (self.type, self.quality, self.colour, self.turbo))

这样的情况有捷径吗？

2 个答案: