Ruby on Rails的nil:NilClass未定义方法“ destroy”

时间:2019-02-21 12:05:12

标签: ruby-on-rails ruby

删除用户帖子时出现问题:

  

nil:NilClass的未定义方法“ destroy”

# routes.rb
Rails.application.routes.draw do
  get 'sessions/new'
  get 'users/new'
  get 'user/new'
  root to:'pages#home'
  get '/home', to:'pages#home'
  get '/help', to:'pages#help'
  get '/about', to:'pages#about'
  get '/contact',  to:'pages#contact'
  get '/signup', to: 'users#new'
  post '/signup', to: 'users#create'
  get '/login', to: 'sessions#new'
  post '/login', to: 'sessions#create'
  delete '/logout', to: 'sessions#destroy'
  post '/micro_posts', to: 'microposts#create'
  delete '/micro_posts', to: 'microposts#destroy'

  resources :users
  resources :account_activations, only: [:edit]
  resources :microposts, only: [:create, :destroy]
end


# microposts_controller.rb 

class MicropostsController < ApplicationController
  before_action :logged_in_user, only: [:create, :destroy]
  before_action :correct_user, only: [:destroy]

  def create
    @micropost = current_user.micro_posts.build(req_params)

    if @micropost.save
        flash[:success] = "Post created"
        redirect_to root_url    
    else
        @feed_items = []
        render 'pages/home'

    end     
  end

  def destroy   
    @micropost.destroy
    flash[:success] = "Post deleted"
    redirect_to request.referrer || root_url
  end    

  private

  def req_params
    params.require(:micro_post).permit(:content)
  end

  def correct_user
    @micropost = current_user.micro_posts.find_by_id(params[:id])
    redirect_to root_url if @micropost.nil?
  end    
end

# _micro_post.html.erb file

<li id="micropost" ><%= micro_post.id %>
  <%= link_to gravatar_for(micro_post.user, size: 50), micro_post.user %>
  <span class="user" ><%= link_to micro_post.user.name, micro_post.user %></span><br/>
  <span class="content" ><%= micro_post.content %></span>
  <br/> 
  <span  class="timestamp">
  posted <%= time_ago_in_words(micro_post.created_at) %> ago    

  <% if current_user?(micro_post.user) %>
    <%= link_to '  | Delete', micro_posts_path, method: :delete , data: { confirm: "Are you sure" } %>
  <% end %>    
  </span>
  <br/>    
</li>

现在我发现我的错误是在microposts_controller.rb中 参考方法“ correct_user”中找到文件,因为找不到 micropost的ID,并返回nil。所以我们不能称之为 在nil对象上销毁方法。你能告诉我为什么不是吗 找到微博ID?

Started DELETE "/micro_posts" for 127.0.0.1 at 2019-02-21 21:43:17 +0500
   (0.7ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
  ↳ C:/Ruby25-x64/lib/ruby/gems/2.5.0/gems/activerecord-5.2.2/lib/active_record/log_subscriber.rb:98
Processing by MicropostsController#destroy as HTML
  Parameters: {"authenticity_token"=>"aNeBnIy/JOrWz+sQdzU2w06faILW2dM+f8SPwmXVmJs1XfJ8OqbkgPVwkpoY/HBjh8YJhVPWZ4BC1Onxg0AtWw=="}
  User Load (0.2ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 1], ["LIMIT", 1]]
  ↳ app/helpers/sessions_helper.rb:16
  MicroPost Load (0.3ms)  SELECT  "micro_posts".* FROM "micro_posts" WHERE "micro_posts"."id" IS NULL LIMIT ?  [["LIMIT", 1]]
  ↳ app/controllers/microposts_controller.rb:36
Completed 500 Internal Server Error in 56ms (ActiveRecord: 1.9ms)



NoMethodError (undefined method `destroy' for nil:NilClass):

app/controllers/microposts_controller.rb:22:in `destroy

6 个答案:

答案 0 :(得分:1)

在您的correct_user方法中看起来有问题。尝试将其删除并使用这种方式:

class MicropostsController < ApplicationController
  before_action :logged_in_user, only: [:create, :destroy]
  before_action :set_micropost, only: :destroy

  ...

  def set_micropost
    @micropost ||= Micropost.find params[:id]
  end
end

在您看来:

<%= link_to '  | Delete', @micropost, method: :delete , data: { confirm: "Are you sure" } %>

答案 1 :(得分:1)

如果您不介意,我将把我的评论转换为答案,以免使问题无解。

您有一个命名问题。模型为MicroPost,但控制器为MicropostsController。这就是为什么您要创建自定义路线的原因。

您需要将控制器重命名为MicroPostsController,并将其文件重命名为micro_posts_controller.rb。从route.rb中删除以下两行:

post '/micro_posts', to: 'microposts#create'
delete '/micro_posts', to: 'microposts#destroy'

在此处将microposts更改为micro_posts(注意下划线):

resources :microposts, only: [:create, :destroy]

使用micro_post_path(micro_post)删除视图中的链接

答案 2 :(得分:0)

是的,您必须设置@micropost beofre的值以尝试销毁它。 通常,这是您要使用params hash进行的操作,因此在@micropost = Micropost.find(params[:id])方法的开头可以像destroy这样。这是您可能想在控制器中的其他方法中使用的一行,因此您可以按照以下说明对其进行重构

class MicropostsController < ApplicationController
  before_action :set_micropost, only: [:destroy]

 ...

  private

  def set_micropost
    @micropost = Micropost.find(params[:id])
  end
end

希望它会有所帮助:)

答案 3 :(得分:0)

我认为您应该将id参数传递给视图中的删除路由。

代替此:

<%= link_to ' | Delete', micro_posts_path, method: :delete , data: { confirm: "Are you sure" } %>

尝试一下: <%= link_to ' | Delete', micro_posts_path(micro_post.id), method: :delete , data: { confirm: "Are you sure" } %>

答案 4 :(得分:0)

尝试一下:

<%= link_to '  | Delete', micro_post_path(micro_post), method: :delete , data: { confirm: "Are you sure" } %>

问题是您正在使用收集路线。 micro_posts_path是一个收集路由,您需要使用带有资源ID的成员路由。因此,在这种情况下,我们从路由中删除了s,它成为成员路由的micro_post_path

答案 5 :(得分:0)

我没有注意到@zeitnot在我面前有同样的建议。


我认为您的问题是删除链接未引用实际对象。您没有传递对象ID,因此[ { "operation": "shift", "spec": { "response": { "Attribute": { "*": { "@type": "[#2].TYPE", "@category": "[#2].CATEGORY" } } } } } ] 总是为零。

试试看是否可行:

params[:id]