查询将删除所有条目,而不是选定的条目

时间:2019-02-20 12:05:08

标签: mysql joomla

我做了一个下拉菜单,该菜单是从joomla数据库填充的。菜单包含特定用户的峰名称。这部分工作顺利。 当用户从下拉菜单中选择峰名称并单击删除按钮时,查询应仅删除具有特定用户ID($ link_id)和所选顶部名称($ vrh_name2)的行。

就我而言,查询会删除此用户的所有行,而不管所选顶部的名称是什么

我在哪里弄错了?

<!DOCTYPE html>
<html>
<body>

<?php
echo '<div class="sender">';
$link_id = JRequest::getInt('link_id'); 
echo '<h4>Form for delete peak</h4>';

// Creating Dropdown menu from database
   
$db = JFactory::getDbo();
$query2 = $db->getQuery(true);
$query2->select('peak_name');
$query2->from($db->qn('#__climbing'));
$query2->where($db->quoteName('#__climbing.link_id')." = ".$db->quote($link_id));
$query2->order('peak_id ASC');
$db->setQuery($query2);
$peaks_list2 = $db->loadColumn();
$peaks_select2  = '<select name2="name2" id2="peaks">';
$peaks_select2 .= '<option value="">-- Select peak for delete --</option>';

foreach($peaks_list2 as $p2){
    $peaks_select2 .= '<option value="' . $p2 . '">' . $p2 . '</option>';  
}
$peaks_select2 .= '</select>';
?>

<form name="lista2" method="post" action="">
<?php echo $peaks_select2; ?>
<input type="submit" name="submit2" value="Delete" />
</form>
<?php

if(isset($_POST['submit2']))
{
$vrh_name2 = $_POST['name2'];

// Delete peak query

$db = JFactory::getDbo();
$q_4 = $db->getQuery(true);
$q_4->delete($db->quoteName('#__climbing'));
$q_4->where($db->quoteName('#__climbing.link_id')." = ".$db->quote($link_id))." AND ".($db->quoteName('#__climbing.peak_name')." = ".$db->quote($vrh_name2));
$db->setQuery($q_4);
$db->execute();
}
echo '</div>';
?>
</body> 
</html>

2 个答案:

答案 0 :(得分:1)

让我们不要忘记some of the past advice that I have offered

在此问题中最引人注意的是,$peaks_select2 = '<select name2=将不起作用。 name属性必须是纯净的。

通过先执行潜在的删除操作,您可以允许用户在删除后进行删除,并始终在选择中看到最新的数据。

我不喜欢您使用peak_name作为标识符。您的表有一个peak_id,在大多数情况下,这些表应该是自动递增的并且是唯一的,它们是专业人员关联相关数据的方式。 (您应该更改设计以采用这种做法。)

如果选项的value属性值与选项的文本值相同,则无需声明name属性。因为我建议使用ID,所以我声明了name属性。

未经测试的代码段:

<!DOCTYPE html>
<html>
<body>

<?php
// get the $_POST['submit'] value; if missing, set as empty string (WORD is a Joomla-specific filter that strips unwanted characters for security reasons)
$action = JFactory::getApplication()->input->post->get('submit', '', 'WORD')

// get the $_POST['peak_id'] value; if missing set as 0 (INT strips any character that is not a digit)
$peak_id = JFactory::getApplication()->input->post->get('peak_id', 0, 'INT');

// try to get the $_POST['link_id'] value; if it is missing, try from $_GET['link_id']
$hiker_id = JFactory::getApplication()->input->post->get('link_id', 0, 'INT');
if (!$hiker_id)
{
    // there was no submission (this is the first load of the page)
    $hiker_id = JFactory::getApplication()->input->get->get('link_id', 0, 'INT');
}
echo "<div>Link Id: $hiker_id</div>";

$db = JFactory::getDbo();

if ($action === 'Delete' && $peak)  // if action is Delete and $peak is not empty or 0
{
    $delete_query = $db->getQuery(true)
        ->delete("#__climbing")
        ->where([
            "link_id = " . (int) $hiker_id,
            "peak_id = " . (int) $peak_id
        ]);
    $db->setQuery($delete_query);
    $db->execute();
    if ($db->getAffectedRows())  // check for successful deletion (if at least one row was deleted)
    {
        echo "<div>Successfully deleted row for hiker#: $hiker_id, peak#: $peak_id</div>";
    }
    else
    {
        echo "<div>Failed to delete row for hiker#: $hiker_id, peak#: $peak_id</div>";
    }
}

// now query the table for the fresh data after the (potential) delete was performed
$peaks_query = $db->getQuery(true)
    ->select("peak_id, peak_name")
    ->from("#__climbing")
    ->where("link_id = " . (int) $link_id)
    ->order("peak_id");
$db->setQuery($peaks_query);

$peaks_select = '<select name="peak_id">';
$peaks_select .= '<option value="0">-- Select peak to delete --</option>';
if (!$results = $db->loadAssocList())  // there were no rows in the result set
{
    // no peaks found for $link_id
}
else
{
    foreach ($results as $row)
    {
        $peaks_select .= "<option value=\"{$row['peak_id']}\">{$row['peak_name']}</option>";  // create option with name as text and id as the value
    }
}
$peaks_select .= '</select>';

// print the simple form...
?>
<div class="sender">
    <h4>Peak Delete Form</h4>
    <form method="post" action="">
        <?=$peaks_select?>
        <input type="hidden" name="link_id" value="<?=$hiker_id?>">
        <input type="submit" name="submit" value="Delete" />
    </form>
</div>
</body> 
</html>

答案 1 :(得分:0)

嗨,如果我理解您的尝试,并根据以下信息提供此信息:

您可以使用以下代码执行删除:

<!DOCTYPE html>
<html>
<body>

<?php
echo '<div class="sender">';
$link_id = JRequest::getInt('link_id'); 
echo '<h4>Form for delete peak</h4>';

// Creating Dropdown menu from database
.
$db = JFactory::getDbo();
$query2 = $db->getQuery(true);
$query2->select('peak_name');
$query2->from($db->qn('#__climbing'));
$query2->where($db->quoteName('#__climbing.link_id')." = ".$db->quote($link_id));
$query2->order('peak_id ASC');
$db->setQuery($query2);
$peaks_list2 = $db->loadColumn();
$peaks_select2  = '<select name2="name2" id2="peaks">';
$peaks_select2 .= '<option value="">-- Select peak for delete --</option>';

foreach($peaks_list2 as $p2){
    $peaks_select2 .= '<option value="' . $p2 . '">' . $p2 . '</option>';  
}
$peaks_select2 .= '</select>';
?>

<form name="lista2" method="post" action="">
<?php echo $peaks_select2; ?>
<input type="submit" name="submit2" value="Delete" />
</form>
<?php

  if(isset($_POST['submit2']))
  {
     $vrh_name2 = $_POST['name2'];

     // Delete peak query
     $db = JFactory::getDbo();
     $q_4 = $db->getQuery(true);
     // delete all row where this conditions link_id and peak_name
    $conditions = array(
        $db->quoteName('link_id') . ' =' . $db->quote($link_id)), 
        $db->quoteName('peak_name') . ' = ' . $db->quote($vrh_name2))
    );
    $q_4->delete($db->quoteName('#__climbing'));
    $q_4->where($conditions);
    $db->setQuery($q_4);

    $db->execute();
}
echo '</div>';
?>
</body> 
</html>