Question

我正在学习go，并且正在改编testdouble中的Java生活游戏示例。但是，我编写的测试间谍错误地比较了World结构的相等性-由于未调用output(world)，因此测试在失败时通过。我在做什么错？

测试：

package gameoflife

import (
    "testing"

    "github.com/google/go-cmp/cmp"
)

func TestZeroGenerations(t *testing.T) {
    generatesSeedWorldStub := GeneratesSeedWorldStub{}
    outputsWorldSpy := OutputsWorldSpy{}
    conway := NewSimulatesConway(&generatesSeedWorldStub, &outputsWorldSpy)
    seedWorld := World{}

    conway.simulate()

    correctWorld := outputsWorldSpy.wasOutputCalledWithWorld(seedWorld)
    if !correctWorld {
        t.Errorf("Output called with seed world, expected: %t, got: %t", true, correctWorld)
    }
}

type GeneratesSeedWorldStub struct{}

func (gsw *GeneratesSeedWorldStub) generate() World {
    return World{}
}

type OutputsWorldSpy struct {
    outputCalledWithWorld World
}

func (ow *OutputsWorldSpy) output(world World) {
    ow.outputCalledWithWorld = world
}

func (ow *OutputsWorldSpy) wasOutputCalledWithWorld(world World) bool {
    return cmp.Equal(world, ow.outputCalledWithWorld)
}

实施：

package gameoflife

type SimulatesConway struct {
    generatesSeedWorld GeneratesSeedWorld
    outputsWorld       OutputsWorld
}

func NewSimulatesConway(generatesSeedWorld GeneratesSeedWorld, outputsWorld OutputsWorld) SimulatesConway {
    return SimulatesConway{generatesSeedWorld: generatesSeedWorld, outputsWorld: outputsWorld}
}

func (sc *SimulatesConway) simulate() {
    // seedWorld := sc.generatesSeedWorld.generate()
    // sc.outputsWorld.output(seedWorld)
}

type GeneratesSeedWorld interface {
    generate() World
}

type OutputsWorld interface {
    output(world World)
}

type World struct{}

Answer 1

golang在被称为outputsWorldSpy := OutputsWorldSpy{}时在outputsWorldSpy.outputCalledWithWorld = World{}中分配了默认值，而您分配了seedWorld := World{}。因此它们是相同的，这就是测试通过的原因。如果您想处理这种情况，我建议使用指针。

type OutputsWorldSpy struct {
    outputCalledWithWorld *World
}

func (ow *OutputsWorldSpy) output(world World) {
    ow.outputCalledWithWorld = &world
}

func (ow *OutputsWorldSpy) wasOutputCalledWithWorld(world World) bool {
    if ow.outputCalledWithWorld == nil {
        return false
    }
    return cmp.Equal(world, *ow.outputCalledWithWorld)
}

golang测试间谍错误地比较了相等性

1 个答案: