移除关联后，Rails不会清除多态_type字段

时间：2018-11-08 08:55:07

标签： ruby-on-rails ruby-on-rails-5 simple-form polymorphic-associations simple-form-for

我有可以通过多态关联（可选）属于ServiceType或ServiceAddonType的Article模型：

enter image description here

模型

文章

class Article < ApplicationRecord
  belongs_to :accountable, polymorphic: true, optional: true
end

ServiceType 

class ServiceType < ApplicationRecord
  has_many :articles, as: :accountable
end

ServiceAddonType 

class ServiceAddonType < ApplicationRecord
  has_many :articles, as: :accountable
end

文章迁移

class CreateArticles < ActiveRecord::Migration[5.1]
  def change
    create_table :articles, id: :uuid do |t|
      t.references :accountable, polymorphic: true, index: true, type: :uuid
    end
  end
end

问题：

向ServiceType添加文章时，一切正常。多态字段获得以下值：

accountable_id: service_type.id
accountable_type: 'ServiceType'

从ServiceType中删除文章后，字段的值为：

accountable_id: nil
accountable_type: 'ServiceType'

为什么？如何正确解决此问题，以便在删除关系后accountable_type也将成为nil？ 我对Article模型进行了before_save回调，如果accountable_id为nil时将清除该字段，但是实际上，这似乎根本没有任何作用（ 'ServiceType'仍保留为_type值）。我猜这可能是因为那时文章更新没有通过ActiveRecord，而是从ServicType中删除时通过了原始SQL查询。因此，回调永远不会被调用。无论如何，我也觉得应该有一些更好的方法来实现这一目标。

EDIT1：

从service_type中删除文章：

ServiceType表单（细长型语法）： 这为我提供了一个框，其中包含已分配给服务类型的商品及其复选框的列表。通过取消选中它们并单击表单上的提交，我可以删除该关系。

- if service_type.persisted?
    .square-box.small-12.medium-5
      - if service_type.articles.present?
        h5= t('article.assigned')
        = f.association :articles, collection: service_type.articles, as: :check_boxes, label: false
      - else
        = t('service_type.no_articles_assigned_yet')

ServiceTypeController＃update带有strong_params的：

def update
  if @service_type.update(service_type_params)
    redirect_to service_types_path, notice: t(
      'service_type.successful_update',
      service_type_name: @service_type.name
    )
  else
    redirect_to edit_service_type_path(@service_type), alert: @service_type.errors.full_messages.join(', ')
  end
end

private

def service_type_params
  params.require(:service_type).permit(:name, article_ids: [])
end

EDIT2：

带有测试过的回调的文章模型的更完整版本。 添加时，实际上会调用该回调，但是删除时，不会调用该回调。

class Article < ApplicationRecord
  belongs_to :accountable, polymorphic: true, optional: true

  default_scope { order(:name) }

  before_save :arrange_polymorphic_fields

  private

  def arrange_polymorphic_fields
    def arrange_polymorphic_fields
      !accountable_id.present? && self.accountable_type = nil
    end
  end
end

从服务类型中删除文章的跟踪日志：

Started PATCH "/service_types/acfe9618-69d4-4564-9ab5-65a50dc4b26a" for 127.0.0.1 at 2018-11-08 16:23:57 +0200
Processing by ServiceTypesController#update as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"bbBWybKuXcwcYVZZqcL88VRY1U6puY9rz2TczyNEghlM+WIIf46lGtNYBk+sUITtLzhHWcNZl1FJL9s630rOgw==", "service_type"=>{"name"=>"Service-type 1", "article_ids"=>["", "8c2d53d8-9016-4e7b-85c8-d111797aa9d0", "84573dc7-c532-4055-a43d-ef5917cf1ec0", "0dc6da24-c221-4c24-9b22-c39b2f82a9d5", "f6a4dd0d-17bf-4bfd-9cc5-d871d23ad727", "25b25ed1-e4ae-43a6-87e7-f346def15aa5"]}, "id"=>"acfe9618-69d4-4564-9ab5-65a50dc4b26a"}
  ServiceType Load (0.9ms)  SELECT  "service_types".* FROM "service_types" WHERE "service_types"."id" = $1 ORDER BY "service_types"."name" ASC LIMIT $2  [["id", "acfe9618-69d4-4564-9ab5-65a50dc4b26a"], ["LIMIT", 1]]
   (0.5ms)  BEGIN
  Article Load (1.2ms)  SELECT "articles".* FROM "articles" WHERE "articles"."id" IN ('8c2d53d8-9016-4e7b-85c8-d111797aa9d0', '84573dc7-c532-4055-a43d-ef5917cf1ec0', '0dc6da24-c221-4c24-9b22-c39b2f82a9d5', 'f6a4dd0d-17bf-4bfd-9cc5-d871d23ad727', '25b25ed1-e4ae-43a6-87e7-f346def15aa5') ORDER BY "articles"."name" ASC
  Article Load (1.1ms)  SELECT "articles".* FROM "articles" WHERE "articles"."accountable_id" = $1 AND "articles"."accountable_type" = $2 ORDER BY "articles"."name" ASC  [["accountable_id", "acfe9618-69d4-4564-9ab5-65a50dc4b26a"], ["accountable_type", "ServiceType"]]
  SQL (1.7ms)  UPDATE "articles" SET "accountable_id" = NULL WHERE "articles"."id" IN (SELECT "articles"."id" FROM "articles" WHERE "articles"."accountable_id" = $1 AND "articles"."accountable_type" = $2 AND "articles"."id" = '542803bf-73ee-496f-a7e7-077858925245' ORDER BY "articles"."name" ASC)  [["accountable_id", "acfe9618-69d4-4564-9ab5-65a50dc4b26a"], ["accountable_type", "ServiceType"]]
  ServiceType Exists (1.2ms)  SELECT  1 AS one FROM "service_types" WHERE "service_types"."name" = $1 AND ("service_types"."id" != $2) LIMIT $3  [["name", "Service-type 1"], ["id", "acfe9618-69d4-4564-9ab5-65a50dc4b26a"], ["LIMIT", 1]]
   (2.4ms)  COMMIT
Redirected to http://localhost:3000/service_types
Completed 302 Found in 31ms (ActiveRecord: 9.1ms)

2 个答案:

答案 0 :(得分：0)

很奇怪，在删除关系时没有调用它。无论如何，您的回调函数目前似乎没有任何作用。

也许您可以尝试更改以下内容：

const isControlValid = control.value.match(/^[\x41-\x5A\x61-\x7A\xAA\xB5\xBA\xC0-\xD6\xD8-\xF6\xF8-\u02C1\u02C6-\u02D1\u02E0-\u02E4\u02EC\u02EE\u0370-\u0374\u0376\u0377\u037A-\u037D\u0386\u0388-\u038A\u038C\u038E-\u03A1\u03A3-\u03F5\u03F7-\u0481\u048A-\u0527\u0531-\u0556\u0559\u0561-\u0587\u05D0-\u05EA\u05F0-\u05F2\u0620-\u064A\u066E\u066F\u0671-\u06D3\u06D5\u06E5\u06E6\u06EE\u06EF\u06FA-\u06FC\u06FF\u0710\u0712-\u072F\u074D-\u07A5\u07B1\u07CA-\u07EA\u07F4\u07F5\u07FA\u0800-\u0815\u081A\u0824\u0828\u0840-\u0858\u08A0\u08A2-\u08AC\u0904-\u0939\u093D\u0950\u0958-\u0961\u0971-\u0977\u0979-\u097F\u0985-\u098C\u098F\u0990\u0993-\u09A8\u09AA-\u09B0\u09B2\u09B6-\u09B9\u09BD\u09CE\u09DC\u09DD\u09DF-\u09E1\u09F0\u09F1\u0A05-\u0A0A\u0A0F\u0A10\u0A13-\u0A28\u0A2A-\u0A30\u0A32\u0A33\u0A35\u0A36\u0A38\u0A39\u0A59-\u0A5C\u0A5E\u0A72-\u0A74\u0A85-\u0A8D\u0A8F-\u0A91\u0A93-\u0AA8\u0AAA-\u0AB0\u0AB2\u0AB3\u0AB5-\u0AB9\u0ABD\u0AD0\u0AE0\u0AE1\u0B05-\u0B0C\u0B0F\u0B10\u0B13-\u0B28\u0B2A-\u0B30\u0B32\u0B33\u0B35-\u0B39\u0B3D\u0B5C\u0B5D\u0B5F-\u0B61\u0B71\u0B83\u0B85-\u0B8A\u0B8E-\u0B90\u0B92-\u0B95\u0B99\u0B9A\u0B9C\u0B9E\u0B9F\u0BA3\u0BA4\u0BA8-\u0BAA\u0BAE-\u0BB9\u0BD0\u0C05-\u0C0C\u0C0E-\u0C10\u0C12-\u0C28\u0C2A-\u0C33\u0C35-\u0C39\u0C3D\u0C58\u0C59\u0C60\u0C61\u0C85-\u0C8C\u0C8E-\u0C90\u0C92-\u0CA8\u0CAA-\u0CB3\u0CB5-\u0CB9\u0CBD\u0CDE\u0CE0\u0CE1\u0CF1\u0CF2\u0D05-\u0D0C\u0D0E-\u0D10\u0D12-\u0D3A\u0D3D\u0D4E\u0D60\u0D61\u0D7A-\u0D7F\u0D85-\u0D96\u0D9A-\u0DB1\u0DB3-\u0DBB\u0DBD\u0DC0-\u0DC6\u0E01-\u0E30\u0E32\u0E33\u0E40-\u0E46\u0E81\u0E82\u0E84\u0E87\u0E88\u0E8A\u0E8D\u0E94-\u0E97\u0E99-\u0E9F\u0EA1-\u0EA3\u0EA5\u0EA7\u0EAA\u0EAB\u0EAD-\u0EB0\u0EB2\u0EB3\u0EBD\u0EC0-\u0EC4\u0EC6\u0EDC-\u0EDF\u0F00\u0F40-\u0F47\u0F49-\u0F6C\u0F88-\u0F8C\u1000-\u102A\u103F\u1050-\u1055\u105A-\u105D\u1061\u1065\u1066\u106E-\u1070\u1075-\u1081\u108E\u10A0-\u10C5\u10C7\u10CD\u10D0-\u10FA\u10FC-\u1248\u124A-\u124D\u1250-\u1256\u1258\u125A-\u125D\u1260-\u1288\u128A-\u128D\u1290-\u12B0\u12B2-\u12B5\u12B8-\u12BE\u12C0\u12C2-\u12C5\u12C8-\u12D6\u12D8-\u1310\u1312-\u1315\u1318-\u135A\u1380-\u138F\u13A0-\u13F4\u1401-\u166C\u166F-\u167F\u1681-\u169A\u16A0-\u16EA\u1700-\u170C\u170E-\u1711\u1720-\u1731\u1740-\u1751\u1760-\u176C\u176E-\u1770\u1780-\u17B3\u17D7\u17DC\u1820-\u1877\u1880-\u18A8\u18AA\u18B0-\u18F5\u1900-\u191C\u1950-\u196D\u1970-\u1974\u1980-\u19AB\u19C1-\u19C7\u1A00-\u1A16\u1A20-\u1A54\u1AA7\u1B05-\u1B33\u1B45-\u1B4B\u1B83-\u1BA0\u1BAE\u1BAF\u1BBA-\u1BE5\u1C00-\u1C23\u1C4D-\u1C4F\u1C5A-\u1C7D\u1CE9-\u1CEC\u1CEE-\u1CF1\u1CF5\u1CF6\u1D00-\u1DBF\u1E00-\u1F15\u1F18-\u1F1D\u1F20-\u1F45\u1F48-\u1F4D\u1F50-\u1F57\u1F59\u1F5B\u1F5D\u1F5F-\u1F7D\u1F80-\u1FB4\u1FB6-\u1FBC\u1FBE\u1FC2-\u1FC4\u1FC6-\u1FCC\u1FD0-\u1FD3\u1FD6-\u1FDB\u1FE0-\u1FEC\u1FF2-\u1FF4\u1FF6-\u1FFC\u2071\u207F\u2090-\u209C\u2102\u2107\u210A-\u2113\u2115\u2119-\u211D\u2124\u2126\u2128\u212A-\u212D\u212F-\u2139\u213C-\u213F\u2145-\u2149\u214E\u2183\u2184\u2C00-\u2C2E\u2C30-\u2C5E\u2C60-\u2CE4\u2CEB-\u2CEE\u2CF2\u2CF3\u2D00-\u2D25\u2D27\u2D2D\u2D30-\u2D67\u2D6F\u2D80-\u2D96\u2DA0-\u2DA6\u2DA8-\u2DAE\u2DB0-\u2DB6\u2DB8-\u2DBE\u2DC0-\u2DC6\u2DC8-\u2DCE\u2DD0-\u2DD6\u2DD8-\u2DDE\u2E2F\u3005\u3006\u3031-\u3035\u303B\u303C\u3041-\u3096\u309D-\u309F\u30A1-\u30FA\u30FC-\u30FF\u3105-\u312D\u3131-\u318E\u31A0-\u31BA\u31F0-\u31FF\u3400-\u4DB5\u4E00-\u9FCC\uA000-\uA48C\uA4D0-\uA4FD\uA500-\uA60C\uA610-\uA61F\uA62A\uA62B\uA640-\uA66E\uA67F-\uA697\uA6A0-\uA6E5\uA717-\uA71F\uA722-\uA788\uA78B-\uA78E\uA790-\uA793\uA7A0-\uA7AA\uA7F8-\uA801\uA803-\uA805\uA807-\uA80A\uA80C-\uA822\uA840-\uA873\uA882-\uA8B3\uA8F2-\uA8F7\uA8FB\uA90A-\uA925\uA930-\uA946\uA960-\uA97C\uA984-\uA9B2\uA9CF\uAA00-\uAA28\uAA40-\uAA42\uAA44-\uAA4B\uAA60-\uAA76\uAA7A\uAA80-\uAAAF\uAAB1\uAAB5\uAAB6\uAAB9-\uAABD\uAAC0\uAAC2\uAADB-\uAADD\uAAE0-\uAAEA\uAAF2-\uAAF4\uAB01-\uAB06\uAB09-\uAB0E\uAB11-\uAB16\uAB20-\uAB26\uAB28-\uAB2E\uABC0-\uABE2\uAC00-\uD7A3\uD7B0-\uD7C6\uD7CB-\uD7FB\uF900-\uFA6D\uFA70-\uFAD9\uFB00-\uFB06\uFB13-\uFB17\uFB1D\uFB1F-\uFB28\uFB2A-\uFB36\uFB38-\uFB3C\uFB3E\uFB40\uFB41\uFB43\uFB44\uFB46-\uFBB1\uFBD3-\uFD3D\uFD50-\uFD8F\uFD92-\uFDC7\uFDF0-\uFDFB\uFE70-\uFE74\uFE76-\uFEFC\uFF21-\uFF3A\uFF41-\uFF5A\uFF66-\uFFBE\uFFC2-\uFFC7\uFFCA-\uFFCF\uFFD2-\uFFD7\uFFDA-\uFFDC,'-.\s]+$/g);
const hasErrorCombinations = control.value.match(/(([^\x00-\x7F]+|[\w]+)?[.|\-|'|.|\s]{2,}([^\x00-\x7F]+|[\w]+)?)+|([^\x00-\x7F]+|[\w]+)?[.|\-|\s]{1}$|^[.|\-|\s]{1}([^\x00-\x7F]+|[\w]+)?$/g);
const hasAdditionalSymbolsCheckErrors = control.value.match(/[()+*]+/g);

return isControlValid && !hasErrorCombinations && !hasAdditionalSymbolsCheckErrors;

到

def arrange_polymorphic_fields
    def arrange_polymorphic_fields
      !accountable_id.present? && self.accountable_type = nil
    end
  end

然后再次尝试删除关系。

（实际上，我知道您正在尝试使用def arrange_polymorphic_fields unless self.accountable_id.present? self.accountable_type = nil end end ，但我不是将条件语句与实际赋值混合使用的忠实拥护者。如果不太简洁，我宁愿编写简单的无效代码。.然后我们可以走得更远，因为这不是问题出处。.

答案 1 :(得分：0)

这不是我要寻找的答案，但是到目前为止，它可以解决我的问题。

由于this old post和this github issue，我认为这是一个更广泛的Rails问题。我确实尝试过dependent: :nullify），但对于我的Rails 5.1.6却没有用。

因此，我想出了创建ArticleConcern并将其包含在ServiceType和ServiceAddonType模型中的方法。根据需要工作：

# frozen_string_literal: true

require 'active_support/concern'

module ArticleConcern
  extend ActiveSupport::Concern

  included do
    after_save -> { arrange_polymorphic_fields }
  end

  def arrange_polymorphic_fields
    Article.where(accountable_id: nil).where.not(accountable_type: nil).each do |a|
      a.update(accountable_type: nil)
    end
  end
end
相关问题
最新问题