使用Math.abs(diff)排序时出现Java意外的IllegalArgumentException

时间:2018-11-06 12:37:43

标签: java sorting illegalargumentexception

排序双打列表时,我有一些我没想到的行为。我的目标是对双打列表进行排序,但是当两个双打彼此靠近时,我不在乎它们的顺序(实际上,我使用Entry <>并将Double作为值,当两个Double值很接近,我在其他方面进行了排序。

这里是一个将抛出IllegalArgumentException的示例:

public static void main(String[] args) {
    final float probabilitySortMargin = 0.2f;
    Comparator<Double> comp = new Comparator<Double>() {
        @Override
        public int compare(Double o1, Double o2) {
            // sort on probability first
            double diff = Math.abs(o1 - o2);
            if(diff > probabilitySortMargin)
                // difference is more than desired range, sort descending
                return Double.compare(o2 , o1);
            return 0;
        }
    };

    ArrayList<Double> vals = new ArrayList<>();
    Random r = new Random(0);
    for(int i=0;i<1000;i++)
        vals.add(r.nextDouble());

    for(int i=0;i<vals.size();i++)
        for(int j=0;j<vals.size();j++)
            if(comp.compare(vals.get(i), vals.get(j)) != -1 * comp.compare(vals.get(j), vals.get(i)))
                System.out.println("Comparison failed");

    Collections.sort(vals, comp);
}

结果

Exception in thread "main" java.lang.IllegalArgumentException: Comparison method violates its general contract!
    at java.util.TimSort.mergeHi(TimSort.java:899)
    at java.util.TimSort.mergeAt(TimSort.java:516)
    at java.util.TimSort.mergeCollapse(TimSort.java:441)
    at java.util.TimSort.sort(TimSort.java:245)
    at java.util.Arrays.sort(Arrays.java:1512)
    at java.util.ArrayList.sort(ArrayList.java:1462)
    at java.util.Collections.sort(Collections.java:175)
    at some.package.Sample.main(Sample.java:10)

为什么会这样?甚至很奇怪,错误消息“比较失败”也会被打印

1 个答案:

答案 0 :(得分:3)

您的compare方法确实违反了Comparator接口的约定。

  

实施者必须确保compare(x,y)== 0意味着所有z的sgn(compare(x,z))== sgn(compare(y,z))。

compare(0.1,0.2) == 0, but sgn(compare(0.1,0.35)) != sgn(compare (0.2,0.35))

因为您的方法未违反sgn(compare(x, y)) ==-sgn(compare(y, x))要求,所以从不打印“比较失败”。