一般建议...

Question

我正在观看以下视频来设计蛇游戏： https://www.youtube.com/watch?v=91a7ceECNTc

我正在逐步跟踪它，但是当我运行它时，蛇并没有显示在屏幕上，只有苹果。我认为实施public void paint(Graphics g);时遇到了问题，有人可以帮助我吗？

这是我的主班代码

import javax.swing.JFrame;
public class Main {

public static void main(String[] args) {
    JFrame frame = new JFrame ();
    GamePanel panel = new GamePanel();

    frame.add(panel);
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.setTitle("Snake");

    frame.pack();
    frame.setVisible(true);
    frame.setLocationRelativeTo(null);
}
}

这是面板类：

import java.awt.Color;
import java.awt.Dimension;
import java.awt.Graphics;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.util.ArrayList;
import java.util.Random;

import javax.swing.JPanel;

public class GamePanel extends JPanel implements Runnable, KeyListener{

private static final long serialVersionUID = 1L;
public static final int WIDTH = 1000, HEIGHT = 1000; //Dimensions of the panel (Will be set by user input later)
private Thread thread;
private boolean running;
private boolean right = true, left = false, up = false, down = false;

private BodyPart b;
private ArrayList<BodyPart> snake;
private Apple apple;
private ArrayList<Apple> apples;
private Random r;

private int xCoor = 100, yCoor = 100, size = 10;
private int ticks = 0;

public GamePanel() {
    setFocusable(true);
    setPreferredSize(new Dimension(WIDTH, HEIGHT));
    addKeyListener(this);
    snake = new ArrayList<BodyPart>();
    apples = new ArrayList<Apple>();
    r = new Random();
    start();

}
public void start() {
    running = true;
    thread = new Thread(this);
    thread.start();
}
public void stop() {
    running = false;
    try {
        thread.join();
    } catch (InterruptedException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }

}
public void tick() {
    if (snake.size() == 0) {
        b = new BodyPart(xCoor, yCoor, 10);
        snake.add(b);
    }
    ticks++;
    if (ticks > 250000) {
        if (right) {
            xCoor++;
        }
        if (left) {
            xCoor--;
        }
        if (up) {
            yCoor--;
        }
        if (down) {
            yCoor++;
        }
        ticks = 0;
        b = new BodyPart(xCoor, yCoor, 10);
        snake.add(b);
        if (snake.size() > size) {
            snake.remove(0);
        }
    }
    if (apples.size() == 0) {
        int xCoor = r.nextInt(99);
        int yCoor = r.nextInt(99);
        apple = new Apple(xCoor, yCoor, 10);
        apples.add(apple);
    }
}
public void paint(Graphics g) {

    g.clearRect(0, 0, WIDTH, HEIGHT);
    g.setColor(Color.BLACK);
    g.fillRect(0, 0, WIDTH, HEIGHT);

    for (int i = 0; i < WIDTH/10; i++) {
        g.drawLine(i*10, 0, i*10, HEIGHT);
    }
    for (int i = 0; i < HEIGHT/10; i++) {
        g.drawLine(0, i*10, HEIGHT, i*10);
    }
    for (int i = 0; i < snake.size(); i++) {
        snake.get(i).draw(g);
    }
    for (int i = 0; i < apples.size(); i++) {
        apples.get(i).draw(g);
    }
}

@Override
public void run() {
    while (running) {
        tick();
        repaint();
    }
}
@Override
public void keyTyped(KeyEvent e) {
    int key = e.getKeyCode();
    if (key == KeyEvent.VK_RIGHT && !left) {
        right = true;
        up = false;
        down = false;
    }
    if (key == KeyEvent.VK_LEFT && !right) {
        left = true;
        up = false;
        down = false;
    }
    if (key == KeyEvent.VK_UP && !down) {
        up = true;
        right = false;
        left = false;
    }
    if (key == KeyEvent.VK_DOWN && !up) {
        down = true;
        right = false;
        left = false;
    }

}
@Override
public void keyPressed(KeyEvent e) {
    // TODO Auto-generated method stub

}
@Override
public void keyReleased(KeyEvent e) {
    // TODO Auto-generated method stub

}
}

蛇的身体部位类别：

import java.awt.Color;
import java.awt.Graphics;

public class BodyPart {
public int xCoor, yCoor, width, height;

public BodyPart(int xCoor, int yCoor, int tileSize) {
    this.xCoor = xCoor;
    this.yCoor = yCoor;
    width = tileSize;
    height = tileSize;
}
public void tick() {

}
public void draw(Graphics g) {
    g.setColor(Color.YELLOW);
    g.fillRect(xCoor * width, yCoor * height, width, height);
}
public int getCoorX() {
    return xCoor;
}
public void setCoorX (int xCoor) {
    this.xCoor = xCoor;
}
public int getCoorY() {
    return yCoor;
}
public void setCoorY(int yCoor) {
    this.yCoor = yCoor;
}
}

还有苹果的班级：

import java.awt.Color;
import java.awt.Graphics;

public class Apple {
public int xCoor, yCoor, width, height;

public Apple(int xCoor, int yCoor, int tileSize) {
    this.xCoor = xCoor;
    this.yCoor = yCoor;
    width = tileSize;
    height = tileSize;
}
public void tick() {

}
public void draw(Graphics g) {
    g.setColor(Color.RED);
    g.fillRect(xCoor * width, yCoor * height, width, height);
}
public int getxCoor() {
    return xCoor;
}
public void setxCoor(int xCoor) {
    this.xCoor = xCoor;
}
public int getyCoor() {
    return yCoor;
}
public void setyCoor(int yCoor) {
    this.yCoor = yCoor;
}

}

Answer 1

好的，所以问题归结为一些基本的数学...

如果我们看看draw的{{1}}方法，您会发现...

BodyPart

好的，很基本，但是实际上也设置了所有这些值吗？

如果我们看看g.fillRect(xCoor * width, yCoor * height, width, height);方法（创建tick的方法），我们会发现...

BodyPart

好的，所以b = new BodyPart(xCoor, yCoor, 10); snake.add(b);和width是height，但是10和xCoor呢？

它们首先与类一起初始化为实例字段...

yCoor

因此，一小段数学告诉我们private int xCoor = 100, yCoor = 100, size = 10;的初始位置是BodyPart，它等于100 * 10。

如果我们还看看...

1000x1000

和

public static final int WIDTH = 1000, HEIGHT = 1000; //Dimensions of the panel (Will be set by user input later)

我们可以看到setPreferredSize(new Dimension(WIDTH, HEIGHT));实际上最初是在屏幕之外设置的。

因此，如果我们将初始位置更改为类似...

BodyPart

您会找到您失踪的蛇。

一般建议...

您应避免覆盖private int xCoor = 10, yCoor = 10, size = 10;。它在油漆链中很高，很容易拧紧。相反，请改用paint（并确保您正在呼叫paintComponent）。 super.paintComponent然后会为您清除JPanel上下文（具有组件的背景色）。

Swing不是线程安全的。您不应从事件调度线程的上下文外部修改UI或UI依赖的任何状态。

当前的“主”循环存在引入脏更新的危险，该更新可能会在以后引起问题。参见Concurrency in Swing。作为“一般”首选项，您应考虑改为使用Swing Timer。它不会阻止EDT，但会在EDT内部生成“滴答声”，从而更安全地从内部更新UI和/或其状态。

执行操作时应避免使用“幻数” ...

Graphics

在这里，for (int i = 0; i < WIDTH/10; i++) { g.drawLine(i*10, 0, i*10, HEIGHT); }和WIDTH可能不代表该组件的实际大小。而是使用HEIGHT和JPanel#getWidth。

作为一般建议，您应该避免使用JPanel#getHeight，其他人很容易将其更改为不需要的状态。相反，请改写setPreferred/Minimum/MaximumSize，这样便可以保持控制。

Java Snake游戏：苹果在蛇不可见的情况下展示

1 个答案:

一般建议...