Rspec:如何测试重试?

时间:2018-10-04 13:00:04

标签: ruby-on-rails ruby ruby-on-rails-3 rspec rspec-rails

我已为比赛条件实施了乐观锁。如果lock_version与数据库中更新的lock_version不匹配,则它将触发retry三次。您能否建议如何测试此retry事件

#Product: Model's new field:
    #  lock_version                       :integer(4)      default(0), not null

def recalculate
  method_1
  self.save!
end

private
def method_1
    begin
      ####
      ####
      if self.lock_version == Product.find(self.id).lock_version
         Product.where(:id => self.id).update_all(attributes)
      else
         raise ActiveRecord::StaleObjectError.new(self, "test")
      end
    rescue ActiveRecord::StaleObjectError => e
        if tries < 3
           tries += 1
           sleep(1 + tries)
           self.reload
           retry
        else
           raise Exception.new(timeout.inspect)
        end
    end
end

Rspec单元测试:

  it 'if car is updated then ActiveRecord::StaleObjectError should be raised' do
    prod_v1 =Product.find(@prod.id)
    prod_v2 = Product.find(@prod.id)
    prod_v1.recalculate
    prod_v1.reload  # will make lock_version of prod_v1 to 1
    prod_v2.recalculate # howvever lock_version of prod_v2 is still 0.
    expect{car_v2.send(:method1)}.to receive(:retry)
  end

1 个答案:

答案 0 :(得分:0)

我首先将您的method1的复杂性分解为类似的东西。

private
def stale_object?
  self.lock_version == Product.find(self.id).lock_version
end

def attempt_to_rescue_stale_object
  if rescue_stale_object_retries =< 3
    rescue_stale_object_retries += 1
    sleep( 1 + rescue_stale_object_retries)
    retry # and the sleep stuff, not sure how you
  else
    raise Exception.new(timeout.inspect)
  end
end

def rescue_stale_object_retries
  @rescue_stale_object_retries ||= 0
end

def method_1
  begin
    raise ActiveRecord::StaleObjectError.new(self, "test") if stale_object?
    Product.where(:id => self.id).update_all(attributes)
  rescue ActiveRecord::StaleObjectError => e
    attempt_to_rescue_stale_object
    reload # You can omit the self here
   else
      raise Exception.new(timeout.inspect)
    end
  end 
end

现在,您可以按自己喜欢的方式对其进行测试,而抢救逻辑的复杂性被包装到一种方法中。您不必依赖于测试其中的实际行为(现在是睡眠调用,但它可能会变成运行后台作业)。

[https://relishapp.com/rspec/rspec-mocks/docs/setting-constraints/receive-counts][1]给了我们这样的东西

expect{car_v2}.to receive(:attempt_to_rescue_stale_object).exactly(3).times
car_v2.method1

将复杂性分解为小部分的另一个好处是,您的意图可以更好地传达给其他开发人员(另一个人或您在六个月后就忘记了最初的测试目标)