Redux无法处理来自2个输入的数据

时间:2018-09-21 17:16:40

标签: reactjs redux react-redux

我试图用一个功能控制组件的状态数据。我也使用redux。但是redux出了点问题,或者我看不到我的错误。这是我的组件:

      this.state = {
         data: this.props.ui.users,
         name: '',
         email: ''
      }
    }


    handleChange = (evt) => {
      this.setState({ [evt.target.name]: evt.target.value });
    }


    componentWillReceiveProps = () => {
      this.setState({
        name: ''
      })
    }


    render() {
      return (
        <div>
          <form onSubmit={(e) => this.props.uiActions.addUser(e, this.state.name, this.state.email)}>
            <input type="text"
                   name="name"
                   value={this.state.name}
                   onChange={this.handleChange}/>
          </form>
      </div>
      )
    }
}

一切正常。但是,当我想添加另一个处理电子邮件输入的输入时,操作不会触发。我可以毫无问题地通过this.state.email传递数据,例如“ something”,但是redux看不到其他输入。一键输入,一切都很好。 区别在于,在我输入的第一个输入下方

           <input type="text"
               name="email"
               value={this.state.email}
               onChange={this.handleChange}/>

和redux不会触发操作。继承人处理传递数据的操作:

export function addUser(e, name, email) {
  return (dispatch, getState) => {
    e.preventDefault()
    console.log(email)
    const { users } = getState().ui
    dispatch({ type: UI_ACTIONS.ADD_USER, users:[...users, {id: users.length+1, name: name, email: email}] });
  }
}

减速器:

export default (state = initialState, action) => {
  switch (action.type) {
  case UI_ACTIONS.SET_REPOS: 
    return { ...state, users: action.users };
  case UI_ACTIONS.ADD_USER:
    return {...state, users: action.users};
  default:
    return state;
  }
};

我在做什么错?在这里您可以找到我的仓库:https://github.com/KamilStaszewski/crudapp/tree/develop/src

2 个答案:

答案 0 :(得分:2)

这里有很多事情确实需要修改。构建应用程序的方式是反模式的(非标准/不好的做法),并且随着应用程序变得更加动态,将使您更加头疼。

要考虑的几件事:

  • 除非使用大量嵌套的组件,否则不需要Redux(在此示例中,React状态就足够了)
  • 您应该将容器(Redux连接的函数/ AJAX请求)与组件(任何关心外观的函数)分开:https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0
  • form动作保留在表单的组件中(例如e.preventDefault();),并从reducer内部利用Redux状态(您可以访问化简器中的Redux状态,因此对于{{ 1}}操作,则无需调用Redux的addUser)。
  • 如果您只返回getState();dispatch,则不需要actiontype
  • 始终payload兑现您的诺言。由于某种原因,有一种趋势是,有前途的开发人员认为每一个诺言都会解决并且永远不会出错。不赶上错误会破坏您的应用程序!

我已经着手重组了整个应用程序。我鼓励您解构它并遵循应用程序流程,然后进行项目并进行相应的修复。

工作示例:https://codesandbox.io/s/zn4ryqp5y4

actions / index.js

.catch()

components / App.js

import { UI_ACTIONS } from "../types";

export const fetchUsers = () => dispatch => {
  fetch(`https://jsonplaceholder.typicode.com/users`)
    .then(resp => resp.json())
    .then(data => dispatch({ type: UI_ACTIONS.SET_REPOS, payload: data }))
    .catch(err => console.error(err.toString()));
};

/* 
  export const handleNameChange = value => ({
    type: UI_ACTIONS.UPDATE_NAME, 
    val: value
  })
*/

/*
  export const handleEmailChange = value => ({
    type: UI_ACTIONS.UPDATE_EMAIL, 
    val: value
  }) 
*/

export const addUser = (name, email) => ({
  type: UI_ACTIONS.ADD_USER,
  payload: { name: name, email: email }
});

components / displayUserList.js

import React from "react";
import UserListForm from "../containers/UserListForm";

export default ({ children }) => <div className="wrapper">{children}</div>;

containers / UserListForm.js

import map from "lodash/map";
import React from "react";

export default ({ users }) => (
  <table>
    <thead>
      <tr>
        <th>ID</th>
        <th>USER</th>
        <th>E-MAIL</th>
      </tr>
    </thead>
    <tbody>
      {map(users, ({ id, name, email }) => (
        <tr key={email}>
          <td>{id}</td>
          <td>{name}</td>
          <td>{email}</td>
        </tr>
      ))}
    </tbody>
    <tfoot />
  </table>
);

reducers / index.js

import map from "lodash/map";
import React, { Component } from "react";
import { connect } from "react-redux";
import { addUser, fetchUsers } from "../actions/uiActions";
import DisplayUserList from "../components/displayUserList";

class Userlist extends Component {
  state = {
    name: "",
    email: ""
  };

  componentDidMount = () => {
    this.props.fetchUsers();
  };

  handleChange = evt => {
    this.setState({ [evt.target.name]: evt.target.value });
  };

  handleSubmit = e => {
    e.preventDefault();
    const { email, name } = this.state;

    if (!email || !name) return;

    this.props.addUser(name, email);
    this.setState({ email: "", name: "" });
  };

  render = () => (
    <div style={{ padding: 20 }}>
      <h1 style={{ textAlign: "center" }}>Utilizing Redux For Lists</h1>
      <form style={{ marginBottom: 20 }} onSubmit={this.handleSubmit}>
        <input
          className="uk-input"
          style={{ width: 300, marginBottom: 10 }}
          type="text"
          name="name"
          placeholder="Add user's name..."
          value={this.state.name}
          onChange={this.handleChange}
        />
        <br />
        <input
          className="uk-input"
          style={{ width: 300, marginBottom: 10 }}
          type="text"
          name="email"
          placeholder="Add user's email..."
          value={this.state.email}
          onChange={this.handleChange}
        />
        <br />
        <button className="uk-button uk-button-primary" type="submit">
          Submit
        </button>
      </form>
      <DisplayUserList users={this.props.users} />
    </div>
  );
}

export default connect(
  state => ({ users: state.ui.users }),
  { addUser, fetchUsers }
)(Userlist);

root / index.js

import { routerReducer as routing } from "react-router-redux";
import { combineReducers } from "redux";
import { UI_ACTIONS } from "../types";

const initialState = {
  users: [],
  name: "",
  email: ""
};

const uiReducer = (state = initialState, { payload, type }) => {
  switch (type) {
    case UI_ACTIONS.SET_REPOS:
      return { ...state, users: payload };
    case UI_ACTIONS.ADD_USER:
      return {
        ...state,
        users: [...state.users, { id: state.users.length + 1, ...payload }]
      };
    default:
      return state;
  }
};

const rootReducer = combineReducers({
  ui: uiReducer,
  routing
});

export default rootReducer;

routes / index.js

import React from "react";
import { browserHistory, Router } from "react-router";
import { createStore, applyMiddleware } from "redux";
import { Provider } from "react-redux";
import { syncHistoryWithStore } from "react-router-redux";
import thunk from "redux-thunk";
import rootReducer from "../reducers";
import routes from "../routes";

// CONFIG REDUX STORE WITH REDUCERS, MIDDLEWARES, AND BROWSERHISTORY
const store = createStore(rootReducer, applyMiddleware(thunk));
const history = syncHistoryWithStore(browserHistory, store);

// APP CONFIG'D WITH REDUX STORE, BROWSERHISTORY AND ROUTES
export default () => (
  <Provider store={store}>
    <Router
      onUpdate={() => window.scrollTo(0, 0)}
      history={history}
      routes={routes}
    />
  </Provider>
);

types / index.js

import React from "react";
import { IndexRoute, Route } from "react-router";

import App from "../components/App";
import UserListForm from "../containers/UserListForm";

export default (
  <Route path="/" component={App}>
    <IndexRoute component={UserListForm} />
  </Route>
);

index.js

export const UI_ACTIONS = {
  UPDATE_NAME: "UPDATE_NAME",
  INCREMENT_COUNT: "INCREMENT_COUNT",
  SET_REPOS: "SET_REPOS",
  ADD_USER: "ADD_USER",
  UPDATE_NAME: "UPDATE_NAME",
  UPDATE_EMAIL: "UPDATE_EMAIL"
};

export const TEST_ACTION = {
  ACTION_1: "ACTION_1"
};

答案 1 :(得分:0)

我发现对我来说似乎不对的一件事是:输入元素未绑定到this

<input type="text" name="name" value={this.state.name} 
  onChange={this.handleChange.bind(this)}
/>

您是否还跟踪了控制台中的事件处理程序在做什么?

相关问题