更新:感谢peterSO,该错误似乎是随机字节,读取为字符串将包含“ \ n”,这会导致换行和错误。 问题都不是
io.Copy(conn, bytes.NewReader(encrypted))
也
conn.Write([]byte(encrypted))
工作。 任何人都知道如何将Chipertext写入conn吗?
原始帖子: 聊天程序由一台服务器和两个客户端组成。它使用TLS和NaCl进行(端到端)加密。在3/4的情况下,它可以工作,但有时会出现错误:
panic: runtime error: slice bounds out of range
goroutine 34 [running]:
main.handleConnection(0x600a60, 0xc04246c000)
path-to/client.go:79
+0x3a6
created by main.main
path-to/client.go:44
+0x436
exit status 2
第44行通话
go handleConnection(conn)
第79行是“解密”行:
func handleConnection(conn net.Conn) {
defer conn.Close()
input := bufio.NewScanner(conn)
for input.Scan() {
senderPublicKey := readKey("localPublic")
recipientPrivateKey := readKey("remotePrivate")
var decryptNonce [24]byte
encrypted := input.Bytes()
copy(decryptNonce[:], encrypted[:24])
decrypted, ok := box.Open(nil, encrypted[24:], &decryptNonce, senderPublicKey, recipientPrivateKey)
if !ok {
fmt.Println("decryption error")
}
fmt.Println(BytesToString(decrypted))
}
}
完整代码更进一步。由于无需加密即可完美运行,并且仅加密的测试实现也可以正常工作,因此我将指出客户端-服务器-客户端之间的传输。通常,切片的长度不应更改,因为输出应保持不变?
客户端读取:
package main
import (
"bufio"
crypto_rand "crypto/rand"
"crypto/tls"
"crypto/x509"
"fmt"
"io"
"io/ioutil"
"log"
"net"
"os"
"golang.org/x/crypto/nacl/box"
)
func main() {
cert, err := tls.LoadX509KeyPair("cert.pem", "key.pem")
if err != nil {
log.Fatalln("Unable to load cert", err)
}
clientCACert, err := ioutil.ReadFile("cert.pem")
if err != nil {
log.Fatal("Unable to open cert", err)
}
clientCertPool := x509.NewCertPool()
clientCertPool.AppendCertsFromPEM(clientCACert)
conf := &tls.Config{
Certificates: []tls.Certificate{cert},
RootCAs: clientCertPool,
//InsecureSkipVerify: true,
}
conn, err := tls.Dial("tcp", "localhost:443", conf)
if err != nil {
log.Fatal(err)
}
defer conn.Close()
go handleConnection(conn)
for {
stdin := bufio.NewReader(os.Stdin)
textIn, err := stdin.ReadBytes('\n')
if err != nil {
fmt.Println(err)
}
var nonce [24]byte
if _, err := io.ReadFull(crypto_rand.Reader, nonce[:]); err != nil {
panic(err)
}
senderPrivateKey := readKey("localPrivate")
recipientPublicKey := readKey("remotePublic")
encrypted := box.Seal(nonce[:], textIn, &nonce, recipientPublicKey, senderPrivateKey)
text := BytesToString(encrypted)
fmt.Fprintf(conn, text+"\n")
}
}
func handleConnection(conn net.Conn) {
defer conn.Close()
input := bufio.NewScanner(conn)
for input.Scan() {
senderPublicKey := readKey("localPublic")
recipientPrivateKey := readKey("remotePrivate")
var decryptNonce [24]byte
encrypted := input.Bytes()
copy(decryptNonce[:], encrypted[:24])
decrypted, ok := box.Open(nil, encrypted[24:], &decryptNonce, senderPublicKey, recipientPrivateKey)
if !ok {
fmt.Println("decryption error")
}
fmt.Println(BytesToString(decrypted))
}
}
//BytesToString converts []byte to str
func BytesToString(data []byte) string {
return string(data[:])
}
//Read the keys from file, pass filename without .ending
func readKey(name string) (prv *[32]byte) {
prv = new([32]byte)
f, err := os.Open(name + ".key")
if err != nil {
panic(err)
}
_, err = io.ReadFull(f, prv[:])
if err != nil {
panic(err)
}
return
}
服务器端:
package main
import (
"bufio"
"crypto/tls"
"fmt"
"log"
"net"
)
type client chan<- string // an outgoing message channel
var (
entering = make(chan client)
leaving = make(chan client)
messages = make(chan string) // all incoming client messages
)
// Broadcast incoming message to all clients' outgoing message channels.
func broadcaster() {
clients := make(map[client]bool) // all connected clients
for {
select {
case msg := <-messages:
for cli := range clients {
cli <- msg
}
case cli := <-entering:
clients[cli] = true
case cli := <-leaving:
delete(clients, cli)
close(cli)
}
}
}
func handleConn(conn net.Conn) {
ch := make(chan string) // outgoing client messages
go clientWriter(conn, ch)
//who := conn.RemoteAddr().String()
entering <- ch
//messages <- who + " has arrived"
input := bufio.NewScanner(conn)
for input.Scan() {
messages <- input.Text()
}
//messages <- who + " has left"
leaving <- ch
conn.Close()
}
func clientWriter(conn net.Conn, ch <-chan string) {
for msg := range ch {
fmt.Fprintln(conn, msg)
}
}
func main() {
cer, err := tls.LoadX509KeyPair("cert.pem", "key.pem")
if err != nil {
log.Println(err)
return
}
config := &tls.Config{
Certificates: []tls.Certificate{cer},
//PFS, this will reject client with RSA certificates
CipherSuites: []uint16{tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384},
//Force it server side
PreferServerCipherSuites: true,
//Force TLS Version
MinVersion: tls.VersionTLS12}
listener, err := tls.Listen("tcp", "localhost:443", config)
if err != nil {
log.Fatal(err)
}
go broadcaster()
for {
conn, err := listener.Accept()
if err != nil {
log.Print(err)
continue
}
go handleConn(conn)
}
}
答案 0 :(得分:1)
没有明显的原因,您希望len(input.Bytes()) >= 24
。如果不是这样:panic: runtime error: slice bounds out of range
。
例如,
package main
func main() {
/*
var decryptNonce [24]byte
encrypted := input.Bytes()
copy(decryptNonce[:], encrypted[:24])
decrypted, ok := box.Open(nil, encrypted[24:], &decryptNonce, senderPublicKey, recipientPrivateKey)
if !ok {
fmt.Println("decryption error")
}
*/
var decryptNonce [24]byte
encrypted := make([]byte, 23, 24) // len(input.Bytes()) < 24
copy(decryptNonce[:], encrypted[:24])
// panic: runtime error: slice bounds out of range
_ = encrypted[24:]
}
游乐场:https://play.golang.org/p/LZ34NgLV84G
输出:
panic: runtime error: slice bounds out of range
goroutine 1 [running]:
main.main()
/tmp/sandbox792172306/main.go:18 +0xa0
Halux9000的评论:
这很可能是原因。但是
生成len(input.Bytes()) >= 24
应该 通过input.Bytes()
时为truevar nonce [24]byte if _, err := io.ReadFull(crypto_rand.Reader, nonce[:]); err != nil { panic(err) } senderPrivateKey := readKey("localPrivate") recipientPublicKey := readKey("remotePublic") encrypted := box.Seal(nonce[:], textIn, &nonce, recipientPublicKey, senderPrivateKey) text := BytesToString(encrypted) fmt.Fprintf(conn, text+"\n")
无需传输即可进行加密。那么它在哪里缩短/ 改变了吗?
我对你的“应该”论点不服气。我相信程序。
如果您有随机或加密字节,那么其中一些将是换行符。我计算出前24个字节(随机数)中带有换行符的行的预期百分比为8.966%,并通过实验确认了这一点。
package main
import (
"bytes"
"crypto/rand"
"fmt"
"io"
)
var nonce [24]byte
func expected() float64 {
e := 0.0
for range nonce {
e += (float64(len(nonce)) - e) / 256
}
return e * 100 / float64(len(nonce))
}
func actual() float64 {
a, n := 0, 1024*1024
for i := 0; i < n; i++ {
if _, err := io.ReadFull(rand.Reader, nonce[:]); err != nil {
panic(err)
}
if bytes.IndexByte(nonce[:], '\n') >= 0 {
a++
}
}
return float64(a*100) / float64(n)
}
func main() {
fmt.Printf("expected: %.3f%%\n", expected())
fmt.Printf("actual: %.3f%%\n", actual())
}
游乐场:https://play.golang.org/p/cKJlGUSbi3u
输出:
$ go run newlines.go
expected: 8.966%
actual: 8.943%
$ go run newlines.go
expected: 8.966%
actual: 8.956%
$ go run newlines.go
expected: 8.966%
actual: 8.976%
$ go run newlines.go
expected: 8.966%
actual: 8.992%
$
Halux9000的评论:
您是否建议另一种将密文字节发送到conn的方法?
您需要一个对消息内容不敏感的更健壮的消息协议。例如,在邮件内容前面加上邮件内容长度。
一个简单的例子,
package main
import (
"bytes"
"encoding/binary"
"fmt"
"io"
)
func main() {
// Connection
var conn = new(bytes.Buffer)
{
// Server
buf := make([]byte, 0, 2+64*1024)
msgLen := uint16(16)
buf = buf[0 : 2+msgLen]
binary.BigEndian.PutUint16(buf[0:2], msgLen)
for i := uint16(0); i < msgLen; i++ {
buf[2+i] = byte(i)
}
fmt.Println(msgLen, len(buf), buf)
n, err := conn.Write(buf)
if err != nil {
fmt.Println(n, err)
return
}
}
{
// Client
buf := make([]byte, 0, 2+64*1024)
n, err := io.ReadFull(conn, buf[:2])
if err != nil {
fmt.Println(n, err)
return
}
msgLen := binary.BigEndian.Uint16(buf[0:2])
buf = buf[0 : 2+msgLen]
n, err = io.ReadFull(conn, buf[2:2+msgLen])
if err != nil {
fmt.Println(err)
return
}
fmt.Println(msgLen, len(buf), buf)
}
}
游乐场:https://play.golang.org/p/nS3xpFrG4uB
输出:
16 18 [0 16 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15]
16 18 [0 16 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15]