Question

我正在尝试从jar运行rsync。如果源路径中没有空格，则一切正常，但是当源路径中具有空格时，它将失败。我已经尝试了各种方法来转义空格，如手册页所述，例如source.replaceAll（“ \ s”，“ \\”）或source.replaceAll（“ \ s”，“？”），但没有有用。

当我输出正在运行的命令，然后从命令行运行完全相同的命令时，所有命令都可以正常工作。我看不到我在做什么错

我的代码如下：

RsyncCommandLine类

public class RsyncCommandLine {

    /** Logger */
    private static final Logger logger = LogManager.getLogger(RsyncCommandLine.class);

    private CommandLine commandLine = null;

    public String startRsync(String source, String destination) throws IOException {
        commandLine = createCommandLine(source, destination);

        CommandLineExecutorHelper helper = new CommandLineExecutorHelper();
        CommandLineLogOutputStream outputStream = helper.executeCommandLine(commandLine);
        validateResponse(outputStream);
        return convertLinesToString(outputStream.getLines());
    }

    private void validateResponse(CommandLineLogOutputStream outputStream) throws IOException {
        if (outputStream == null) {
            logger.error("outputStream  is not valid");
            throw new IOException("Unable to use rsync. ");
        } else if (outputStream.getExitCode() != 0) {
            logger.error("Exit code: " + outputStream.getExitCode());
            logger.error("Validate Response failed " + outputStream.getLines());
            String errorMessage = exitCodeToErrorMessage(outputStream.getExitCode());
            throw new IOException("Error with request. " + errorMessage);
        } else if (outputStream.getLines() == null || outputStream.getLines().isEmpty()) {
            logger.error("Rsync result: " + outputStream.getLines());
            String errorMessage = "Unable to rsync. ";

            throw new IOException(errorMessage);

        }
    }

    private String exitCodeToErrorMessage(int exitCode) {
        String errorMessage = null;
        switch (exitCode) {
            case 0: errorMessage="Success."; break;
            case 1: errorMessage="Syntax or usage error."; break;
            case 2: errorMessage="Protocol incompatibility."; break;
            case 3: errorMessage="Errors selecting input/output files, dirs."; break;
            case 4: errorMessage="Requested action not supported: an attempt was made to manipulate 64-bit files on a platform that cannot support them; or an option was specified that is supported by the client and not by the server."; break;
            case 5: errorMessage="Error starting client-server protocol."; break;
            case 6: errorMessage="Daemon unable to append to log-file."; break;
            case 10: errorMessage="Error in socket I/O."; break;
            case 11: errorMessage="Error in file I/O."; break;
            case 12: errorMessage="Error in rsync protocol data stream."; break;
            case 13: errorMessage="Errors with program diagnostics."; break;
            case 14: errorMessage="Error in IPC code."; break;
            case 20: errorMessage="Received SIGUSR1 or SIGINT."; break;
            case 21: errorMessage="Some error returned by waitpid()."; break;
            case 22: errorMessage="Error allocating core memory buffers."; break;
            case 23: errorMessage="Partial transfer due to error."; break;
            case 24: errorMessage="Partial transfer due to vanished source files."; break;
            case 25: errorMessage="The --max-delete limit stopped deletions."; break;
            case 30: errorMessage="Timeout in data send/receive."; break;
            case 35: errorMessage="Timeout waiting for daemon connection."; break;
            default: errorMessage="Unrecognised error code.";
        }
        return errorMessage;
    }


    protected String convertLinesToString(List<String> lines) {
        String result = null;

        if (lines != null && !lines.isEmpty()) {
            StringBuilder builder = new StringBuilder();
            for (String line : lines) {
                builder.append(line).append(" ");
            }
            result = builder.toString().trim();
        }
        return result;
    }

    protected CommandLine createCommandLine(String source, String destination) {
        // rsync -rtvuch <source> <destination>

        commandLine = new CommandLine("rsync");
        commandLine.addArgument("-rtvuch");

        String escapedSource = source.trim().replaceAll("\\s", "\\\\ ");
        String escapedDestination = destination.trim().replaceAll("\\s", "\\\\ ");
        commandLine.addArgument(source);
        commandLine.addArgument(escapedDestination);

        logger.debug("escapedSource " + escapedSource);
        logger.debug("escapedDestination " + escapedDestination);

        return commandLine;
    }

}

CommandLineExecutorHelper类-

public class CommandLineExecutorHelper {

    /** Logger */
    private static final Logger logger = LogManager.getLogger(CommandLineExecutorHelper.class);

    private DefaultExecutor executor = new DefaultExecutor();

    private ExecuteWatchdog watchdog = new ExecuteWatchdog(10000);

    private DefaultExecuteResultHandler resultHandler = new DefaultExecuteResultHandler();


    public CommandLineExecutorHelper() {
        executor.setWatchdog(watchdog);
    }

    public CommandLineLogOutputStream executeCommandLine(CommandLine commandLine) {
        CommandLineLogOutputStream outputStream = new CommandLineLogOutputStream();
        PumpStreamHandler pumpStreamHandler = new PumpStreamHandler(outputStream);
        executor.setStreamHandler(pumpStreamHandler);
        try {
            executor.execute(commandLine, resultHandler);

            resultHandler.waitFor();
            outputStream.setExitCode(resultHandler.getExitValue());
            logger.debug("\n\ncommandLine " + commandLine);
            logger.debug("exit code " + resultHandler.getExitValue());
            logger.debug("output " + outputStream.getLines());
        } catch (InterruptedException e) {
            outputStream.addErrorMessage(e.getMessage());
            logger.error("executeCommandLine " + e.getMessage());
        } catch (ExecuteException e) {
            outputStream.addErrorMessage(e.getMessage());
            logger.error("executeCommandLine " + e.getMessage());
        } catch (IOException e) {
            outputStream.addErrorMessage(e.getMessage());
            logger.error("executeCommandLine " + e.getMessage());
        } finally {
            IOUtils.closeQuietly(outputStream);
        }

        return outputStream;
    }
}

CommnadLineOutputStream类-

public class CommandLineLogOutputStream extends LogOutputStream {
    private int exitCode = -1;

    private final List<String> lines = new LinkedList<>();

    private StringBuilder errorMessages = new StringBuilder();


    /**
     * @return the exitCode
     */
    public int getExitCode() {
        return exitCode;
    }

    /**
     * @param exitCode the exitCode to set
     */
    public void setExitCode(int exitCode) {
        this.exitCode = exitCode;
    }

    /**
     * @return the lines
     */
    public List<String> getLines() {
        return lines;
    }



    /**
     * @return the errorMessages
     */
    public StringBuilder getErrorMessages() {
        return errorMessages;
    }

    /**
     * @param errorMessages the errorMessages to set
     */
    public void setErrorMessages(StringBuilder errorMessages) {
        this.errorMessages = errorMessages;
    }

    public void addErrorMessage(String errorMessage) {
        this.errorMessages.append(errorMessage);
    }


    @Override
    protected void processLine(String line, int logLevel) {
        lines.add(line);
    }

    /* (non-Javadoc)
     * @see java.lang.Object#toString()
     */
    @Override
    public String toString() {
        StringBuilder builder = new StringBuilder();
        builder.append("CommandLineLogOutputStream [exitCode=").append(exitCode).append(", lines=").append(lines).append(", errorMessages=").append(errorMessages).append("]");
        return builder.toString();
    }

}

因此，当我在没有空格的情况下运行jar时，它会成功：

java -jar myjar.jar -source "/var/source"

输出命令是：

commandLine [rsync, -rtvuch, "/var/source", /var/dest]

当我对带有空格的路径运行同一jar时：

java -jar myjar.jar -source "/var/source with spaces"

我收到以下错误消息：

Exit code: 23
Validate Response failed [building file list ... donersync: link_stat "/Users/karen/"/var/source with spaces"" failed: No such file or directory (2), building file list ... donersync: link_stat "/Users/karen/"/var/source with spaces"" failed: No such file or directory (2), , sent 21 bytes  received 20 bytes  82.00 bytes/sec, total size is 0  speedup is 0.00, rsync error: some files could not be transferred (code 23) at /BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-47/rsync/main.c(992) [sender=2.6.9]]
Unable to rsync Error with request. Partial transfer due to error.

从文件打开对话框中提取目标路径。

Answer 1

经过各种输入后，我决定改用ProcessBuilder。然后，我使用以下代码将其工作：

CREATE DATABASE mydatabase_copy AS COPY OF mydatabase;

Answer 2

您看到答案here了吗？

虽然有bug around quotes managements in Common Exec，此answers suggests：
// When writing a command with space use double "
cmdLine.addArgument(--grep=\"\"" + filter+"\"\"", false"\"\"",false);

Answer 3

我认为Apache Commons Exec在这里有一个错误，不能正确处理带有空格的参数。这个公开的错误（与m4gic链接）有几个矛盾的解释和解决方法：https://issues.apache.org/jira/browse/EXEC-54

我建议重写您的代码以使用Java内置的“ Runtime.exec”功能以及命令行的String[]形式（或等效的java.lang.ProcessBuilder API）来绕过任何外壳转义和引用的问题。

您将不得不手动处理Apache Commons Exec对您隐藏的一些技术细节，例如stdout和stderr之间潜在的I / O死锁，但是很有可能处理这些问题，而我认为这是不可能的。可以让Apache在这里做您想做的事情。 Apache Commons Exec intr o讨论了其中一些问题。您应该可以在互联网上使用Runtime.exec或ProcessBuilder找到一些示例代码。 GL！

Java Rsync转义空间

3 个答案: