GoConvey自定义断言无法按预期工作

时间:2018-04-25 11:16:45

标签: go tdd goconvey

不确定为什么以下自定义断言不起作用,似乎是编译错误,但我使用的语法似乎符合其维基页面中解释的内容:https://github.com/smartystreets/goconvey/wiki/Custom-Assertions

我基本上想要断言在结构中提交的time.Time表示过去24小时内的日期。

// func shouldBeInTheLast24Hours(targetDate time.Time, foo time.Time) string {
func shouldBeInTheLast24Hours(targetDate time.Time) string {
    if targetDate.Before(time.Now().Add(time.Duration(-24) * time.Hour)) {
        return ""
    } else {
        return "The target date is assumed to be in the last 24 hours, go *THERE* and fix stuff"
    }
}

type DateStuff struct {
    VipDate time.Time
}

func TestDateStuff(t *testing.T) {
    Convey("Given date stuff", t, func() {
        Convey("should verify some custom assertions are working", func() {
            myDateStruct := &DateStuff{VipDate: time.Now()}

            // So(myDateStruct.VipDate, shouldBeInTheLast24Hours, nil) // this throws "cannot use shouldBeInTheLast24Hours (type func(time.Time, time.Time) string) as type convey.assertion in argument to convey.So"
            So(myDateStruct.VipDate, shouldBeInTheLast24Hours) // this throws "cannot use shouldBeInTheLast24Hours (type func(time.Time) string) as type convey.assertion in argument to convey.So"
        })
    })
}

检查我正在使用的Go Convey版本时,我看到了:

$ cd $GOPATH/src/github.com/smartystreets/goconvey/ && git log -n 1 | grep Date
Date:   Fri Aug 25 16:14:26 2017 -0600

这是在维基页面上的日期之后(2013年11月15日)所以不应该在我的$GOPATH更新Go Convey库。

我对这种闭包语法并不是很熟悉,但在我看来我并没有误用它,但是我看到编译错误所以我必须错过一些陷阱。

1 个答案:

答案 0 :(得分:1)

这是我编写自定义断言的方式:

func shouldBeInTheLast24Hours(actual interface{}, _ ...interface{}) string {
    providedDate := actual.(time.Time)
    theshold := time.Now().Add(time.Hour * -24)
    if providedDate.After(theshold) {
        return ""
    } else {
        return "The target date is assumed to be in the last 24 hours, go *THERE* and fix stuff"
    }
}

func TestDateStuff(t *testing.T) {
    Convey("Given date stuff", t, func() {
        Convey("should verify some custom assertions are working", func() {
            vipDate := time.Now()
            So(vipDate, shouldBeInTheLast24Hours)
        })
    })
}

自定义断言的函数签名必须匹配assertion函数类型:

// assertion is an alias for a function with a signature that the convey.So()
// method can handle. Any future or custom assertions should conform to this
// method signature. The return value should be an empty string if the assertion
// passes and a well-formed failure message if not.
type assertion func(actual interface{}, expected ...interface{}) string

但是,正如评论中所述,已经定义了一个断言可以满足您的需求:

So(vipDate, ShouldHappenWithin, time.Hour*24, time.Now())