为什么我得到错误"错误C2259:...无法实例化抽象类"?

时间:2011-02-14 06:38:06

标签: c++ design-patterns factory-pattern

任何帮助都是适当的。我正在研究C ++工厂模式,我得到了这个错误。

1> c:\ users \ brian \ documents \ visual studio 2010 \ projects \ cst276lab_3 \ guitar.hpp(456):错误C2259:'ElectricGuitarComponentFactory':无法实例化抽象类

这是我的代码:

///////////////////////guitar class////////////////////

class Guitar

{

      private: std::string _name;

      protected: mutable std::auto_ptr< HeadStock > _HeadStock;
      protected: mutable std::auto_ptr< NeckStrap > _NeckStrap;
      protected: mutable std::vector< Bridge* > _Bridge;
      protected: mutable std::auto_ptr< Strings > _Strings;
      protected: mutable std::auto_ptr< Switches > _Switches;
      protected: mutable std::auto_ptr< GuitarBody > _GuitarBody;

      public: virtual void prepare() const = 0;

      private: Guitar( const Guitar& ); // Disable copy constructor
      private: void operator=( const Guitar& ); // Disable assignment operator

      protected: Guitar()
      {
      }
      public: virtual ~Guitar()
      {

         for( std::vector< Bridge* >::iterator iterator = _Bridge.begin();
         _Bridge.end() != iterator; ++iterator )
         {
            delete *iterator;
         }
         _Bridge.clear();

      }
      public: virtual void bake() const 
      {
         std::cout << "Bake for 25 minutes at 350" << std::endl;
      }
      public: virtual void cut() const 
      {
         std::cout << "Cutting the pizza into diagonal slices" << std::endl;
      }
      public: virtual void box() const
      {
         std::cout << "Place pizza in official PizzaStore box" << std::endl;
      }
      public: void setName( std::string name) 
      {
         _name = name;
      }
      public: std::string getName() const 
      {
         return _name;
      }
      public: std::string toString() const 
      {
    std::stringstream value; 
    value << "---- " << _name.c_str() << " ----" << std::endl;
    if( _HeadStock.get() != 0 ) 
    {
       value << _HeadStock->toString();
       value << std::endl;
         }
    if( _NeckStrap.get() != 0 ) 
    {
       value << _NeckStrap->toString();
       value << std::endl;
    }
    if( _Strings.get() != 0 ) 
    {
       value << _Strings->toString();
       value << std::endl;
    }
    if( _GuitarBody.get() != 0 )
    {
       value << _GuitarBody->toString();
       value << std::endl;
    }

    if( _Switches.get() != 0 )
    {
       value << _Switches->toString();
       value << std::endl;
    }

    if( _Bridge.size() != 0 )
    {
       for( std::vector< Bridge* >::iterator iterator = _Bridge.begin(); 
            _Bridge.end  () != iterator; ++iterator ) 
       {
          value << ( *iterator )->toString() << ", ";
       }
       value << std::endl;
    }

    return value.str();
      }
};


//////////////////////////////////////Class guitar store////////////////


class GuitarStore 

{

      protected: GuitarStore() 
      {
      }
      public: virtual ~GuitarStore() = 0 
      {
      }
      public: std::auto_ptr< Guitar > orderGuitar( std::string type ) const 
      {
         std::auto_ptr< Guitar > guitar( createGuitar( type ) );
         std::cout << "--- Making a " << guitar->getName() << " ---" << std::endl;
         guitar->prepare();
         guitar->bake();
         guitar->cut();
         guitar->box();
         return guitar;
      }
      public: virtual std::auto_ptr< Guitar > createGuitar( std::string type ) const = 0;
};


//////////////////////////////////guitar component factory////////////////////////////////



class GuitarComponentFactory 

      {
         public: virtual HeadStock* createHeadStock() const = 0;
         public: virtual NeckStrap* createNeckStrap() const = 0;
         public: virtual Strings* createStrings() const = 0;
         public: virtual std::vector< Bridge* > createBridge() const = 0;
         public: virtual Switches* createSwitches() const = 0;
         public: virtual GuitarBody* createGuitarBody() const = 0;
         public: virtual ~GuitarComponentFactory() = 0 {}
      };


///////////////////////////// electric guitar///////////////////

class ElectricGuitar : public Guitar

{

      private: mutable std::auto_ptr< GuitarComponentFactory > _ingredientFactory;

      public: explicit ElectricGuitar( GuitarComponentFactory* ingredientFactory ) :
      _ingredientFactory( ingredientFactory ) 
      {
         assert( ingredientFactory );
      }
      public: void prepare() const 
      {
         std::cout << "Preparing " << getName().c_str() << std::endl;
         _HeadStock = std::auto_ptr< HeadStock>( _ingredientFactory->createHeadStock() );
         _NeckStrap = std::auto_ptr< NeckStrap>( _ingredientFactory->createNeckStrap() );
         _Strings = std::auto_ptr< Strings>( _ingredientFactory->createStrings() );
         _Switches= std::auto_ptr< Switches>( _ingredientFactory->createSwitches() );
         if( _Bridge.empty() ) 
            _Bridge = _ingredientFactory->createBridge();
      }
};


//////////// electric guitar component factory////////////////


class ElectricGuitarComponentFactory : public GuitarComponentFactory 

{

      public: HeadStock* createHeadStock() const 
      {
         return new AngledHeadStock();
      }
      public: NeckStrap* createNeckStrap() const 
      {
         return new LeatherNeckStrap();
      }
      public: Strings* createStrings() const 
      {
         return new NylonStrings();
      }
      public: std::vector< Bridge* > createBridge() const 
      {
         std::vector< Bridge* > bridge;
         bridge.push_back( new ChromeBridge() );
         return bridge;
      }

      public: Switches* createSwithes() const
      {
         return new SPDT_Switches();
      }

      public: GuitarBody* createGuitarBody() const 
      {
         return new HollowGuitarBody();
      }

};


//////////////////// electric guitar srore  ////////////////


class ElectricGuitarStore : public GuitarStore 

{

      public: std::auto_ptr< Guitar > createGuitar( std::string item ) const
      {
         std::auto_ptr< Guitar > guitar( 0 );
         GuitarComponentFactory* ingredientFactory = new ElectricGuitarComponentFactory();
         if( item.compare( "Electric" ) == 0 ) 
         {
       guitar = std::auto_ptr< Guitar >( new ElectricGuitar( ingredientFactory ) );
       guitar->setName( "Electric GuitarBody" );
            return guitar;
         }
      }
};

任何帮助都会提前感谢... =)

3 个答案:

答案 0 :(得分:4)

要修复特定问题,您需要声明ElectricGuitarComponentFactory的析构函数,因为您已将基类的析构函数声明为纯虚函数。为什么你已经将基类析构函数声明为纯虚拟,我不知道;这样做真的没有任何意义。析构函数应该声明为虚拟,但不是纯虚拟的。

此外,您使用的语法

public: virtual ~GuitarComponentFactory() = 0 {}

是不正确的。您无法在类定义中声明纯虚函数为其提供定义。如果要为纯虚函数提供定义,则必须在类定义之外执行此操作。您正在使用的编译器Visual C ++对此规则有点宽容。

答案 1 :(得分:2)

class GuitarComponentFactory 
  {
     public: virtual ~GuitarComponentFactory() = 0 {}
  };

在派生的ElectricGuitarComponentFactory中,您不提供析构函数,因此它仍然是一个抽象类。

答案 2 :(得分:0)

ElectricGuitarComponentFactory 继承 GuitarComponentFactory ....

当您继承抽象类(abstract =具有纯虚方法)时,您需要覆盖所有这些方法。

你在 GuitarComponentFactory 中有7个方法,在 ElectricGuitarComponentFactory 中你只声明了6个。

你忘了覆盖析构函数。