使用Object.assign()分配数字会导致对象引用未定义

时间:2018-03-21 04:48:21

标签: ecmascript-6 javascript-objects assign

我为此处包含的大量代码道歉,但我想透露一切。无论我尝试什么,我都无法让Object.assign()为给定的密钥分配整数,尽管完全相同的操作可以在下一行分配浮点数。

此代码包含所有需要的引用,因此它很笨重(我的调试工具包的一部分):

let markers = []
let cumulativeTimes = {}

const randomWholeNumber = (min, max) => Math.floor(Math.random() * (max - min + 1) + min)

const time = (marker) => { markers[marker] = process.hrtime() }

const timeEnd = (marker, cumulative = true) => {
  const hrend = process.hrtime(markers[marker])
  const precision = 3
  const seconds = hrend[0] // already an int
  const milliSeconds = +(hrend[1] / 1000000).toFixed(precision) // unary plus converts string result to int

  console.log(`Seconds is ${seconds} with type ${typeof(seconds)}`) // outputs "number" - always!

  if (cumulative) {
    let mark = cumulativeTimes[marker]
    mark ? mark.s += seconds : Object.assign(cumulativeTimes, { [marker]: { s: seconds } } ) // <-- It's a trap!
    mark ? mark.ms += milliSeconds : Object.assign(cumulativeTimes, { [marker]: { ms: milliSeconds } } )
    mark = cumulativeTimes[marker]
    console.log(`${mark.s}s, ${mark.ms}ms -- ${marker}`) // outputs undefineds, then NaNs (for seconds)
  } else {
    console.log(`${seconds}s, ${milliSeconds}ms -- ${marker}`)
  }
}

const someLongOp = () => {
  time('someLongOp')
  return new Promise ( async (resolve) => {
    await setTimeout(timeEnd, randomWholeNumber(1000, 5000), 'someLongOp')
    resolve()
  })
}

const test = async (count) => {
  for (let i = 0; i < count; i++) {
    await someLongOp()
  }
}

test(2)

示例输出:

Seconds is 2 with type number
undefineds, 993.351ms -- someLongOp
Seconds is 3 with type number
NaNs, 1476.091ms -- someLongOp

现在我理解为什么第二个值是NaN(因为第二次运行timeEnd()&#34; mark.s&#34;键存在,但它引用值undefined,并执行任何关于undef的算术都会导致NaN)。

我不知道的是,当seconds是一个简单的无符号整数(确认为数字)时,该值在第一次运行{{1}时未正确分配1}}。甚至更奇怪,正如我们从毫秒输出中看到的那样,这个完全相同的操作对浮点数工作正常......尽管它们在技术上都是double-precision 64-bit unsigned ints

timeEnd()的默认值更改为false,并输出秒数并按预期显示,因此我95%确定cumulative部分期间发生的事情

一旦获得资格,肯定会给予奖励......期待了解到底发生了什么!

1 个答案:

答案 0 :(得分:1)

这与双打和整数无关。这只是你的代码

mark ? mark.s += seconds : Object.assign(cumulativeTimes, { [marker]: { s: seconds } } ) // <-- It's a trap!
mark ? mark.ms += milliSeconds : Object.assign(cumulativeTimes, { [marker]: { ms: milliSeconds } } )

错了。让我们去除它吧:

if (mark)
   mark.s += seconds;
else
   cumulativeTimes[marker] = { s: seconds };
if (mark)
   mark.ms += milliSeconds;
else
   cumulativeTimes[marker] = { ms: milliSeconds };

这显然不起作用,用s属性覆盖具有ms属性的对象。请记住,Object.assign不会递归合并!

你真正想要的是

if (mark) {
    mark.s += seconds;
    mark.ms += milliSeconds;
} else {
    cumulativeTimes[marker] = {
        s: seconds,
        ms: milliSeconds
    };
}