嗨我想在这里排除带注释的方法是代码。
@Aspect
public class ExceptionHandlingAspect {
private static final String TAG = ExceptionHandlingAspect.class.getName();
@Pointcut("execution(* android.mobile.peakgames.net.aspectjandroid.AspectActivity.*(..)) " +
"&& !@annotation(android.mobile.peakgames.net.aspectjandroid.exception.NoTryCatch)")
public void exceptionEntryPoint() {
}
@AfterThrowing(pointcut = "exceptionEntryPoint()", throwing = "throwable")
public void exceptionMethod(JoinPoint joinPoint, Throwable throwable) {
Log.e(TAG, "Exception caught : " + throwable + " on method : " + joinPoint.getSignature());
if (joinPoint.getTarget() instanceof Activity) {
if (throwable instanceof AuthenticationException) {
new AlertDialog.Builder((Context) joinPoint.getTarget())
.setTitle("Authentication Error")
.setMessage("You are not authenticated")
.show();
} else {
new AlertDialog.Builder((Context) joinPoint.getTarget())
.setTitle("Error")
.setMessage("Error occurred at : " + joinPoint.getSignature() + " " +
"Exception : " + throwable)
.show();
}
}
}
@Around(value = "exceptionEntryPoint()")
public Object exceptionAroundMethod(ProceedingJoinPoint joinPoint) {
try {
return joinPoint.proceed();
} catch (Throwable ignored) {
}
return null;
}
}
排除任何使用NoTryCatch
上面的代码确实排除了使用NoTryCatch注释的方法,但是当这个方法被异常调用时,它会暂停下一个方法的执行。例如
@NoTryCatch
void test(){throws NullPointor..}
现在我按顺序调用方法
test()
test1()
test1()无法运行。
如果删除!@annotation(android.mobile.peakgames.net.aspectjandroid.exception.NoTryCatch)
,则test1()运行
答案 0 :(得分:2)
如果您忽略test1()
中引发的异常,即{}升级,则test()
无法运行。由于未处理的异常,永远不会调用下一个方法。我认为这正是你的方面所要做的。你为什么期待不同的行为?如果您确实期望其他内容,请在评论中进行描述,我可以在编辑答案时向您显示如何操作。
OP评论后更新:
嗯,你在这里遇到了一个自制问题:如果方法void caller()
调用@NoTryCatch void callee()
,那么callee()
中的异常当然不会按照设计处理。相反,它升级到caller()
,这是没有注释的,因此方面将在那里处理它。调用者如何知道被调用者中的某个方面忽略了该异常?或者方面如何才能知道呢?当将控制返回给调用者时,被调用者的控制流已经结束。
这种异常处理的概念至少是棘手的。我甚至称之为有问题,因为调用链的最内层元素确定所有外部元素都应该忽略异常。通常,异常处理只是另一种方式。调用者确定如何处理被调用者抛出的异常,而不是被调用者本身。所以我建议你改变你的想法和异常处理的概念。
话虽如此,我会告诉你我说的内容真的发生在你的应用程序中MCVE。因为我不是Android开发人员并希望它在任何Java SE机器上运行,所以我使用模型模拟了这样的Android API的相关部分:
Android API模型:
package android.content;
public class Context {}
package android.app;
import android.content.Context;
public class Activity extends Context {}
只需登录控制台即可模拟警报对话框。
package android.app;
import android.content.Context;
public class AlertDialog {
public AlertDialog() {}
public static class Builder {
private String title;
private String message;
public Builder(Context target) {}
public Builder setTitle(String title) {
this.title = title;
return this;
}
public Builder setMessage(String message) {
this.message = message;
return this;
}
public void show() {
System.out.println("ALERT DIALOG: " + title + " -> " + message);
}
}
}
package org.apache.http.auth;
public class AuthenticationException extends Exception {
private static final long serialVersionUID = 1L;
public AuthenticationException(String message) {
super(message);
}
}
标记注释:
package android.mobile.peakgames.net.aspectjandroid.exception;
import static java.lang.annotation.RetentionPolicy.RUNTIME;
import java.lang.annotation.Retention;
@Retention(RUNTIME)
public @interface NoTryCatch {}
驱动程序应用程序:
package android.mobile.peakgames.net.aspectjandroid;
import org.apache.http.auth.AuthenticationException;
import android.app.Activity;
import android.mobile.peakgames.net.aspectjandroid.exception.NoTryCatch;
public class AspectActivity extends Activity {
public String doSomething() {
System.out.println("Doing something");
return "something";
}
@NoTryCatch
public String doSomethingElse() {
System.out.println("Doing something else");
throw new RuntimeException("oops");
}
public String doSomethingFancy() throws AuthenticationException {
System.out.println("Doing something fancy");
throw new AuthenticationException("uh-oh");
}
public void run() throws AuthenticationException {
doSomething();
doSomethingElse();
doSomethingFancy();
}
public static void main(String[] args) throws AuthenticationException {
new AspectActivity().run();
}
}
OP的方面,略微优化:
基本上这只是你的方面,有一些优化:
AspectActivity
中的方法。因此,很明显,连接点的目标始终是Activity
,因此始终是Context
。将target()
绑定到一个advice参数更清晰,更安全,可以让你摆脱丑陋的演员和instanceof
。package de.scrum_master.aspect;
import org.apache.http.auth.AuthenticationException;
import org.aspectj.lang.ProceedingJoinPoint;
import org.aspectj.lang.annotation.Around;
import org.aspectj.lang.annotation.Aspect;
import org.aspectj.lang.annotation.Pointcut;
import android.app.AlertDialog;
import android.app.AlertDialog.Builder;
import android.mobile.peakgames.net.aspectjandroid.AspectActivity;
import android.util.Log;
@Aspect
public class ExceptionHandlingAspect {
private static final String TAG = ExceptionHandlingAspect.class.getName();
@Pointcut("execution(* *(..)) && target(activity)")
public void methodsOfInterest(AspectActivity activity) {}
@Pointcut("@annotation(android.mobile.peakgames.net.aspectjandroid.exception.NoTryCatch)")
public void annotationNoTryCatch() {}
@Around("methodsOfInterest(activity) && !annotationNoTryCatch()")
public Object exceptionAroundMethod(ProceedingJoinPoint thisJoinPoint, AspectActivity activity) {
try {
return thisJoinPoint.proceed();
} catch (Throwable throwable) {
String errorMessage = "Error " + throwable + " in method " + thisJoinPoint.getSignature();
Log.e(TAG, errorMessage);
Builder builder = new AlertDialog.Builder(activity);
if (throwable instanceof AuthenticationException)
builder.setTitle("Authentication Error").setMessage("You are not authenticated").show();
else
builder.setTitle("Error").setMessage(errorMessage).show();
return null;
}
}
}
控制台日志:
Doing something
Doing something else
[de.scrum_master.aspect.ExceptionHandlingAspect] Error java.lang.RuntimeException: oops in method void android.mobile.peakgames.net.aspectjandroid.AspectActivity.run()
ALERT DIALOG: Error -> Error java.lang.RuntimeException: oops in method void android.mobile.peakgames.net.aspectjandroid.AspectActivity.run()
日志清楚显示
doSomethingElse()
并且不处理错误run()
会触发建议,因此会在那里处理错误。run()
,错误也会在main(..)
处理。那么为了避免注释整个调用链,你需要做什么?只有一种 - 相当丑陋 - 这样做的方式:手动记账,即你的方面需要记住它之前忽略的异常实例,因为相应的错误处理建议从未针对该异常运行。
因此,你需要像这样改变你的方面(忽略多线程和手动try-catch等创建的嵌套异常等问题,以免使其变得更加复杂):
Aspect,迭代2:
package de.scrum_master.aspect;
import java.util.HashSet;
import java.util.Set;
import org.apache.http.auth.AuthenticationException;
import org.aspectj.lang.JoinPoint;
import org.aspectj.lang.ProceedingJoinPoint;
import org.aspectj.lang.annotation.AfterThrowing;
import org.aspectj.lang.annotation.Around;
import org.aspectj.lang.annotation.Aspect;
import org.aspectj.lang.annotation.Pointcut;
import android.app.AlertDialog;
import android.app.AlertDialog.Builder;
import android.mobile.peakgames.net.aspectjandroid.AspectActivity;
import android.util.Log;
@Aspect
public class ExceptionHandlingAspect {
private static final String TAG = ExceptionHandlingAspect.class.getName();
private Set<Throwable> ignoredErrors = new HashSet<>();
@Pointcut("execution(* *(..)) && target(activity)")
public void methodsOfInterest(AspectActivity activity) {}
@Pointcut("@annotation(android.mobile.peakgames.net.aspectjandroid.exception.NoTryCatch)")
public void annotationNoTryCatch() {}
@Around("methodsOfInterest(activity) && !annotationNoTryCatch()")
public Object exceptionAroundMethod(ProceedingJoinPoint thisJoinPoint, AspectActivity activity) throws Throwable {
try {
return thisJoinPoint.proceed();
} catch (Throwable throwable) {
if (ignoredErrors.contains(throwable))
throw throwable;
String errorMessage = "Error " + throwable + " in method " + thisJoinPoint.getSignature();
Log.e(TAG, errorMessage);
Builder builder = new AlertDialog.Builder(activity);
if (throwable instanceof AuthenticationException)
builder.setTitle("Authentication Error").setMessage("You are not authenticated").show();
else
builder.setTitle("Error").setMessage(errorMessage).show();
return null;
}
}
@AfterThrowing(value = "methodsOfInterest(activity) && annotationNoTryCatch()", throwing = "throwable")
public void ignoreExceptions(JoinPoint thisJoinPoint, AspectActivity activity, Throwable throwable) {
ignoredErrors.add(throwable);
}
}
控制台日志,迭代2:
Doing something
Doing something else
Exception in thread "main" java.lang.RuntimeException: oops
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.doSomethingElse(AspectActivity.java:17)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.run_aroundBody4(AspectActivity.java:27)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.run_aroundBody5$advice(AspectActivity.java:34)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.run(AspectActivity.java:1)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.main(AspectActivity.java:32)
正如您所看到的,异常现在升级,&#34;崩溃&#34;正如你所说,你想要的应用程序。
P.S。:InheritableThreadLocal<Throwable>
是你的朋友,如果你喜欢这个方面是线程安全的。如果您确实需要,请随时询问,但不知道我在说什么。
P.P.S。:如果您将@NoTryCatch
注释从doSomethingElse()
向下移动到doSomethingFancy
,则日志会更改如下:
Doing something
Doing something else
[de.scrum_master.aspect.ExceptionHandlingAspect] Error java.lang.RuntimeException: oops in method String android.mobile.peakgames.net.aspectjandroid.AspectActivity.doSomethingElse()
ALERT DIALOG: Error -> Error java.lang.RuntimeException: oops in method String android.mobile.peakgames.net.aspectjandroid.AspectActivity.doSomethingElse()
Doing something fancy
Exception in thread "main" org.apache.http.auth.AuthenticationException: uh-oh
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.doSomethingFancy(AspectActivity.java:22)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.run_aroundBody4(AspectActivity.java:28)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.run_aroundBody5$advice(AspectActivity.java:34)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.run(AspectActivity.java:1)
at android.mobile.peakgames.net.aspectjandroid.AspectActivity.main(AspectActivity.java:32)