是否可以将SDL2与智能指针一起使用?

时间:2018-02-07 20:07:28

标签: c++ sdl smart-pointers sdl-2 unique-ptr

我有这行代码

//std::unique_ptr<SDL_Window> _window_; // this is somewhere else...
_window_ = std::make_unique<SDL_Window>(SDL_CreateWindow("SDL Window", SDL_WINDOWPOS_UNDEFINED, SDL_WINDOWPOS_UNDEFINED, _WIDTH_, _HEIGHT_, SDL_WINDOW_SHOWN));

它会产生以下编译器错误

In file included from /usr/include/c++/6/memory:81:0,
                 from /home/user/prj/src/main.cpp:4:
/usr/include/c++/6/bits/unique_ptr.h: In instantiation of ‘typename 
std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...) [with _Tp = SDL_Window; _Args = {SDL_Window*}; typename 
std::_MakeUniq<_Tp>::__single_object = std::unique_ptr<SDL_Window>]’:
/home/user/prj/src/main.cpp:36:170:   required from here
/usr/include/c++/6/bits/unique_ptr.h:791:30: error: invalid use of incomplete type ‘struct SDL_Window’
     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }

为什么呢? (没有智能指针,它工作正常,所以我的猜测是我没有理解语法,这很容易解决。将在下面添加源和CMakeLists.txt。)

的CMakeLists.txt

cmake_minimum_required(VERSION 3.7)
project(prj)

find_package(SDL2 REQUIRED)
include_directories(prj ${SDL2_INCLUDE_DIRS})

add_executable(prj main.cpp)
target_link_libraries(prj ${SDL2_LIBRARIES})

的main.cpp

#include "SDL.h"
#include <memory>
#include <iostream>
#include <fstream>
#include <cstdint>

class Window
{

    public:

    Window()
        : _window_{nullptr}
        , _surface_{nullptr}
    {
        if(SDL_Init(SDL_INIT_VIDEO) < 0)
        {
            std::cerr << SDL_GetError() << std::endl;
        }
        else
        {
            _window_ = std::make_unique<SDL_Window>(SDL_CreateWindow("SDL Window", SDL_WINDOWPOS_UNDEFINED, SDL_WINDOWPOS_UNDEFINED, _WIDTH_, _HEIGHT_, SDL_WINDOW_SHOWN));

            if(_window_ == nullptr)
            {
                std::cerr << SDL_GetError() << std::endl;
            }
            else
            {
                _surface_ = std::make_unique<SDL_Surface>(SDL_GetWindowSurface(_window_.get()));
                SDL_FillRect(_surface_.get(), nullptr, SDL_MapRGB(_surface_->format, 0xFF, 0xFF, 0xFF));
                SDL_UpdateWindowSurface(_window_.get());
                SDL_Delay(1000);
            }
        }
    }

    ~Window()
    {
        SDL_DestroyWindow(_window_.get());
        SDL_Quit();
    }

    private:

    const int32_t _WIDTH_{600};
    const int32_t _HEIGHT_{400};

    std::unique_ptr<SDL_Window> _window_;
    std::unique_ptr<SDL_Surface> _surface_;

};


int main(int argc, char* argv[])
{
    Window window;
    return 0;
}

3 个答案:

答案 0 :(得分:3)

解决方案

最后通过大量试验和错误找出了答案,因此将在此解释解决方案。

这是正确的语法:

// first define the unique_ptr as member of class
std::unique_ptr<SDL_Window, decltype(&SDL_DestroyWindow)> _window_;

// second, initialize in the member initialization list of class constructor
// probably don't need to do this if not embedding as member of class
class_name()
    : _window_(nullptr, SDL_DestroyWindow)
{
    // blaa blaa SDL code etc
    _window_.reset(SDL_CreateWindow("SDL Window", SDL_WINDOWPOS_UNDEFINED, SDL_WINDOWPOS_UNDEFINED, WIDTH, HEIGHT, SDL_WINDOW_SHOWN));
}

// finally we need to be able to delete
// but this is handled automatically

解释

当我们将unique_ptr添加为数据成员时,我们需要同时提供类型SDL_Window和“删除函数格式/语法”,因为普通的delete调用不正确。我们使用decltype从删除函数中自动构造正确的删除器格式。 (也许不是最准确的解释。)在某种程度上,decltype有点像自动......

std::unique_ptr<SDL_Window, decltype(&SDL_DestroyWindow)> _window_;

必须初始化此对象。我们在构造函数中执行此操作。我们将指针设置为nullptr(因为我们不想在初始化SDL2之前初始化它),我们还设置了删除函数。

: _window_(nullptr, SDL_DestroyWindow)

在初始化SDL之后,我们想要创建一个窗口。通过调用智能指针reset()函数可以轻松完成此操作。我们传递一个由创建窗口的函数返回的新指针。

_window_.reset(SDL_CreateWindow(...));

完成。花了很长时间才弄清楚但现在才有意义。参考

http://en.cppreference.com/w/cpp/memory/unique_ptr

Why does my unique_ptr think is has a null function pointer deleter?

What's wrong with this initialization of unique_ptr?

答案 1 :(得分:1)

这些结构是opaque data structures,你没有完整的定义。这意味着,默认的PretendModal()删除器不知道如何“删除”结构。

您需要提供自己的自定义删除工具。对于[assembly: ExportRenderer(typeof(GoogleLoginPage), typeof(GoogleLoginPageRenderer))] { class GoogleLoginPageRenderer : PageRenderer { public GoogleLoginPageRenderer(Context context) : base(context) { } protected override void OnElementChanged(ElementChangedEventArgs<Page> e) { base.OnElementChanged(e); var activity = Context as Activity; activity.StartActivity(GooglePlusSingleton.Instance.OAuthSettings.GetUI(activity)); GooglePlusSingleton.Instance.OAuthSettings.Completed += (sender, eventArgs) => { if (eventArgs.IsAuthenticated) { Console.WriteLine("Virker"); GooglePlusSingleton.Instance.SaveToken(eventArgs.Account.Properties["access_token"]); GooglePlusSingleton.Instance.SuccessfulLoginAction.Invoke(); } else { Console.WriteLine("Virker ikke"); GooglePlusSingleton.Instance.FailedLoginAction.Invoke(); } }; } } } ,它是SDL_DestroyWindow函数。

答案 2 :(得分:0)

SDL Windows使用SDL_DestroyWindow销毁,而不是普通删除,就像unique_ptr的默认删除一样。您需要为unique_ptr提供自定义删除器,它将调用SDL_DestroyWindow。