Question

我有这个代码用于发送生日提醒电子邮件。除了每年的1月1日以外的每个日期都执行罚款。 1月1日发送的电子邮件实际上是31日发送的，即使在数据库中它是1月1日，并且变量也是1 jan而不是31 jan。代码是：

public void birthdayReminder(string month)
{
    try
    {

        SqlConnection con;
        SqlCommand cmdReminder;
        SqlDataReader userReminder;
        bool result = false;

        string todaydate = "";
        DateTime now = DateTime.Now.AddDays(1);
        todaydate = now.ToString("dd", CultureInfo.InvariantCulture);

        con = new SqlConnection(ConfigurationManager.ConnectionStrings["cs"].ConnectionString);
        con.Open();

        cmdReminder = con.CreateCommand();
        cmdReminder.CommandText = "select staffid, staffmonth, staffdate from tbstaff where staffmonth='" + month + "' and staffdate='" + todaydate + "' and staffcurrstatus='Active'";
        userReminder = cmdReminder.ExecuteReader();
        //userReminder.Read();
        result = userReminder.HasRows;

        while (userReminder.Read())
        {
            try
            {
                SqlConnection con1;
                con1 = new SqlConnection(ConfigurationManager.ConnectionStrings["cs"].ConnectionString);
                con1.Open();

                SqlDataReader rdr;
                SqlCommand cmdRemUpd = con1.CreateCommand();
                cmdRemUpd.CommandText = "select * from tbl_BirthdayReminder where staffid='" + userReminder.GetInt32(0) + "' and year='" + DateTime.Today.Year.ToString() + "'";
                rdr = cmdRemUpd.ExecuteReader();

                bool res = rdr.HasRows;
                if(!res)
                    sendBirthdayEmail(userReminder.GetInt32(0));
                con1.Close();
            }
            catch (Exception e1) { }
        }

        userReminder.Close();
        con.Close();
    }
    catch (SqlException ex) { }
}

protected void sendBirthdayEmail(int id)
{
    DataTable dt = new DataTable();

    try
    {
        SqlDataAdapter adp = new SqlDataAdapter("select * from tbstaff where staffid='" + id + "'", ConfigurationManager.ConnectionStrings["cs"].ConnectionString);
        adp.Fill(dt);

        string name=dt.Rows[0]["stafffname"].ToString()+' '+dt.Rows[0]["stafflname"].ToString();
        string acmng = dt.Rows[0]["staffacmng"].ToString();
        SqlConnection con;
        SqlCommand cmd;
        con = new SqlConnection(ConfigurationManager.ConnectionStrings["cs"].ConnectionString);
        con.Open();

        cmd = con.CreateCommand();
        cmd.CommandText = "select emailAddress from tbuser where firstName='" + acmng + "'";
        SqlDataReader dr = cmd.ExecuteReader();
        dr.Read();

        string to= dr.GetValue(0).ToString();
        con.Close();

        Configuration configurationFile = System.Web.Configuration.WebConfigurationManager.OpenWebConfiguration("~\\Web.config");
        MailSettingsSectionGroup mailSettings = configurationFile.GetSectionGroup("system.net/mailSettings") as MailSettingsSectionGroup;

        string username = "";
        string password = "";
        string fromAddress = "";
        int port = 0;
        string host = "";

        if (mailSettings != null)
        {
            port = mailSettings.Smtp.Network.Port;
            host = mailSettings.Smtp.Network.Host;
            password = mailSettings.Smtp.Network.Password;
            username = mailSettings.Smtp.Network.UserName;
            fromAddress = username;
        }
        string Aliasname = System.Configuration.ConfigurationManager.AppSettings["Alias"].ToString();

        string body = "";
        SmtpClient emailclient = new SmtpClient();
        string path = "http://www.columbuscorp.com/sat/images/happybirthday.jpg";
        body += "<html><body>";
        body += "Hello <br /><br />";
        body += "Please send birthday Card to " + name + " as his/her Birthday Date is on " + dt.Rows[0]["staffmonth"].ToString() + " " + dt.Rows[0]["staffdate"].ToString() + "<br/>";
        body +="<img src=" + path;
        body += " width=672 height=491></img>";

        body += "<br /><br />Thanks from SAT Admin";
        body += "</body></html>";

        try
        {
            SqlConnection con1;
            con1 = new SqlConnection(ConfigurationManager.ConnectionStrings["cs"].ConnectionString);
            con1.Open();

            SqlCommand cmdRemUpd = con1.CreateCommand();
            cmdRemUpd.CommandText = "insert into tbl_BirthdayReminder(staffid,year) values('" + id + "','" + DateTime.Today.Year.ToString() + "')";
            cmdRemUpd.ExecuteNonQuery();
            con1.Close();
        }
        catch (Exception e1) { }

Answer 1

您所关注的日期总是在将来的某一天：

DateTime now = DateTime.Now.AddDays(1);

这意味着12月31日你正在考虑明年的约会。另一方面，这将使用“旧”年，而不是新年

cmdRemUpd.CommandText = "select * from tbl_BirthdayReminder where staffid='" + userReminder.GetInt32(0) + "' and year='" + DateTime.Today.Year.ToString() + "'";

因此，您正在查找确实存在的记录（去年的生日提醒），因此不会发送生日提醒 - 它应该与我假设的上述日期相同，而是：

cmdRemUpd.CommandText = "select * from tbl_BirthdayReminder where staffid='" + userReminder.GetInt32(0) + "' and year='" + now.Year.ToString() + "'";

代码执行日期1月1日jan DateTime.Add

1 个答案: