double char指针c的简单多重新分配

时间:2018-01-26 08:15:47

标签: c pointers char realloc

我试图在一个更大的程序中动态地重新分配一个双字符指针,我总是得到那个错误" realloc():无效的下一个大小",所以我写了一个较小的测试,以显示你的家伙我的确切问题:

我的小测试:

#include <stdlib.h>
#include <stdio.h>
#include <string.h>

int main(void){
    char **buf = malloc(sizeof(char*));
    for(int i = 0; i < 20; i++){
        buf[i] = malloc(sizeof(char) * 6);
        strcpy(buf[i], "hallo");
        printf("%s\n", buf[i]);
        if( (realloc(buf, sizeof(char*) * (i+1))) == NULL) exit(-1);
    }

    return 0;
}

这总是在第4次重新分配时崩溃,并显示完整的错误消息:

Error in `./myTest': realloc(): invalid next size: 0x0000000001cb2010 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7f450a4a97e5]
/lib/x86_64-linux-gnu/libc.so.6(+0x834aa)[0x7f450a4b54aa]
/lib/x86_64-linux-gnu/libc.so.6(realloc+0x179)[0x7f450a4b6839]
./myTest[0x40069c]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f450a452830]
./myTest[0x400529]
======= Memory map: ========
00400000-00401000 r-xp 00000000 08:01 663159                             
/home/qbongo/BS-PK-2017/10_pk/myTest
00600000-00601000 r--p 00000000 08:01 663159                             
/home/qbongo/BS-PK-2017/10_pk/myTest
00601000-00602000 rw-p 00001000 08:01 663159                             
/home/qbongo/BS-PK-2017/10_pk/myTest
01cb2000-01cd3000 rw-p 00000000 00:00 0                                  [heap]
7f4504000000-7f4504021000 rw-p 00000000 00:00 0 
7f4504021000-7f4508000000 ---p 00000000 00:00 0 
7f450a21c000-7f450a232000 r-xp 00000000 08:01 398530                     
/lib/x86_64-linux-gnu/libgcc_s.so.1
7f450a232000-7f450a431000 ---p 00016000 08:01 398530                     
/lib/x86_64-linux-gnu/libgcc_s.so.1
7f450a431000-7f450a432000 rw-p 00015000 08:01 398530                     
/lib/x86_64-linux-gnu/libgcc_s.so.1
7f450a432000-7f450a5f2000 r-xp 00000000 08:01 394742                     
/lib/x86_64-linux-gnu/libc-2.23.so
7f450a5f2000-7f450a7f2000 ---p 001c0000 08:01 394742                     
/lib/x86_64-linux-gnu/libc-2.23.so
7f450a7f2000-7f450a7f6000 r--p 001c0000 08:01 394742                     
/lib/x86_64-linux-gnu/libc-2.23.so
7f450a7f6000-7f450a7f8000 rw-p 001c4000 08:01 394742                     
/lib/x86_64-linux-gnu/libc-2.23.so
7f450a7f8000-7f450a7fc000 rw-p 00000000 00:00 0 
7f450a7fc000-7f450a822000 r-xp 00000000 08:01 393312                     
/lib/x86_64-linux-gnu/ld-2.23.so
7f450aa07000-7f450aa0a000 rw-p 00000000 00:00 0 
7f450aa20000-7f450aa21000 rw-p 00000000 00:00 0 
7f450aa21000-7f450aa22000 r--p 00025000 08:01 393312                     
/lib/x86_64-linux-gnu/ld-2.23.so
7f450aa22000-7f450aa23000 rw-p 00026000 08:01 393312                     
/lib/x86_64-linux-gnu/ld-2.23.so
7f450aa23000-7f450aa24000 rw-p 00000000 00:00 0 
7ffcc108f000-7ffcc10b0000 rw-p 00000000 00:00 0                          [stack]
7ffcc1149000-7ffcc114b000 r--p 00000000 00:00 0                          [vvar]
7ffcc114b000-7ffcc114d000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  
[vsyscall]
Aborted (core dumped)

3 个答案:

答案 0 :(得分:1)

通过调用char **buf = malloc(sizeof(char*));,您只分配一个指针,而不是它们的数组。

const size_t items_count = 20;
char **buf = malloc(sizeof(char*) * items_count);
for(int i = 0; i < items_count; i++){
    buf[i] = malloc(sizeof(char) * 6); // now we won't access array out of bounds here
// no need to realloc

答案 1 :(得分:1)

应该是:

buf = realloc(buf, sizeof(char*) * (i+2));
  1. 您的代码只是丢弃了realloc
  2. 的结果
  3. 如果您在迭代结束时这样做,则需要分配(i+2)
  4. 我认为这不是你的实际代码,但将realloc移到循环的顶部(检查first example for realloc on this page)会更有意义,例如:

    for(int i = 0; i < 20; i++)
    {
        buf = realloc(buf, sizeof(char*) * (i+1));
        if (buf == NULL)
            exit(-1);
    
        ...
    }
    

    <强>(更新)

    根据@ coderredoc下面的评论,虽然exit将释放与该过程相关的所有内存,但请记住,良好的编程习惯是释放先前分配的指针,以防realloc失败:

    char **buf = malloc(sizeof(char*));
    for (int i = 0; i < 20; i++)
    {
        // try to realloc
        {
            char ** larger = realloc(buf, sizeof(char*) * (i + 1));
            if (larger) 
            {
                buf = larger;
            }
            else 
            {
                // realloc failed, we might need to free individual items
                // if we are not going to use them anymore
                for (int k = 0; k < (i - 1); k++) free(buf[k]);
    
                // we should free previous buff also
                free(buff);
    
                // we can exit, or break the loop, or whatever
                exit(-1);
            }
        }
    
        // do stuff here
        ...
    }
    

答案 2 :(得分:1)

我在您的代码中看到2个错误。

  1. 您未在buf中存储realloc返回的新地址。当所需的新空间不可用时,realloc会在内存中的其他位置分配新空间。

  2. 您的循环从i = 0开始,因此,当您第一次到达realloc时,您需要分配两个元素:i+2而不是i+1 }