我正在尝试使用@Timed(http://metrics.dropwizard.io/3.1.0/apidocs/com/codahale/metrics/annotation/package-summary.html)等注释自动将指标发布到MetricRegistry。
这不是开箱即用的。在搜索问题时,我发现Codahale Metrics: using @Timed metrics annotation in plain Java提到了这个问题的唯一方法就是使用aspectj。我将此添加到我的项目中,但仍然没有在MetricRegistry中看到我的指标。
这是我的pom文件。我添加了一个librato库,它加载到com.codahale.metrics:metrics-annotation
。
<dependency>
<groupId>io.astefanutti.metrics.aspectj</groupId>
<artifactId>metrics-aspectj</artifactId>
<version>${metrics-aspectj.version}</version>
</dependency>
<dependency>
<groupId>org.aspectj</groupId>
<artifactId>aspectjrt</artifactId>
<version>1.8.10</version>
</dependency>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<version>1.7</version>
<configuration>
<showWeaveInfo>true</showWeaveInfo>
<source>1.8</source>
<target>1.8</target>
<complianceLevel>1.8</complianceLevel>
<encoding>UTF-8</encoding>
<verbose>true</verbose>
<aspectLibraries>
<aspectLibrary>
<groupId>io.astefanutti.metrics.aspectj</groupId>
<artifactId>metrics-aspectj</artifactId>
</aspectLibrary>
</aspectLibraries>
</configuration>
<executions>
<execution>
<phase>process-sources</phase>
<goals>
<goal>compile</goal>
<goal>test-compile</goal>
</goals>
</execution>
</executions>
</plugin>
<dependency>
<groupId>com.librato.metrics</groupId>
<artifactId>metrics-librato</artifactId>
<version>${metrics-librato.version}</version>
</dependency>
这就是我尝试使用指标的方式
@Metrics(registry = "default") // this.metricRegistry is default
public class Foo {
@Inject
private MetricRegistry metricRegistry;
...
@Metered(name = "meterName")
public void bar() {
Meter meter = metricRegistry.meter("manual");
meter.mark();
// this.metricRegistry does not contain "meterName" after the ConsoleReporter prints the metrics for "default"
// this.metricRegistry contains "manual" after the ConsoleReporter prints the metrics for "default"
}
编译时,我在日志中看到了这一点:
[INFO] Extending interface set for type 'Foo' (Foo.java) to include 'io.astefanutti.metrics.aspectj.Profiled' (MetricAspect.aj)
[INFO] Type 'Foo' (Foo.java) has intertyped field from 'io.astefanutti.metrics.aspectj.MetricAspect' (MetricAspect.aj:'java.util.Map<java.lang.String,io.astefanutti.metrics.aspectj.AnnotatedMetric<com.codahale.metrics.Gauge>> io.astefanutti.metrics.aspectj.Profiled.gauges')
[INFO] Type 'Foo' (Foo.java) has intertyped field from 'io.astefanutti.metrics.aspectj.MetricAspect' (MetricAspect.aj:'java.util.Map<java.lang.String,io.astefanutti.metrics.aspectj.AnnotatedMetric<com.codahale.metrics.Meter>> io.astefanutti.metrics.aspectj.Profiled.meters')
[INFO] Type 'Foo' (Foo.java) has intertyped field from 'io.astefanutti.metrics.aspectj.MetricAspect' (MetricAspect.aj:'java.util.Map<java.lang.String,io.astefanutti.metrics.aspectj.AnnotatedMetric<com.codahale.metrics.Timer>> io.astefanutti.metrics.aspectj.Profiled.timers')
[INFO] Join point 'staticinitialization(void Foo.<clinit>())' in Type 'Foo' (Foo.java:46) advised by after advice from 'io.astefanutti.metrics.aspectj.MetricStaticAspect' (metrics-aspectj-1.2.0.jar!MetricStaticAspect.class:41(from MetricStaticAspect.aj))
[INFO] Join point 'method-execution(void Foo.bar())' in Type 'Foo' (Foo.java:74) advised by around advice from 'io.astefanutti.metrics.aspectj.TimedAspect' (metrics-aspectj-1.2.0.jar!TimedAspect.class:26(from TimedAspect.aj))
[INFO] Join point 'method-execution(void Foo.bar())' in Type 'Foo' (Foo.java:74) advised by before advice from 'io.astefanutti.metrics.aspectj.MeteredAspect' (metrics-aspectj-1.2.0.jar!MeteredAspect.class:26(from MeteredAspect.aj))
它似乎表明我设置的带注释的指标正常运行。但是,我也在我的日志中看到了这个
[WARNING] advice defined in io.astefanutti.metrics.aspectj.TimedStaticAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/TimedStaticAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.ExceptionMeteredAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/ExceptionMeteredAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.ExceptionMeteredStaticAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/ExceptionMeteredStaticAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.MeteredStaticAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/MeteredStaticAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.TimedAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/TimedAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.TimedStaticAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/TimedStaticAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.MetricAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/MetricAspect.class:45
[WARNING] advice defined in io.astefanutti.metrics.aspectj.ExceptionMeteredAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/ExceptionMeteredAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.MeteredAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/MeteredAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.ExceptionMeteredStaticAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/ExceptionMeteredStaticAspect.class:26
[WARNING] advice defined in io.astefanutti.metrics.aspectj.MetricStaticAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/MetricStaticAspect.class:41
[WARNING] advice defined in io.astefanutti.metrics.aspectj.MeteredStaticAspect has not been applied [Xlint:adviceDidNotMatch]
/Users/x/.m2/repository/io/astefanutti/metrics/aspectj/metrics-aspectj/1.2.0/metrics-aspectj-1.2.0.jar!io/astefanutti/metrics/aspectj/MeteredStaticAspect.class:26
这是我的应用设置
@Override
public void run(AppConfiguration configuration, Environment environment) {
ConsoleReporter reporter = ConsoleReporter.forRegistry(environment.metrics())
.convertRatesTo(TimeUnit.SECONDS)
.convertDurationsTo(TimeUnit.MILLISECONDS)
.build();
reporter.start(2, TimeUnit.MINUTES);
}
答案 0 :(得分:6)
我刚试了这个,效果很好。这是我的整个设置:
pom.xml:
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.mycompany.app</groupId>
<artifactId>my-app</artifactId>
<packaging>jar</packaging>
<version>1.0-SNAPSHOT</version>
<name>my-app</name>
<url>http://maven.apache.org</url>
<dependencies>
<dependency>
<groupId>io.astefanutti.metrics.aspectj</groupId>
<artifactId>metrics-aspectj</artifactId>
<version>1.2.0</version>
</dependency>
</dependencies>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<configuration>
<aspectLibraries>
<aspectLibrary>
<groupId>io.astefanutti.metrics.aspectj</groupId>
<artifactId>metrics-aspectj</artifactId>
</aspectLibrary>
</aspectLibraries>
<complianceLevel>1.8</complianceLevel>
<source>1.8</source>
<target>1.8</target>
</configuration>
<executions>
<execution>
<goals>
<goal>compile</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<version>2.4.1</version>
<configuration>
<!-- get all project dependencies -->
<descriptorRefs>
<descriptorRef>jar-with-dependencies</descriptorRef>
</descriptorRefs>
<!-- MainClass in mainfest make a executable jar -->
<archive>
<manifest>
<mainClass>com.mkyong.core.utils.App</mainClass>
</manifest>
</archive>
</configuration>
<executions>
<execution>
<id>make-assembly</id>
<!-- bind to the packaging phase -->
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
请注意,我需要添加aspectj-maven-plugin
。我还添加了一个assembly
插件,以便稍后进行测试。这不是真的必要,我只是不想去寻找我本地盒子的依赖。
我的定时课程:
package com.mycompany.app;
import java.util.concurrent.ThreadLocalRandom;
import com.codahale.metrics.annotation.Timed;
import io.astefanutti.metrics.aspectj.Metrics;
@Metrics(registry = "someMetrics")
public class TimedClass {
@Timed(name = "test")
public void doSomething() {
try {
Thread.sleep(200L);
} catch (InterruptedException e) {
}
System.out.println("Done");
}
@Timed(name = "test-random")
public void doSomething2() {
try {
Thread.sleep(ThreadLocalRandom.current().nextLong(100L));
} catch (InterruptedException e) {
}
System.out.println("Done");
}
}
应用程序:
package com.mycompany.app;
import java.util.concurrent.TimeUnit;
import com.codahale.metrics.ConsoleReporter;
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.SharedMetricRegistries;
public class App {
public static void main(String[] args) throws InterruptedException {
MetricRegistry metrics =
SharedMetricRegistries.getOrCreate("someMetrics");
ConsoleReporter.forRegistry(metrics)
.convertRatesTo(TimeUnit.SECONDS)
.convertDurationsTo(TimeUnit.MILLISECONDS)
.build()
.start(1, TimeUnit.SECONDS);
TimedClass c = new TimedClass();
for(int i = 0; i < 10; i++) {
c.doSomething();
c.doSomething2();
}
c.doSomething();
Thread.sleep(1010L);
}
}
这里发生的是,当编译时,方面的maven插件将找到您使用的注释并应用方面。
在你的情况下(和我的)例如来自metrics-aspect源的这个:
final aspect TimedAspect {
pointcut timed(Profiled object) : execution(@Timed !static * (@Metrics Profiled+).*(..)) && this(object);
Object around(Profiled object) : timed(object) {
String methodSignature = ((MethodSignature) thisJoinPointStaticPart.getSignature()).getMethod().toString();
Timer timer = object.timers.get(methodSignature).getMetric();
Timer.Context context = timer.time();
try {
return proceed(object);
} finally {
context.stop();
}
}
}
以上所做的就是说:
任何非静态且具有@Timed
注释的方法都应在“around”方法中执行。
现在,您可以通过执行以下操作来编译和打包:
mvn clean install package
这将为非应用方面打印一堆警告,但这完全没问题(我们实际上并没有使用它们)。
此外,你现在有一个包含你的应用程序的胖罐,你可以执行它来查看我们做了什么工作:
java -cp target/my-app-1.0-SNAPSHOT-jar-with-dependencies.jar com.mycompany.app.App
将打印:
artur@pdb-ct ~/dev/repo/my-app $ java -cp target/my-app-1.0-SNAPSHOT-jar-with-dependencies.jar com.mycompany.app.App
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Done
Done
Done
Done
Done
Done
Done
Done
04/01/18 15:10:42 ==============================================================
-- Timers ----------------------------------------------------------------------
com.mycompany.app.TimedClass.test
count = 4
mean rate = 4.11 calls/second
1-minute rate = 0.00 calls/second
5-minute rate = 0.00 calls/second
15-minute rate = 0.00 calls/second
min = 200.21 milliseconds
max = 200.37 milliseconds
mean = 200.29 milliseconds
stddev = 0.06 milliseconds
median = 200.25 milliseconds
75% <= 200.32 milliseconds
95% <= 200.37 milliseconds
98% <= 200.37 milliseconds
99% <= 200.37 milliseconds
99.9% <= 200.37 milliseconds
com.mycompany.app.TimedClass.test-random
count = 4
mean rate = 4.10 calls/second
1-minute rate = 0.00 calls/second
5-minute rate = 0.00 calls/second
15-minute rate = 0.00 calls/second
min = 20.41 milliseconds
max = 32.28 milliseconds
mean = 26.07 milliseconds
stddev = 4.56 milliseconds
median = 28.26 milliseconds
75% <= 32.28 milliseconds
95% <= 32.28 milliseconds
98% <= 32.28 milliseconds
99% <= 32.28 milliseconds
99.9% <= 32.28 milliseconds
Done
Done
Done
Done
Done
Done
Done
04/01/18 15:10:43 ==============================================================
-- Timers ----------------------------------------------------------------------
com.mycompany.app.TimedClass.test
count = 8
mean rate = 4.06 calls/second
1-minute rate = 0.00 calls/second
5-minute rate = 0.00 calls/second
15-minute rate = 0.00 calls/second
min = 200.16 milliseconds
max = 200.37 milliseconds
mean = 200.25 milliseconds
stddev = 0.06 milliseconds
median = 200.25 milliseconds
75% <= 200.26 milliseconds
95% <= 200.37 milliseconds
98% <= 200.37 milliseconds
99% <= 200.37 milliseconds
99.9% <= 200.37 milliseconds
com.mycompany.app.TimedClass.test-random
count = 7
mean rate = 3.55 calls/second
1-minute rate = 0.00 calls/second
5-minute rate = 0.00 calls/second
15-minute rate = 0.00 calls/second
min = 20.41 milliseconds
max = 97.20 milliseconds
mean = 43.68 milliseconds
stddev = 28.17 milliseconds
median = 28.26 milliseconds
75% <= 76.30 milliseconds
95% <= 97.20 milliseconds
98% <= 97.20 milliseconds
99% <= 97.20 milliseconds
99.9% <= 97.20 milliseconds
Done
Done
Done
Done
Done
Done
04/01/18 15:10:44 ==============================================================
-- Timers ----------------------------------------------------------------------
com.mycompany.app.TimedClass.test
count = 11
mean rate = 3.70 calls/second
1-minute rate = 0.00 calls/second
5-minute rate = 0.00 calls/second
15-minute rate = 0.00 calls/second
min = 200.13 milliseconds
max = 200.37 milliseconds
mean = 200.23 milliseconds
stddev = 0.07 milliseconds
median = 200.21 milliseconds
75% <= 200.26 milliseconds
95% <= 200.37 milliseconds
98% <= 200.37 milliseconds
99% <= 200.37 milliseconds
99.9% <= 200.37 milliseconds
com.mycompany.app.TimedClass.test-random
count = 10
mean rate = 3.37 calls/second
1-minute rate = 0.00 calls/second
5-minute rate = 0.00 calls/second
15-minute rate = 0.00 calls/second
min = 15.19 milliseconds
max = 97.20 milliseconds
mean = 48.90 milliseconds
stddev = 30.99 milliseconds
median = 32.28 milliseconds
75% <= 76.30 milliseconds
95% <= 97.20 milliseconds
98% <= 97.20 milliseconds
99% <= 97.20 milliseconds
99.9% <= 97.20 milliseconds
几点:
这在中在Eclipse中工作。你必须安装一个扩展才能使它工作(我没试过),见这里:
https://github.com/astefanutti/metrics-aspectj/blob/master/README.md
有关如何使用AJDT的说明:
https://www.ibm.com/developerworks/library/j-ajdt/
原因是(模糊,因为我没有花太多时间在这上面),方面是在编译时应用的,而不是在运行时。 Eclipse在IDE中运行时使用自己的编译器,因此它只执行您的代码。然后,您的pom文件中的maven插件在编译代码时应用了这些方面。
我希望有所帮助,
P.S。原谅我的命名/包装 - 我使用了默认的maven生成器
- Artur
跟进:
要添加dropwizard指标,如果要使用上述解决方案,只需将其添加到共享指标即可。例如:
MetricRegistry myCustomRegistry = new MetricRegistry();
SharedMetricRegistries.add("my-metric-registry", myCustomRegistry);
在您的情况下,这将来自environment().metrics()
或类似。
答案 1 :(得分:3)
您遇到的问题是,AspectJ建议使用的MetricRegistry
实例与您用于手动计量测试的实例和ConsoleReporter
不同。
由于您的问题没有指定@Inject
- ed MetricRegistry
实例的来源,我只能推测它与您使用的{ConsoleReporter
实例相同。 1}},但很可能是与AspectJ建议使用的"default"
注册表不同的实例。 AspectJ建议使用的那个是用
SharedMetricRegistries.getOrCreate("default");
为了解决您的问题,您应 :
通过使用您首选的依赖项注入框架,确保@Inject
- ed MetricRegistry
实例和environment.metrics()
返回的实例与SharedMetricRegistries.getOrCreate("default")
相同#39;使用工厂方法的方式(@Bean
用于Spring,@Produces
用于CDI)。
在Foo
类@Metrics
注释&{39} registry
值中使用EL表达式,如下所示:
@Metrics(registry = "${this.metricRegistry}")
为上面引用的metricRegistry
属性提供getter:
public MetricRegistry getMetricRegistry() {
return this.metricRegistry;
}
并确保您在项目中拥有所需的EL库:
<dependency>
<groupId>org.glassfish</groupId>
<artifactId>javax.el</artifactId>
<version>3.0.1-b09</version>
</dependency>