如何正确处理Promise.all:未定义

时间:2017-12-09 19:26:04

标签: javascript arrays node.js promise request

我正在尝试从一些对不同REST API的请求中获取一个填充了信息的数组。 我考虑使用Promise.all来做这件事,但由于某种原因,它会产生一个内部有一堆undefined的数组。

  

[未定义,未定义,未定义,未定义]

这是我的代码:

var _ = require("lodash");//Used exclusively to check if the result from the request is an object
var ccxt = require("ccxt");//External library used to make the requests

let pairs = ["ETH/EUR", "BTC/EUR", "LTC/EUR", "BCH/EUR"]; //Array on which the Promise.all is based

function test(p) {
  for (var i = 0; i < ccxt.exchanges.length; i++) { //Looping through all the rest APIs
    let exchange = new ccxt[ccxt.exchanges[i]](); //Defining each API to make the requests
    if (exchange.hasFetchOrderBook) {
      exchange //Beginning of the request
        .fetchOrderBook(p)
        .then(order => {
          if (_.isObject(order) && order.bids[0][1]) {
            let now = Math.floor(new Date());
            order.mkt = exchange.name;
            order.pair = p;
            order.ping = now - order.timestamp;
            return order; //Return the result of the request
          }
        })
        .catch(e => {});
    }
  }
}

Promise.all(pairs.map(test)) //Making the requests based on the Pairs Array
  .then(res => {
    console.log(res); //Logging the results ==> [undefined, undefined, undefined, undefined] for some reason...
  })
  .catch(e => {
    console.log(e);
  });

我知道正确地发出了请求,因为如果我在循环中调试{。{1}},我得到了正确的结果 - 记录时的结果示例:

order

所以我猜我正在处理的问题与函数的异步字符有关......但我不知道如何让它同步。 再次,只是为了澄清我的问题:目标是获得一个包含4种不同类型对象的数组(每对一对 - >数组),以便我可以对每个对象进行操作。 为了更清楚,这里是我想要实现的目标的说明:

{ bids: 
   [ [ 12009.52, 0.0468 ],
     [ 12008.5, 0.0227 ],
     [ 12007.48, 30.9321 ],
     [ 12006.46, 0.0537 ],
     [ 12005.45, 0.0157 ],
     [ 12004.43, 7.1659 ],
     [ 12003.41, 0.0164 ],
     [ 12002.39, 23.4159 ],
     [ 12001.38, 0.0284 ],
     [ 12000.36, 0.0132 ],
     [ 11999.34, 0.0194 ],
     [ 11998.33, 0.0034 ],
     [ 11997.31, 7.526 ],
     [ 2445.72, 34.075 ],
     [ 2445.17, 25.4842 ],
     [ 2444.96, 0.1118 ],
     [ 2444.75, 23.288 ],
     [ 2444, 0.0247 ],
     [ 2443.8, 0.192 ],
     [ 765.51, 0.0828 ] ],
  asks: 
   [ [ 12048.74, 2.523 ],
     [ 12049.77, 0.0159 ],
     [ 12050.79, 0.029 ],
     [ 12051.82, 0.0061 ],
     [ 12052.84, 0.0181 ],
     [ 12053.87, 0.0164 ],
     [ 12054.89, 0.0355 ],
     [ 12055.92, 0.0042 ],
     [ 13419.62, 0.0063 ],
     [ 13420.64, 0.0174 ],
     [ 13421.78, 0.0143 ],
     [ 13422.92, 0.026 ],
     [ 13424.06, 0.0055 ],
     [ 13425.2, 14.4552 ],
     [ 13426.23, 0.0065 ],
     [ 13427.25, 0.0057 ],
     [ 13428.39, 0.0147 ],
     [ 13429.53, 4.0375 ],
     [ 13430.56, 23.9541 ],
     [ 13431.58, 0.0137 ] ],
  timestamp: 1512845715447,
  datetime: '2017-12-09T18:55:15.447Z',
  mkt: 'LakeBTC',
  pair: 'BTC/EUR',
  ping: 0 }

为什么[ [ Object1, Object2, Object3, etc... ], [ Object1, Object2, Object3, etc... ], [ Object1, Object2, Object3, etc... ], [ Object1, Object2, Object3, etc... ] ] 在不等待请求结果的情况下返回数组?

我希望这很清楚!如果没有让我知道! :P

提前感谢您的帮助!

1 个答案:

答案 0 :(得分:2)

您的test函数 会返回undefined。您需要返回结果的承诺:

function test(p) {
  return Promise.all(ccxt.exchanges.map(api => { //Looping through all the rest APIs
//^^^^^^^^^^^^^^^^^^
    let exchange = new ccxt[api](); //Defining each API to make the requests
    if (exchange.hasFetchOrderBook) {
      return exchange //Beginning of the request
        .fetchOrderBook(p)
        .then(order => {
          if (_.isObject(order) && order.bids[0][1]) {
            let now = Math.floor(new Date());
            order.mkt = exchange.name;
            order.pair = p;
            order.ping = now - order.timestamp;
            return order; //Return the result of the request
          }
          // else undefined
        })
        .catch(e => {}); // undefined
    }
    // else undefined
  }));
}

undefined条件不适用或发生错误时,您的承诺仍然符合if