延迟后不调用async_write_some回调

时间:2017-11-16 14:19:53

标签: boost tcp callback boost-asio asyncsocket

在一秒睡眠后,我的async_write_some回调未被调用。如果我为每次写入启动io_service工作线程,为什么回调没有被调用?

标题

boost::system::error_code error_1;
boost::shared_ptr <boost::asio::io_service> io_service_1;
boost::shared_ptr <boost::asio::ip::tcp::socket> socket_1;

连接

void eth_socket::open_eth_socket (void)
{
    // 1. reset io services
    io_service_1.reset();
    io_service_1 = boost::make_shared <boost::asio::io_service> ();

    // 2. create endpoint
    boost::asio::ip::tcp::endpoint remote_endpoint(
        boost::asio::ip::address::from_string("10.0.0.3"), 
        socket_1_port
    );

    // 3. reset socket
    socket_1.reset(new boost::asio::ip::tcp::socket(*io_service_1));                

    // 4. connect socket
    socket_1->async_connect(remote_endpoint,
        boost::bind(
            &eth_socket::socket_1_connect_callback,
            this, boost::asio::placeholders::error
        )
    );

    // 5. start io_service_1 run thread after giving it work
    boost::thread t(boost::bind(&boost::asio::io_service::run, *&io_service_1));                
    return;
}

void eth_socket::write_data (std::string data)
{   
    // 1. check socket status
    if (!socket_1->is_open())
    {
        WARNING << "socket_1 is not open";
        throw -3;
    }

    // 2. start asynchronous write
    socket_1->async_write_some(
        boost::asio::buffer(data.c_str(), data.size()),
        boost::bind(
            &eth_socket::socket_1_write_data_callback,
            this, boost::asio::placeholders::error, 
            boost::asio::placeholders::bytes_transferred
        )
    );

    // 3. start io_service_1 run thread after giving it work
    boost::thread t(boost::bind(&boost::asio::io_service::run, *&io_service_1));
    return;
}

回调

void eth_socket::socket_1_write_data_callback (const boost::system::error_code& error, size_t bytes_transferred)
{
    // 1. check for errors
    if (error) 
    {
        ERROR << "error.message() >> " << error.message().c_str();
        return;
    }
    if (socket_1.get() == NULL || !socket_1->is_open())
    {
        WARNING << "serial_port_1 is not open";
        return;
    }
    INFO << "data written to 10.0.0.3:1337 succeeded; bytes_transferred = " << bytes_transferred;
    return;
}

测试

open_eth_socket();
write_data("Hello");    // callback called
write_data("Hello");    // callback called
write_data("Hello");    // callback called
sleep(1);
write_data("Hello");    // callback not called after sleep

2 个答案:

答案 0 :(得分:1)

boost::thread t(boost::bind(&boost::asio::io_service::run, *&io_service_1));                

由于种种原因,这很奇怪。

我添加了这些顶级问题

  • 使用像socket_1这样的名称的气味(只需将其称为socket_并使用描述性名称实例化另一个对象以包含另一个socket_)。我不确定,但这个问题确实引起了怀疑,甚至可能是全局变量。 (我希望事实并非如此)
  • throw - 原始整数,真的吗?
  • 通过破坏io_service而从未检查工作线程是否已完成,您正冒着数据争用的风险。
  • 此处有更多Undefined Behaviour

    _sock.async_write_some(
            ba::buffer(data.c_str(), data.size()),
    

    您传递对超出范围的参数data的引用。当异步操作完成时,它将是一个悬空引用

  • 这里有一些明显的复制/粘贴问题:

    if (socket_1.get() == NULL || !socket_1->is_open())
    {
        WARNING << "serial_port_1 is not open";
        return;
    }
    

    我实际上说这源于导致变量名为serial_port_1socket_1

  • 的完全相同的来源

一些清理

简化。没有自包含的代码,所以这里没有完成,但至少看到了许多简化点:

Live On Coliru

#include <boost/asio.hpp>
#include <boost/thread.hpp>
#include <iostream>

namespace ba = boost::asio;
using ba::ip::tcp;
using boost::system::error_code;

#define ERROR   std::cerr
#define WARNING std::cerr
#define INFO    std::cerr

struct eth_socket {

    ~eth_socket() {
        _work.reset();
        if (_worker.joinable())
            _worker.join(); // wait
    }

    void open(std::string address);
    void write_data(std::string data);

  private:
    void connected(error_code error) {
        if (error)
            ERROR << "Connect failed: " << error << "\n";
        else
            INFO << "Connected to " << _sock.remote_endpoint() << "\n";
    }
    void written(error_code error, size_t bytes_transferred);

  private:
    ba::io_service _svc;
    boost::optional<ba::io_service::work> _work{ _svc };
    boost::thread _worker{ [this] { _svc.run(); } };

    std::string _data;

    unsigned short _port = 6767;
    tcp::socket _sock{ _svc };
};

void eth_socket::open(std::string address) {
    tcp::endpoint remote_endpoint(ba::ip::address::from_string(address), _port);

    _sock.async_connect(remote_endpoint, boost::bind(&eth_socket::connected, this, _1));
}

void eth_socket::write_data(std::string data) {
    _data = data;

    _sock.async_write_some(ba::buffer(_data), boost::bind(&eth_socket::written, this, _1, _2));
}

void eth_socket::written(error_code error, size_t bytes_transferred) {
    INFO << "data written to " << _sock.remote_endpoint() << " " << error.message() << ";"
         << "bytes_transferred = " << bytes_transferred << "\n";
}

int main() {
    {
        eth_socket s;
        s.open("127.0.0.1");

        s.write_data("Hello"); // callback called
        s.write_data("Hello"); // callback called
        s.write_data("Hello"); // callback called
        boost::this_thread::sleep_for(boost::chrono::seconds(1));
        s.write_data("Hello"); // callback not called after sleep

    } // orderly worker thread join here
}

答案 1 :(得分:0)

由于sehe的帮助和祈祷,我的问题现在已经解决了。

open_eth_socket中的这一行:

boost::thread t(boost::bind(&boost::asio::io_service::run, *&io_service_1));

现在是这样的:

boost::shared_ptr <boost::thread>  io_service_1_thread;    // in header

if (io_service_1_thread.get()) io_service_1_thread->interrupt();
io_service_1_thread.reset(new boost::thread (boost::bind(&eth_socket::run_io_service_1, this)));

我添加了这个功能:

void eth_socket::run_io_service_1 (void)
{
  while (true)  // work forever
  {
    boost::asio::io_service::work work(*io_service_1);
    io_service_1->run();
    io_service_1->reset();   // not sure if this will cause problems yet
    INFO << "io_service_1 run complete";
    boost::this_thread::sleep (boost::posix_time::milliseconds (100));
  }

    return;
}