Question

我是Rails的新手，我可能会遗漏一些非常基本的东西：

用户可以为公司的分支机构和部门创建联系

Branch.rb

public function getRouteKeyName()
{
    return 'product_id';
}

Division.rb

class Branch < ApplicationRecord
    belongs_to :company
    has_many :contacts
end

Contact.rb

class Division < ApplicationRecord
    belongs_to :company
    has_many :contacts
end

现在，用户可以从没有division_id的分支页面创建联系人，并且可以从分部页面创建联系人。

我已经定义了我的routes.rb：

的routes.rb

class Contact < ApplicationRecord
    belongs_to :branch
    belongs_to :division
end

因此，如果我从分支或分部创建联系人，则转到联系人#create方法。

在我的contacts_controller.rb中，我有：

resources :companies, :shallow => true do
    get 'company_page'
    resources :branches, :shallow => true do
        get 'branch_page'
        resources :contacts
    end 
    resources :divisions, :shallow => true do
        get 'division_page'
        resources :contacts
    end 
end

但我在def create @newContact = Contact.new(contact_params) id = @division = @branch = nil isBranch = false if params[:branch_id] != nil isBranch = true id = params[:branch_id] else isBranch = false id = params[:division_id] end if isBranch branch = Branch.find(id) @newContact.branch = branch @branch = branch else division = Division.find(id) @newContact.division = division @division = division end respond_to do |format| if @newContact.save format.js format.html { render :nothing => true, :notice => 'Contact created successfully!' } format.json { render json: @newContact, status: :created, location: @newContact } else format.html { render action: "new" } format.json { render json: @newContact, status: :unprocessable_entity } end end end期间面临ActiveRecord Error。

我确信我在做一些根本上非常错误的事情，Rails以另一种我不知道的优雅方式处理这些事情。

Answer 1

正如@Anthony指出的那样，您需要将belongs_to个关联设为可选：

# app/models/contact.rb

class Contact < ApplicationRecord
  belongs_to :branch, optional: true
  belongs_to :division, optional: true
end

但另一个问题是params[:division_id]和params[:branch_id]总是为零。这两个密钥都存在于[:contact]密钥内。所以你得到的错误应该是ActiveRecord::RecordNotFound: Couldn't find Division with 'id'=

所有条件逻辑都是不必要的。您可以与任何给定的参数进行新的联系。此外，您应该使用Ruby约定来进行变量命名，它是snake_case而不是camelCase。

最后，我假设您希望将HTML请求重定向到分支或分区显示页面，具体取决于哪些相关联。所以我已经添加了逻辑来做到这一点。

以下是控制器#create操作的快速重构：

  def create
    @new_contact = Contact.new(contact_params)

    if @new_contact.save
      branch = @new_contact.branch
      division = @new_contact.division
      redirect_path = branch ? branch_path(branch) : division_path(division)

      respond_to do |format|
        format.js
        format.html { redirect_to redirect_path, :notice => 'Contact created successfully!' }
        format.json { render json: @new_contact, status: :created, location: @new_contact }
      end
    else
      respond_to do |format|
        format.html { render action: "new" }
        format.json { render json: @new_contact, status: :unprocessable_entity }
      end
    end
  end

这证明它有效：

# spec/controllers/contacts_controller_spec.rb

require 'rails_helper'

RSpec.describe ContactsController, type: :controller do
  let(:company) { Company.create!(name: 'Company Name') }
  let(:division) { Division.create!(name: 'Division Name', company: company) }
  let(:branch) { Branch.create!(name: 'Branch Name', company: company) }

  describe '#create' do
    context 'when created with a division id' do
      let(:attributes) { {'division_id' => division.id, 'name' => 'Contact Name'} }

      it 'creates a contact record and associates it with the division' do
        expect(Contact.count).to eq(0)
        post :create, params: {contact: attributes}

        expect(Contact.count).to eq(1)
        contact = Contact.first
        expect(contact.division).to eq(division)
      end
    end

    context 'when created with a branch id' do
      let(:attributes) { {'branch_id' => branch.id, 'name' => 'Contact Name'} }

      it 'creates a contact record and associates it with the branch' do
        expect(Contact.count).to eq(0)
        post :create, params: {contact: attributes}

        expect(Contact.count).to eq(1)
        contact = Contact.first
        expect(contact.branch).to eq(branch)
      end
    end
  end
end

适用于许多模型Rails的模型的CRUD方法

1 个答案: