当其中一个来自cin时,无法比较两个字符串。这有什么不对?

时间:2017-10-09 18:14:15

标签: c++ string

void Display::getInput(){
  cout << endl << endl << "Enter Command: ";
  char input[MAX_LENGTH];
  cin >> input;

  if (input == "start"){
    startMenu();
  }

我收到此错误但我不确定为什么因为我总能用这种语法进行比较..

  

Display.cpp:在成员函数'void Display :: getInput()':

中      

Display.cpp:20:16:警告:与字符串文字结果比较   未指明的行为[-Waddress] if(input ==&#34; start&#34;){

2 个答案:

答案 0 :(得分:4)

要比较C风格的字符串,您需要使用$ ssh -i privateKey.pem ubuntu@ec2-XXX-XXX-XXX-XXX.us-west-1.compute.amazonaws.com -vvv OpenSSH_7.5p1, LibreSSL 2.5.4 debug1: Reading configuration data /Users/USERNAME/.ssh/config debug1: Reading configuration data /etc/ssh/ssh_config debug1: /etc/ssh/ssh_config line 52: Applying options for * debug2: resolving "ec2-XXX-XXX-XXX-XXX.us-west-1.compute.amazonaws.com" port 22 debug2: ssh_connect_direct: needpriv 0 debug1: Connecting to ec2-XXX-XXX-XXX-XXX.us-west-1.compute.amazonaws.com [XXX-XXX-XXX-XXX] port 22. debug1: Connection established. debug1: key_load_public: No such file or directory debug1: identity file privateKey.pem type -1 debug1: key_load_public: No such file or directory debug1: identity file privateKey.pem-cert type -1 debug1: Enabling compatibility mode for protocol 2.0 debug1: Local version string SSH-2.0-OpenSSH_7.5 debug1: Remote protocol version 2.0, remote software version OpenSSH_5.8p1 Debian-1ubuntu3 debug1: match: OpenSSH_5.8p1 Debian-1ubuntu3 pat OpenSSH_5* compat 0x0c000000 debug2: fd 5 setting O_NONBLOCK debug1: Authenticating to ec2-XXX-XXX-XXX-XXX.us-west-1.compute.amazonaws.com:22 as 'ubuntu' debug3: hostkeys_foreach: reading file "/Users/USERNAME/.ssh/known_hosts" debug3: record_hostkey: found key type RSA in file /Users/USERNAME/.ssh/known_hosts:3 debug3: load_hostkeys: loaded 1 keys from ec2-XXX-XXX-XXX-XXX.us-west-1.compute.amazonaws.com debug3: order_hostkeyalgs: prefer hostkeyalgs: ssh-rsa-cert-v01@openssh.com,rsa-sha2-512,rsa-sha2-256,ssh-rsa debug3: send packet: type 20 debug1: SSH2_MSG_KEXINIT sent debug3: receive packet: type 20 debug1: SSH2_MSG_KEXINIT received debug2: local client KEXINIT proposal debug2: KEX algorithms: curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group-exchange-sha1,diffie-hellman-group14-sha256,diffie-hellman-group14-sha1,ext-info-c debug2: host key algorithms: ssh-rsa-cert-v01@openssh.com,rsa-sha2-512,rsa-sha2-256,ssh-rsa,ecdsa-sha2-nistp256-cert-v01@openssh.com,ecdsa-sha2-nistp384-cert-v01@openssh.com,ecdsa-sha2-nistp521-cert-v01@openssh.com,ssh-ed25519-cert-v01@openssh.com,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,ssh-ed25519 debug2: ciphers ctos: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm@openssh.com,aes256-gcm@openssh.com,aes128-cbc,aes192-cbc,aes256-cbc debug2: ciphers stoc: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm@openssh.com,aes256-gcm@openssh.com,aes128-cbc,aes192-cbc,aes256-cbc debug2: MACs ctos: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 debug2: MACs stoc: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 debug2: compression ctos: none,zlib@openssh.com,zlib debug2: compression stoc: none,zlib@openssh.com,zlib debug2: languages ctos: debug2: languages stoc: debug2: first_kex_follows 0 debug2: reserved 0 debug2: peer server KEXINIT proposal debug2: KEX algorithms: ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group-exchange-sha1,diffie-hellman-group14-sha1,diffie-hellman-group1-sha1 debug2: host key algorithms: ssh-rsa,ssh-dss debug2: ciphers ctos: aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cbc,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,rijndael-cbc@lysator.liu.se debug2: ciphers stoc: aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cbc,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,rijndael-cbc@lysator.liu.se debug2: MACs ctos: hmac-md5,hmac-sha1,umac-64@openssh.com,hmac-ripemd160,hmac-ripemd160@openssh.com,hmac-sha1-96,hmac-md5-96 debug2: MACs stoc: hmac-md5,hmac-sha1,umac-64@openssh.com,hmac-ripemd160,hmac-ripemd160@openssh.com,hmac-sha1-96,hmac-md5-96 debug2: compression ctos: none,zlib@openssh.com debug2: compression stoc: none,zlib@openssh.com debug2: languages ctos: debug2: languages stoc: debug2: first_kex_follows 0 debug2: reserved 0 debug1: kex: algorithm: ecdh-sha2-nistp256 debug1: kex: host key algorithm: ssh-rsa debug1: kex: server->client cipher: aes128-ctr MAC: umac-64@openssh.com compression: none debug1: kex: client->server cipher: aes128-ctr MAC: umac-64@openssh.com compression: none debug3: send packet: type 30 debug1: sending SSH2_MSG_KEX_ECDH_INIT debug1: expecting SSH2_MSG_KEX_ECDH_REPLY debug3: receive packet: type 31 debug1: Server host key: ssh-rsa SHA256:y6JMkm+4kp5sV9GLZYj0xUKIVSiUXBktG9MxyfnDmxI debug3: hostkeys_foreach: reading file "/Users/USERNAME/.ssh/known_hosts" debug3: record_hostkey: found key type RSA in file /Users/USERNAME/.ssh/known_hosts:3 debug3: load_hostkeys: loaded 1 keys from ec2-184-169-151-249.us-west-1.compute.amazonaws.com debug3: hostkeys_foreach: reading file "/Users/USERNAME/.ssh/known_hosts" debug3: record_hostkey: found key type RSA in file /Users/USERNAME/.ssh/known_hosts:3 debug3: load_hostkeys: loaded 1 keys from 184.169.151.249 debug1: Host 'ec2-XXX-XXX-XXX-XXX.us-west-1.compute.amazonaws.com' is known and matches the RSA host key. debug1: Found key in /Users/USERNAME/.ssh/known_hosts:3 debug3: send packet: type 21 debug2: set_newkeys: mode 1 debug1: rekey after 4294967296 blocks debug1: SSH2_MSG_NEWKEYS sent debug1: expecting SSH2_MSG_NEWKEYS debug3: receive packet: type 21 debug1: SSH2_MSG_NEWKEYS received debug2: set_newkeys: mode 0 debug1: rekey after 4294967296 blocks debug2: key: privateKey.pem (0x0), explicit debug3: send packet: type 5 debug3: receive packet: type 6 debug2: service_accept: ssh-userauth debug1: SSH2_MSG_SERVICE_ACCEPT received debug3: send packet: type 50 debug3: receive packet: type 51 debug1: Authentications that can continue: publickey debug3: start over, passed a different list publickey debug3: preferred publickey,keyboard-interactive,password debug3: authmethod_lookup publickey debug3: remaining preferred: keyboard-interactive,password debug3: authmethod_is_enabled publickey debug1: Next authentication method: publickey debug1: Trying private key: privateKey.pem debug3: sign_and_send_pubkey: RSA SHA256:lbgZZp6+4mYEkpoSzvdzajq0K/c5tIm83noZ6ZDL5hE debug3: send packet: type 50 debug2: we sent a publickey packet, wait for reply debug3: receive packet: type 51 debug1: Authentications that can continue: publickey debug2: we did not send a packet, disable method debug1: No more authentication methods to try. Permission denied (publickey). 。否则,将strcmp更改为字符串(input)而不是字符数组。您正在比较两个指针,其中一个指向文字,另一个指向数组,因此它们永远不会相等。

答案 1 :(得分:2)

您不能比较那样的C风格字符串,而是使用strcmp来比较成功时返回0和失败时返回非零。

或者您可以使用课程string

int main(){
    char szInput[100];
    std::cin.getline(szInput, 100);

    const char* szTest = "Hello";

    if(!strcmp(szInput, szTest))
        std::cout << "Identical" << std::endl;
    else
        std::cout << "Not identical" << std::endl;


    std::string sInput;
    std::getline(std::cin, sInput); // getline for white-spaces

    std::string sTest = "Welcome there!";

    if(sTest == sInput)
        std::cout << "Identical" << std::endl;
    else
        std::cout << "Not identical" << std::endl;

    return 0;
}
  • 我使用getline代替cin来获取计数空格字符。