一段时间后,javamail idle停止触发messagesAdded,线程被锁定

时间:2017-10-08 01:38:04

标签: multithreading javamail wait monitor noop

我正在开发一个接收和处理邮件消息的Android应用程序。应用程序必须连接到IMAP服务器并保持连接活动,以便它可以立即查看和处理新邮件(邮件包含来自邮件api服务器的json数据)。该应用程序有两种模式,手动和实时连接。以下是我的一些代码:

class Idler {
Thread th;
volatile Boolean isIdling=false;
boolean shouldsync=false;//we need to see if we have unseen mails
Object idleLock;
Handler handler=new Handler();
IMAPFolder inbox;
public boolean keppAliveConnection;//keep alive connection, or manual mode

//This thread should keep the idle connection alive, or in case it's set to manual mode (keppAliveConnection=false) get new mail.
Thread refreshThread;
synchronized void refresh()
{
    if(isIdling)//if already idling, just keep connection alive
    {
        refreshThread =new Thread(new Runnable() {
            @Override
            public void run() {
                try {
                    inbox.doCommand(new IMAPFolder.ProtocolCommand() {
                        @Override
                        public Object doCommand(IMAPProtocol protocol) throws ProtocolException {
                            //Why not noop?
                            //any call to IMAPFolder.doCommand() will trigger waitIfIdle, this
                            //issues a "DONE" command and waits for idle to return(ideally with a DONE server response).
                            // So... I think NOOP is unnecessary
                            //protocol.simpleCommand("NOOP",null); I'm not issuing noop due to what I said ^

                            //PD: if connection was broken, then server response will never arrive, and idle will keep running forever
                            //without triggering messagesAdded event any more :'( I see any other explanation to this phenomenon


                            return null;
                        }
                    });
                } catch (MessagingException e) {
                    e.printStackTrace();
                }
            }
        },"SyncThread");
        refreshThread.start();
    }
    else
    {
        getNewMail();//If manual mode keppAliveConnection=false) get the new mail
    }
}
public Idler()
{
    th=new Thread(new Runnable() {

        @SuppressWarnings("InfiniteLoopStatement")
        @Override
        public void run() {
            while (true)
            {
                try {
                    if(refreshThread !=null && refreshThread.isAlive())
                        refreshThread.interrupt();//if the refresher thread is active: interrupt. I thing this is not necessary at this point, but not shure
                    initIMAP();//initializes imap store
                    try {
                        shouldsync=connectIMAP()||shouldsync;//if was disconnected or ordered to sync: needs to sync
                    }
                    catch (Exception e)
                    {
                        Thread.sleep(5000);//if can't connect: wait some time and throw
                        throw e;
                    }
                    shouldsync=initInbox()||shouldsync;//if inbox was null or closed: needs to sync
                    if(shouldsync)//if needs to sync
                    {
                        getNewMail();//gets new unseen mail
                        shouldsync=false;//already refreshed, clear sync "flag"
                    }

                    while (keppAliveConnection) {//if sould keep idling "forever"
                        synchronized (idleLock){}//MessageCountListener may be doing some work... wait for it
                        isIdling = true; //set isIdling "flag"
                        handler.removeCallbacksAndMessages(null);//clears refresh scheduled tasks
                        handler.postDelayed(new Runnable() {
                            @Override
                            public void run() {
                                refresh();
                            }
                        },1200000);//Schedule a refresh in 20 minutes
                        inbox.idle();//start idling
                        if(refreshThread !=null && refreshThread.isAlive())
                            refreshThread.interrupt();//if the refresher thread is active: interrupt. I thing this is not necessary at this point, but not shure
                        handler.removeCallbacksAndMessages(null);//clears refresh scheduled tasks
                        isIdling=false;//clear isIdling "flag"
                        if(shouldsync)
                            break;//if ordered to sync... break. The loop will handle it upstairs.
                        synchronized (idleLock){}//MessageCountListener may be doing some work... wait for it

                    }
                }
                catch (Exception e) {
                    //if the refresher thread is active: interrupt
                    //Why interrupt? refresher thread may be waiting for idle to return after "DONE" command, but if folder was closed and throws
                    //a FolderClosedException, then it could wait forever...., so... interrupt.
                    if (refreshThread != null && refreshThread.isAlive())
                        refreshThread.interrupt();
                    handler.removeCallbacksAndMessages(null);//clears refresh scheduled tasks
                }
            }
        }
    },"IdlerThread");
    th.start();
}

private synchronized void getNewMail()
{
    shouldsync=false;
    long uid=getLastSeen();//get last unprocessed mail
    SearchTerm searchTerm=new UidTerm(uid,Long.MAX_VALUE);//search from las processed message to the las one.
    IMAPSearchOperation so=new IMAPSearchOperation(searchTerm);
    try {
        so.run();//search new messages
        final long[] is=so.uids();//get unprocessed messages count
        if (is.length > 0) {//if some...
            try {
                //there are new messages
                IMAPFetchMessagesOperation fop=new IMAPFetchMessagesOperation(is);
                fop.run();//fetch new messages
                if(fop.messages.length>0)
                {
                    //process fetched messages (internally sets the last seen uid value & delete some...)
                    processMessages(fop.messages);
                }
                inbox.expunge();//expunge deleted messages if any
            }
            catch (Exception e)
            {
                //Do something
            }
        }
        else
        {
            //Do something
        }
    }
    catch (Exception e)
    {
        //Do something
    }
}


private synchronized void initIMAP()
{
    if(store==null)
    {
        store=new IMAPStore(mailSession,new URLName("imap",p.IMAPServer,p.IMAPPort,null,p.IMAPUser,p.IMAPPassword));
    }
}

private boolean connectIMAP() throws MessagingException {
    try {
        store.connect(p.IMAPServer, p.IMAPPort, p.IMAPUser, p.IMAPPassword);
        return true;
    }
    catch (IllegalStateException e)
    {
        return false;
    }
}

//returns true if the folder was closed or null
private synchronized boolean initInbox() throws MessagingException {
    boolean retVal=false;
    if(inbox==null)
    {//if null, create. This is called after initializing store
        inbox = (IMAPFolder) store.getFolder("INBOX");
        inbox.addMessageCountListener(countListener);
        retVal=true;//was created
    }
    if(!inbox.isOpen())
    {
        inbox.open(Folder.READ_WRITE);
        retVal=true;//was oppened
    }
    return retVal;
}

private MessageCountListener countListener= new MessageCountAdapter() {
    @Override
    public void messagesAdded(MessageCountEvent ev) {
        synchronized (idleLock)
        {
            try {
                processMessages(ev.getMessages());//process the new messages, (internally sets the last seen uid value & delete some...)
                inbox.expunge();//expunge deleted messajes if any
            } catch (MessagingException e) {
                //Do something
            }

        }
    }
};

}

问题是:有时当用户刷新或应用程序自动刷新时,在Alive Connection模式下,这些条件中的一个或两个都会阻止我的应用获取新消息。这是来自javamail的源代码。

1:IdlerThread在以下位置进入监视状态:

//I don't know why sometimes it enters monitor state here.
private synchronized void throwClosedException(ConnectionException cex) 
        throws FolderClosedException, StoreClosedException {
// If it's the folder's protocol object, throw a FolderClosedException;
// otherwise, throw a StoreClosedException.
// If a command has failed because the connection is closed,
// the folder will have already been forced closed by the
// time we get here and our protocol object will have been
// released, so if we no longer have a protocol object we base
// this decision on whether we *think* the folder is open.
if ((protocol != null && cex.getProtocol() == protocol) ||
    (protocol == null && !reallyClosed))
        throw new FolderClosedException(this, cex.getMessage());
    else
        throw new StoreClosedException(store, cex.getMessage());
}

2:“refresherThread”进入等待状态:

  void waitIfIdle() throws ProtocolException {
assert Thread.holdsLock(messageCacheLock);
while (idleState != RUNNING) {
    if (idleState == IDLE) {
    protocol.idleAbort();
    idleState = ABORTING;
    }
    try {
    // give up lock and wait to be not idle
    messageCacheLock.wait();//<-----This is the line is driving me crazy.
    } catch (InterruptedException ex) { }
}
}

当其中一个线程“停止”运行(等待和监视状态)时,我的应用程序在达到此条件时无用。在我的国家,移动数据网络非常不稳定,速度慢,而且昂贵的(GSM)因此它必须具有故障恢复能力,并注意每个传输的位。

我想当连接无声地失败并且refresherThread开始完成其工作时会出现问题。如果空闲处于活动状态,它会发出DONE命令,但是,当连接消失时,当空闲尝试抛出FolderClosedException时,一个或两个线程将无限期地锁定。

所以,我的问题是:为什么会出现这种情况以及如何预防?如何在不锁定的情况下保持空闲循环安全运行?

我已经尝试了很多事情,直到筋疲力尽没有结果。

以下是我读过的一些帖子,但未解决我的问题。在我的国家互联网也非常昂贵,所以我不能研究我想要的,也没有列出我访问过的所有网址寻找信息。

JavaMail: Keeping IMAPFolder.idle() alive

JavaMail: Keeping IMAPFolder.idle() alive

Javamail : Proper way to issue idle() for IMAPFolder

请原谅我的英语。任何建议将不胜感激。我听说这个网站严格,所以请温柔,我是新来的。

1 个答案:

答案 0 :(得分:0)

请务必设置timeout properties,以确保您不会等待死连接或服务器挂起。

您应该调用Folder.isOpen或Folder.getMessageCount,而不是直接发出nop命令;如果需要,他们会发出nop命令。

如果文件夹异步关闭(FolderClosedException),则需要重新启动空闲循环。