问题与回调函数 - javascript / node.js

时间:2017-09-04 08:06:31

标签: javascript node.js

我制作投票应用程序,现在我尝试检查用户是否已投票给当前的投票。 我的问题我认为是一个回调函数,在我想要的时间内不起作用。 我尝试了很多方法并阅读了很多关于回调和同步功能的内容,但仍然不知道如何解决这个问题。
现在代码(所有在同一路线上):

在这里,我找到用户投票的民意调查:

Poll.findById(req.params.id,function(err, poll){     //Find the Poll
       if(err){
           console.log("Vote(find the Poll) post err");
        }
        var test = function(poll,req){                            //check if user already vote to the poll
                if(req.user.local){//if it`s auth user
                    console.log("test");
                    User.findById(req.user._id,function(err, userFound){
                        if(err){
                            console.log("[checkVoted] Error findById");
                        }
                    for(var i=0;i<userFound.local.vote.poll_voted.length;i++){//run on poll_voted array
                        console.log("test for");
                        if(poll._id == userFound.local.vote.poll_voted[i]){
                            console.log("**return 1**");
                            return 1;//User already voted to this poll
                        }
                    }//end for
                    console.log("test return 0");
                    return 0;//user not voted
                    });//end user find
                } else{ //anonmey user 
                    console.log("[checkVoted] ELSE!");
                    return false;
                }//else end
            };//function end

我在这里打电话给测试功能后:

 **if(test(poll,req))**{ //If user already voted, redirect
                console.log("already vote");
                res.redirect("/poll/"+poll._id);
            }**else**{//User not voted. 
                console.log("test Else not voted");
                User.findById(req.user._id, function(err, user) {//find the id and save in voted poll
                    if(err){
                        console.log("[VOTE>POST>User.findByID ERROR");
                    } else{
                        user.local.vote.poll_voted.push(poll._id); 
                        user.save(function(err){
                        if(err){
                            console.log("save user._id in poll_voted ERORR");
                        }});
                    }});//end User.findById
                var options = poll.options;
                var optionIndex = _.findIndex(options,["id", req.params.option_id]);
                poll.options[optionIndex].vote++;
                poll.save(function(err){
                if(err){
                   console.log("save vote error");
                } else{
                   res.redirect("/poll/"+poll._id);
                }
            });
        }//end of else
    });//end of Poll findById

现在用户选择选项并进行投票,其输入功能并记录“返回1”(已标记),但它不会输入到IF(已标记)并且不能输入其他(makred)...我是什么做错了吗?

修改 我尝试这种方法,从日志它的工作,但我现在有antoher错误: 编辑2:已解决。这段代码:(全部谢谢)

router.post("/poll/:id/:option_id", function(req, res){
   Poll.findById(req.params.id,function(err, poll){     //Find the Poll
       if(err){
           console.log("Vote(find the Poll) post err");
        }
        var test = function(poll,req, callback){
                var flag=0;
                if(req.user.local){//if it`s auth user
                    console.log("test");
                    User.findById(req.user._id,function(err, userFound){//look for id user
                        if(err){
                            console.log("[checkVoted] Error findById");
                            }
                        for(var i=0;i<userFound.local.vote.poll_voted.length;i++){//runnig on poll_voted array
                            console.log("test for");
                            if(poll._id == userFound.local.vote.poll_voted[i]){
                                console.log("**return 1**");
                                flag=1;//User already voted to this poll
                            }
                        }{//end for
                    console.log("test return 0");
                    callback(flag);
                    }});//end user find
                }//end if auth user
            };//test function end
            test(poll, req, function(param){
                if(param){
                    console.log("already vote");
                    res.redirect("/poll/"+poll._id);
                } else{
                    console.log("test Else not voted");
                    User.findById(req.user._id, function(err, user) {//find the id and save in voted poll
                        console.log("user findbyid succes");
                        if(err){
                            console.log("[VOTE>POST>User.findByID ERROR");
                        } else{
                            console.log("user findbyid succes else");
                            user.local.vote.poll_voted.push(poll._id); 
                            user.save(function(err){
                                if(err){
                                console.log("save user._id in poll_voted ERORR");
                            }});
                    }});//end User.findById
                    console.log("user save the vote start");
                    var options = poll.options;
                    var optionIndex = _.findIndex(options,["id", req.params.option_id]);
                    poll.options[optionIndex].vote++;
                    poll.save(function(err){
                    if(err){
                        console.log("save vote error");
                    } else{
                        console.log("user save the vote finsh");
                        res.redirect("/poll/"+poll._id);
                    }});
                }});
            });
});
Error: Can't set headers after they are sent

1 个答案:

答案 0 :(得分:1)

test(poll,req)是一个同步函数,但在其中有一个函数User.findById(req.user)的异步引用。一种选择是传递回调函数


    test(poll,req, function(param){
        ... process return values from callback
        .... if case validations
    })

并在

中调用它

    var test = function(poll,req, cb){  
        User.findById(req.user._id,function(err, userFound){
            if(err){
                console.log("[checkVoted] Error findById");
            }
            ...for loop
            cb(param)
        }
    }