Question

好吧，我已经定义了2个互斥锁：bar_mutex（在N条线程之间使用）和writer_mutex（在条形线程中用于观察者线程）。编写器互斥体被用于避免变量k_total 的奇怪值，我在那里修改一个全局变量但在某些特定时刻变量变为0.0而另一个线程使用该值。 为了避免我添加了writer_mutex但问题仍然存在。我究竟做错了什么？我将粘贴代码的重要部分。

if (k_total < 1 && b->cm <=20) {
    b->cm = b->cm + 10; //Usando este valor calculamos el deltak
    /* printf("\nThread yendo hacia abajo\n"); */
    if (b->direction == UP) {
        b->direction = DOWN;
        changed_direction = true;
    } else {
        changed_direction = false;
    }
} else if(k_total > 1 && b->cm >=-20) {
    b->cm = b->cm - 10; //Usando este valor calculamos el deltak
    /* printf("\nThread yendo hacia arriba\n"); */
    if (b->direction == DOWN) {
        b->direction = UP;
        changed_direction = true;
    } else {
        changed_direction = false;
    }
}

在函数move_bar的这部分中，k_total取0而不是正确的价值......为了避免这种我添加了writer_mutex，但它仍然无法正常工作

在这里你可以看到全局变量ktotal在某些中被发送为0 我...我试图避免这种情况。

我将附加代码的主要部分。

void
start_threads(struct bar* bars) {
    int i;
    pthread_t threads[NUM_THREADS + 1];
    bars = (struct bar*)malloc(sizeof(struct bar) * NUM_THREADS);
    init_variables();
    pthread_mutex_init(&bar_mutex, NULL);
    pthread_mutex_init(&write_mutex, NULL);
    pthread_cond_init(&unstable_state, NULL);

    for (i = 1; i < NUM_THREADS + 1; i++) {
        fill_bar(&bars[i - 1], i);
    }

    pthread_attr_init(&attr);
    pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_JOINABLE);
    // creating the 4 threads that handle each bar
    for (i = 0; i < NUM_THREADS; i++) {
        pthread_create(&threads[i], &attr, move_bar, (void *)&bars[i]);
    }
    //thread used to check if system is stable and change its k_total
    pthread_create(&threads[NUM_THREADS], &attr, check_stable, (void*)bars);

    /* Wait for all threads to complete */
    for (i=0; i<NUM_THREADS + 1; i++) {
        pthread_join(threads[i], NULL);
    }
}

void*
check_stable(void* bars) {
    struct bar* wires = (struct bar*) bars ;
    while (true) {
        pthread_mutex_lock(&write_mutex);
        k_total = 0.0;
        for (int i = 0; i < NUM_THREADS; ++i) {
            k_total += getDeltaKValue(wires[i].cm);
        }

        char str[25];
        sprintf(str,"deltak=%lf", k_total);
        doPost("deltak",str);

        k_total = k_value + k_total;

        sprintf(str,"kparcial=%lf",k_value);
        doPost("kparcial",str);
        sprintf(str,"ktotal=%lf", k_total);
        doPost("ktotal",str);
        if ((double)k_total != (double)1.0) {
            unbalanced = true;
            pthread_cond_signal(&unstable_state);
        } else {
            unbalanced = false;
        }
        pthread_mutex_unlock(&write_mutex);
        sleep(1);
    }
}

void*
move_bar(void *bar) {
    struct bar* b = (struct bar*) bar;
    clock_t start = clock();
    bool changed_direction = false;
    while (true) {
        pthread_mutex_lock(&bar_mutex);
        while (unbalanced == false)
            pthread_cond_wait(&unstable_state, &bar_mutex);
        pthread_mutex_lock(&write_mutex);
        if (k_total < 1 && b->cm <=20) {
            b->cm = b->cm + 10; //Usando este valor calculamos el deltak
            /* printf("\nThread yendo hacia abajo\n"); */
            if(b->direction == UP) {
                b->direction = DOWN;
                changed_direction = true;
            } else {
                changed_direction = false;
            }
        } else if (k_total > 1 && b->cm >=-20) {
            b->cm = b->cm - 10; //Usando este valor calculamos el deltak
            /* printf("\nThread yendo hacia arriba\n"); */
            if(b->direction == DOWN) {
                b->direction = UP;
                changed_direction = true;
            } else {
                changed_direction = false;
            }
        }

        k_total = 0.0;
        for (int i = 0; i < NUM_THREADS; ++i) {
            k_total += getDeltaKValue(bars[i].cm);
        }
        char str[25];
        if ((double)k_total != (double)1.0) {
            unbalanced = true;
        } else {
            printf("\nBALANCED");
            unbalanced = false;
        }

        pthread_mutex_unlock(&write_mutex);

        if (changed_direction) {
            sleep(CHANGE_DIRECTION);
        }
        sleep(MOVEMENT_TIME);

        sprintf(str,"id=%ld&cm=%d",b->id, b->cm);
        doPost("barValue",str);

        /* printf("\nEnding thread %ld", b->id); */
        changed_direction = false;
        pthread_mutex_unlock(&bar_mutex);
        sleep(1); 
    }
    pthread_exit(NULL);
}

Answer 1

好的，好吧，问题不在这里。那段代码确实有效。使用gdb我看到有2个全局变量 bars 具有相同的名称但具有不同的引用，因为我正在为同一个变量做2个mallocs我在2个不同的函数中使用该变量更新bot结构而不只是1 ...我刚刚删除了意想不到的malloc，一切正常。

pthread互斥锁中出现意外行为

1 个答案: