OutputStream问题... OutofBoundsException

时间:2017-08-04 15:00:55

标签: android inputstream indexoutofboundsexception outputstream

我对Android很陌生,并制作了一个应用程序,需要从网址下载jpg并缓存才能使用。

到目前为止,我从多个参考资料(以及我自己的修修补补)到目前为止:

public class download_image extends AsyncTask<String, Void, String> {
    int count;
    @Override
    protected String doInBackground(String... urls) {
        try {
            String root = getFilesDir().toString();
            URL imgurl = new URL(urls[0]); // Form a URL object from string.
            URLConnection c = imgurl.openConnection();   //Open connection.
            int length_of_file = c.getContentLength();      // Get size of target jpg
            Log.v("Background Response","Length fo target img = "+length_of_file);
            InputStream i = new BufferedInputStream(imgurl.openStream(),length_of_file);

            //Make target image file...
            final File image = new File(getApplicationContext().getCacheDir().toString(),"image.jpg");

            OutputStream o = new FileOutputStream(image);
            byte data[] = new byte[length_of_file];
            long total = 0;
            while ((count = i.read(data))!=1){
                total+=count;
                o.write(data,0,count);
            }

            o.flush();
            o.close();
            i.close();

        } catch (MalformedURLException m) {
            Log.e("Exception", m.toString());
        } catch (IOException i) {
            Log.e("Exception", i.toString());
        }

        return null;
    }

    @Override
    protected void onPostExecute(String s) {
        System.out.println("Downloaded");
        super.onPostExecute(s);
    }

    @Override
    protected void onPreExecute() {
        super.onPreExecute();
    }
}

问题似乎是数据数据[]流过什么东西? 我无法弄明白。我已经尝试使InputStream的缓冲区等于文件大小length_of_file = getContentLength();

任何帮助将不胜感激! 到目前为止,我非常高兴地了解其他问题(比如获取要写入的内部文件夹以及异步任务是什么......我最初不知道我需要HTTPConnections)。

    08-04 15:51:22.938 13454-13486/com.example.johnny.fibre V/Background Response: Length fo target img = 106620
08-04 15:51:23.058 13454-13486/com.example.johnny.fibre E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #2
                                                                          Process: com.example.johnny.fibre, PID: 13454
                                                                          java.lang.RuntimeException: An error occurred while executing doInBackground()
                                                                              at android.os.AsyncTask$3.done(AsyncTask.java:325)
                                                                              at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
                                                                              at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
                                                                              at java.util.concurrent.FutureTask.run(FutureTask.java:242)
                                                                              at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
                                                                              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
                                                                              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
                                                                              at java.lang.Thread.run(Thread.java:761)
                                                                           Caused by: java.lang.ArrayIndexOutOfBoundsException: length=106620; regionStart=0; regionLength=-1
                                                                              at java.util.Arrays.checkOffsetAndCount(Arrays.java:4857)
                                                                              at libcore.io.IoBridge.write(IoBridge.java:490)
                                                                              at java.io.FileOutputStream.write(FileOutputStream.java:316)
                                                                              at com.example.johnny.fibre.Home$download_image.doInBackground(Home.java:476)
                                                                              at com.example.johnny.fibre.Home$download_image.doInBackground(Home.java:456)
                                                                              at android.os.AsyncTask$2.call(AsyncTask.java:305)
                                                                              at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                              at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243) 
                                                                              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133) 
                                                                              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607) 
                                                                              at java.lang.Thread.run(Thread.java:761) 

1 个答案:

答案 0 :(得分:0)

getContentLength()会返回length of the content header,而不是您要下载的图片的大小。在这种情况下,你很可能会分配一个不够大的数组来适应你想要写的图像!

为什么不将您读取的数据流式传输到ByteArrayOutputStream,而不是分配byte数组,并在完成后通过调用流上的getBytes()来获取结果?

通过这种方式,你根本不需要知道图像的长度;你需要做的就是继续阅读数据,直到你到达InputStream的末尾。

Click here for an example of how to use a ByteArrayOutputStream

作为替代方案,您可能希望利用Android运行时内置的一些helper utilities,专门用于从URL获取图像数据。