要求python导入是模块

时间:2017-07-11 22:48:22

标签: python lint google-style-guide

python的Google样式指南指出,应该: "仅对包和模块使用导入。"

https://google.github.io/styleguide/pyguide.html#Imports

是否存在标记违反此建议的工具?

Pylint不这样做。例如,以下内容: Is there a tool to lint Python based on the Google style guide?

创建test.py违反了指南(exists是一个功能,而不是模块):

"""Test file for pylint"""
from os.path import exists

exists('/home')

然后,使用rc文件运行pylint就可以了:

$ pylint --rcfile=googlecl-pylint.rc -r n -s n  test.py
$ echo $?
0

搜索可能的代码:http://pylint-messages.wikidot.com/all-codes,我没有看到任何看起来会对此发出警告的内容。

我也没有在pep8或pyflakes中看到任何能够捕捉到它的东西。

1 个答案:

答案 0 :(得分:3)

我为此目的制作了以下pylint插件:

import astroid
from pylint import checkers, interfaces
from pylint.checkers import utils


class ImportOnlyModulesChecked(checkers.BaseChecker):
  __implements__ = interfaces.IAstroidChecker

  name = 'import-only-modules'
  priority = -1
  msgs = {
    'W5521': (
      "Import \"%s\" from \"%s\" is not a module.",
      'import-only-modules',
      "Only modules should be imported.",
    ),
  }

  @utils.check_messages('import-only-modules')
  def visit_importfrom(self, node):
    try:
      imported_module = node.do_import_module(node.modname)
    except astroid.AstroidBuildingException:
      # Import errors should be checked elsewhere.
      return

    if node.level is None:
      modname = node.modname
    else:
      modname = '.' * node.level + node.modname

    for (name, alias) in node.names:
      # Wildcard imports should be checked elsewhere.
      if name == '*':
        continue

      try:
        imported_module.import_module(name, True)
        # Good, we could import "name" as a module relative to the "imported_module".
      except astroid.AstroidImportError:
        self.add_message(
          'import-only-modules',
          node=node,
          args=(name, modname),
        )
      except astroid.AstroidBuildingException:
        # Some other error.
        pass


def register(linter):
  linter.register_checker(ImportOnlyModulesChecked(linter))