AD samAccountname脚本错误

时间:2017-07-02 14:17:52

标签: powershell active-directory

我试图输入一个csv文件,其中包含Givename&用户的姓氏信息。当我运行下面列出的命令时,samAccountName不会给我预期的输出。

请参阅下文,让我知道应该纠正什么。

输入:

public class name {
String name;
   @JsonProperty("name")
    public String getName() {
      return name;
    }

    @JsonProperty("surname")
    public void setSurname(String surname) {
      this.name = surname;
    }
}

命令:

GivenName,LastName,Password,TargetOU,Description,Manager
Jeffrey,Terry,Pass12,"OU=Users,DC=mmc,DC=local",mmc user,knadella
A,King,Pass13,"OU=Users,DC=mmc,DC=local",mmc user,knadella
Chris ,Charles,Pass14,"OU=Users,DC=mmc,DC=local",mmc user,knadella

当前输出:

$samAccountName = ($csvcontent.GivenName.Substring(0,1))+( $csvcontent.LastName)

期望的输出:

J A C Terry King Charles

请帮忙。谢谢!

3 个答案:

答案 0 :(得分:1)

您将一次性汇总所有详细信息,并将GivenName列(J A C)的结果与LastName列(Terry King Charles)的结果相结合`

这会循环每个用户:

foreach($user in $csvcontent){
    [array]$samAccountName += $user.GivenName[0] + $user.LastName
}

输出:

JTerry AKing CCharles

答案 1 :(得分:0)

每天给你三十次使用的东西。您希望创建它的方式将破坏一些登录选项。

# <FirstLetterGivingName><LastName> for example
# WGates (William Gates)
 $sam = $_.GivenName.substring(0,1)+$_.Lastname

这是一件好事,但随着公司的发展,您将开始遇到用户名相同的问题。这不是一个完美的解决方案,但有GivenName(0,3)会给你前三个字母。这通常可以解决这个问题。如果你遇到前三个字母和姓氏相同的人,那真的很少见,但可能会发生。

$sam = $_.GivenName.substring(0,3)+$_.Lastname

我也看到公司这样做,但建议不要这样做,因为用户很难记住登录。

$sam = $_.GivenName.substring(0,1)+$_.Lastname.substring(0,7)

此脚本已被使用了数千次,但此帖已经过一些编辑。

#Test to make sure your output looks correct
#You can do this by running the following:
#Import-csv ".\import_create_ad_users.csv" | Out-GridView

# ERROR REPORTING ALL
Set-StrictMode -Version latest
Import-Module ActiveDirectory

#----------------------------------------------------------
#STATIC VARIABLES
#----------------------------------------------------------

$path = Split-Path -parent $MyInvocation.MyCommand.Definition
$newpath = $path + ".\import_create_ad_users.csv"
$log = $path + ".\create_ad_users.log"
$date = Get-Date
$i = 1
#$addn = (Get-ADDomain).DistinguishedName
#$dnsroot = (Get-ADDomain).DNSRoot
$DNdom = Get-ChildItem -Path Ad:\ | where {$_.Name -eq "Configuration"}            
$addn = ($DNdom.DistinguishedName -split "," ,2)[1] 
$wmiDomain = Get-WmiObject Win32_NTDomain -Filter "DnsForestName = '$( (Get-WmiObject Win32_ComputerSystem).Domain)'"
$dnsroot = $wmiDomain.DomainName  + ".local"

#----------------------------------------------------------
#START FUNCTIONS
#----------------------------------------------------------
Function Start-Commands
{
  Create-Users
}

Function Create-Users
{
  "Processing started (on " + $date + "): " | Out-File $log -append
  "--------------------------------------------" | Out-File $log -append
  Import-CSV $newpath | ForEach-Object {
      If (($_.GivenName -eq "") -Or ($_.LastName -eq ""))
      {
        Write-Host "[ERROR]`t Please provide valid GivenName and LastName. Processing skipped for line $($i)`r`n"
        "[ERROR]`t Please provide valid GivenName and LastName. Processing skipped for line $($i)`r`n" | Out-File $log -append
      }
      Else
       {

        # Replace dots / points (.) in names, because AD will error when a 
        # name ends with a dot (and it looks cleaner as well)
        $replace = $_.Lastname.Replace(".","")
        If($replace.length -lt 4)
            {
            $lastname = $replace
            }
        Else
            {
            $lastname = $replace.substring(0,4)
            }
        # Create sAMAccountName according to this 'naming convention':
        # <FirstLetterInitialGivingName><LastName> for example
        # WGates (William Gates)
        $sam = $_.GivenName.substring(0,1)+$_.Lastname
        Try   { $exists = Get-ADUser -LDAPFilter "(sAMAccountName=$sam)" }
        Catch { }
        If(!$exists)
            {
          # Set all variables according to the table names in the Excel 
          # sheet /import CSV. The names can differ in every project, but 
          # if the names change, make sure to change it below as well.
          $setpass = ConvertTo-SecureString -AsPlainText $_.Password -force

          Try
          {
            Write-Host "[INFORMATION]`t User is now being built : $($sam)"
            "[INFORMATION]`t User is now being built : $($sam)" | Out-File $log -append
            New-ADUser $sam -path $_.TargetOU -GivenName $_.GivenName -Initials $_.Initials `
            -Surname $_.LastName -UserPrincipalName ($sam + "@" + $dnsroot) -DisplayName ($_.GivenName + " " + $_.LastName) `
            -Description $_.Description -Manager $_.Manager -AccountPassword $setpass -Enabled $TRUE -ChangePasswordAtLogon $TRUE
            Write-Host "[INFORMATION]`t Created a new user named : $($sam)"
            "[INFORMATION]`t Created new user named: $($sam)" | Out-File $log -append

             $dn = (Get-ADUser $sam).DistinguishedName

            # Rename the object to a good looking name
            $newdn = (Get-ADUser $sam).DistinguishedName
            Rename-ADObject -Identity $newdn -NewName ($_.GivenName + " " + $_.LastName)
            Write-Host "[INFORMATION]`t Renamed the user $($sam) to $($_.GivenName) $($_.LastName)`r`n"
            "[INFORMATION]`t Renamed the user $($sam) to $($_.GivenName) $($_.LastName)`r`n" | Out-File $log -append

          }
          Catch
          {
            Write-Host "[ERROR]`t Oops, something went wrong: $($_.Exception.Message)`r`n"
          }
        }
        Else
        {
          Write-Host "[SKIP]`t User $($sam) ($($_.GivenName) $($_.LastName)) already exists or returned an error!`r`n"
          "[SKIP]`t User $($sam) ($($_.GivenName) $($_.LastName)) already exists or returned an error!" | Out-File $log -append
        }
      }
    Else
    {
      Write-Host "[SKIP]`t User ($($_.GivenName) $($_.LastName)) will be skipped for processing!`r`n"
      "[SKIP]`t User ($($_.GivenName) $($_.LastName)) will be skipped for processing!" | Out-File $log -append
    }
    $i++
  }
  "Processing ended (on " + $date + "): " | Out-File $log -append
  "--------------------------------------------" + "`r`n" | Out-File $log -append
}


Write-Host "***************************SCRIPT HAS STARTED***************************"
Write-Host "***************************SCRIPT HAS STARTED***************************"
Write-Host "***************************SCRIPT HAS STARTED***************************`r`n"
Start-Commands
Write-Host "***************************SCRIPT HAS FINISHED***************************"
Write-Host "***************************SCRIPT HAS FINISHED***************************"
Write-Host "***************************SCRIPT HAS FINISHED***************************"

您的CSV会有以下标题:

GivenName LastName LoginName描述密码管理器TargetOU

答案 2 :(得分:0)

您需要立即迭代每个项目而不是整个数组:

$samAccountName = $csvcontent | % {
($_.GivenName.Substring(0,1))+($_.LastName)
}