如何避免因内存问题导致应用终止?

时间:2017-06-14 09:49:23

标签: objective-c core-data

我从一个Web服务获取700.000行,并且由于内存问题我的应用程序在一段时间终止后崩溃,它在崩溃之前消耗了大约1 GB的ram,代码相当简单,我获取JSON,I放入一个数组,我循环数组并插入核心数据,一旦完成,我保存上下文

代码如下所示

+ (void)fetchTillDataAll:(int)tillId :(int)startAtRow :(int)takeNoOfRows {



    if ([NWTillHelper isDebug] == 1) {
        NSLog(@"WebServices:fetchTillDataAll:tillId = %d, startAtRow = %d, takeNoOfRows = %d", tillId, startAtRow, takeNoOfRows);
    }

    NSString *finalURL = [NSString stringWithFormat:@"https://host.domain.com:5443/api/till/tilldatav2/%d?StartAtRow=%d&TakeNoOfRows=%d",tillId, startAtRow, takeNoOfRows];

    [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:finalURL]
                                 completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {

                                     if (error != nil) {
                                         if ([NWTillHelper isDebug] == 1) {
                                             NSLog(@"WebServices:fetchTillDataAll:Transport error %@", error);
                                         }
                                     } else {
                                         NSHTTPURLResponse *responseHTTP;
                                         responseHTTP = (NSHTTPURLResponse *) response;

                                         if(responseHTTP.statusCode != 200) {
                                             if ([NWTillHelper isDebug] == 1) {
                                                 NSLog(@"WebServices:fetchTillDataAll:Server Error %d", (int) responseHTTP.statusCode);
                                             }
                                         } else {
                                             NSArray *tillBasicDataArray = [NSJSONSerialization JSONObjectWithData:data
                                                                                                           options:0
                                                                                                             error:NULL];
                                             if ([NWTillHelper isDebug] == 1) {
                                                 NSLog(@"WebServices:fetchTillDataAll:tillBasicDataArray count = %lu", (unsigned long)[tillBasicDataArray count]);
                                                 NSLog(@"WebServices:fetchTillDataAll:tillBasicDataArray looks like %@",tillBasicDataArray);
                                             }

                                             AppDelegate *appDelegate = (AppDelegate *)[[UIApplication sharedApplication]delegate];

                                             //NSManagedObjectContext *context =
                                             //appDelegate.persistentContainer.viewContext;
                                             //context.mergePolicy = NSMergeByPropertyStoreTrumpMergePolicy;

                                             NSPersistentContainer *container = appDelegate.persistentContainer;

                                             [container performBackgroundTask:^(NSManagedObjectContext *context ) {
                                                 context.mergePolicy = NSMergeByPropertyStoreTrumpMergePolicy;

                                                 NSDictionary *tillBasicDataDict = Nil;

                                                 //Loop through the array and for each dictionary insert into local DB
                                                 // lets work on concurrency here
                                                 for (id element in tillBasicDataArray){
                                                     tillBasicDataDict = element;

                                                     NSString *itemId = [tillBasicDataDict objectForKey:@"itemId"];
                                                     NSString *brandId = [tillBasicDataDict objectForKey:@"companyId"];
                                                     NSString *languageId = [tillBasicDataDict objectForKey:@"languageCode"];
                                                     NSString *colorCode = [NSString stringWithFormat:@"%@", [tillBasicDataDict objectForKey:@"colorCode"]];
                                                     NSString *discountable = [tillBasicDataDict objectForKey:@"discountable"];
                                                     NSString *exchangeable = [tillBasicDataDict objectForKey:@"exchangeable"];
                                                     NSString *noos14 = [tillBasicDataDict objectForKey:@"noos14"];
                                                     NSString *sizeCode = [NSString stringWithFormat:@"%@", [tillBasicDataDict objectForKey:@"sizeCode"]];
                                                     NSString *taxGroup = [tillBasicDataDict objectForKey:@"taxGroupId"];
                                                     NSString *taxRegion = [tillBasicDataDict objectForKey:@"taxRegion"];
                                                     NSString *tradeItemDesc = [tillBasicDataDict objectForKey:@"tradeItemDesc"];
                                                     NSString *withTax = [tillBasicDataDict objectForKey:@"withTax"];
                                                     NSString *status = [tillBasicDataDict objectForKey:@"status"];

                                                     // Use Core Data FMD


                                                     NSManagedObject *newPimItem = Nil;
                                                     newPimItem = [NSEntityDescription
                                                                   insertNewObjectForEntityForName:@"TillData"
                                                                   inManagedObjectContext:context];

                                                     [newPimItem setValue:itemId forKey:@"itemId"];
                                                     [newPimItem setValue:brandId forKey:@"brandId"];
                                                     [newPimItem setValue:languageId forKey:@"languageCode"];
                                                     [newPimItem setValue:colorCode forKey:@"colorCode"];
                                                     [newPimItem setValue:discountable forKey:@"discountable"];
                                                     [newPimItem setValue:exchangeable forKey:@"exchangeable"];
                                                     [newPimItem setValue:noos14 forKey:@"noos14"];
                                                     [newPimItem setValue:sizeCode forKey:@"sizeCode"];
                                                     [newPimItem setValue:[NSNumber numberWithInt:[taxGroup intValue]] forKey:@"taxGroup"];
                                                     [newPimItem setValue:taxRegion forKey:@"taxRegion"];
                                                     [newPimItem setValue:tradeItemDesc forKey:@"tradeItemDesc"];
                                                     [newPimItem setValue:[NSNumber numberWithInt:[withTax intValue]] forKey:@"withTax"];
                                                     [newPimItem setValue:[NSNumber numberWithInt:[status intValue]] forKey:@"status"];

                                                     if ([NWTillHelper isDebug] == 1) {
                                                         NSLog(@"WebServices:fetchTillDataAll:ItemId in loop = %@", itemId);
                                                         NSLog(@"WebServices:fetchTillDataAll:newPimItem = %@", newPimItem);
                                                         NSLog(@"WebServices:fetchTillDataAll:CoreData error = %@", error);
                                                     }

                                                 }
                                                 NSError *error = nil;
                                                 if (![context save:&error]) {
                                                     NSLog(@"Failure to save context: %@\n%@", [error localizedDescription], [error userInfo]);
                                                     abort();
                                                 } else {
                                                     NSUserDefaults *tillUserDefaults = [NSUserDefaults standardUserDefaults];
                                                     [tillUserDefaults setInteger:1 forKey:@"hasTillData"];
                                                     [tillUserDefaults synchronize];
                                                 }
                                             }];
                                         }
                                     }
                                 }] resume];
}

我可以做些什么来减少占地面积,以便我能够下载数据?我绝对必须在本地拥有数据才能在应用程序中使用离线功能

-----编辑-----

在实现将NSArray拆分为数组数组之后,我仍然会遇到同样的问题,如果建议的新代码如下:

拆分方法

+ (NSArray *) splitIntoArraysOfBatchSize:(NSArray *)originalArray :(int)batchSize {

    NSMutableArray *arrayOfArrays = [NSMutableArray array];

    for(int j = 0; j < [originalArray count]; j += batchSize) {

        NSArray *subarray = [originalArray subarrayWithRange:NSMakeRange(j, MIN(batchSize, [originalArray count] - j))];
        [arrayOfArrays addObject:subarray];
    }

    return arrayOfArrays;
}

循环遍历数组如下

+(void)fetchPricelistAll:(int)pricelistId :(int)startAtRow :(int)takeNoOfRows;
{
    if ([NWTillHelper isDebug] == 1) {
        NSLog(@"WebServices:fetchPriceList:priceListId = %d", pricelistId);
    }

    NSString *finalURL = [NSString stringWithFormat:@"https://host.domain.com:5443/api/till/tillpricelistv2/%d?StartAtRow=%d&TakeNoOfRows=%d",pricelistId, startAtRow, takeNoOfRows];

    [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:finalURL]
                                 completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {

                                     if (error != nil) {
                                         if ([NWTillHelper isDebug] == 1) {
                                             NSLog(@"WebServices:fetchPriceList:Transport error %@", error);
                                         }
                                     } else {
                                         NSHTTPURLResponse *responseHTTP;
                                         responseHTTP = (NSHTTPURLResponse *) response;

                                         if(responseHTTP.statusCode != 200) {
                                             if ([NWTillHelper isDebug] == 1) {
                                                 NSLog(@"WebServices:fetchPriceList:Server Error %d", (int) responseHTTP.statusCode);
                                             }
                                         } else {
                                             NSArray *priceListObjectArray = [NSJSONSerialization JSONObjectWithData:data
                                                                                                             options:0
                                                                                                               error:NULL];
                                             if ([NWTillHelper isDebug] == 1) {
                                                 NSLog(@"WebServices:fetchPriceList:count = %lu", (unsigned long)[priceListObjectArray count]);
                                                 NSLog(@"WebServices:fetchPriceList:PricelistObjectArray looks like %@",priceListObjectArray);
                                             }

                                             AppDelegate *appDelegate = (AppDelegate *)[[UIApplication sharedApplication]delegate];

                                             NSPersistentContainer *container = appDelegate.persistentContainer;

                                             NSArray *arrayOfArrays = [NWTillHelper splitIntoArraysOfBatchSize:priceListObjectArray :1000];

                                             for(NSArray *batch in arrayOfArrays) {

                                                 [container performBackgroundTask:^(NSManagedObjectContext *context ) {
                                                     context.mergePolicy = NSMergeByPropertyStoreTrumpMergePolicy;


                                                     NSDictionary *priceListObjectDict;

                                                     //Loop through the array and for each dictionary insert into local DB
                                                     for (id element in batch) {
                                                         priceListObjectDict = element;

                                                         NSString *currencyName = [priceListObjectDict objectForKey:@"currencyName"];
                                                         NSString *price = [priceListObjectDict objectForKey:@"price"];
                                                         NSString *priceIncTax = [priceListObjectDict objectForKey:@"priceIncTAX"];
                                                         NSString *validFrom = [priceListObjectDict objectForKey:@"validFromDate"];
                                                         NSString *validTo = [priceListObjectDict objectForKey:@"validToDate"];
                                                         NSString *itemId = [priceListObjectDict objectForKey:@"itemID"];

                                                         NSDateFormatter *dateFormat = [[NSDateFormatter alloc] init];
                                                         [dateFormat setDateFormat:@"YYYY-MM-dd'T'HH:mm:ss"];
                                                         NSDate *validToDate = [dateFormat dateFromString:validTo];
                                                         NSDate *validFromDate = [dateFormat dateFromString:validFrom];

                                                         if([NWTillHelper isDebug] == 1) {
                                                             NSLog(@"WebServices:fetchPriceList:validToDate: >>>> %@ <<<<", validToDate);
                                                             NSLog(@"WebServices:fetchPriceList:validFromDate: >>>> %@ <<<<", validFromDate);
                                                         }

                                                         if([NWTillHelper isDebug] == 1) {
                                                             NSLog(@"PimItemListView:tableView:context = %@", context);
                                                         }

                                                         NSManagedObject *newPrlItem = Nil;
                                                         newPrlItem = [NSEntityDescription
                                                                       insertNewObjectForEntityForName:@"PriceList"
                                                                       inManagedObjectContext:context];

                                                         [newPrlItem setValue:itemId forKey:@"itemId"];
                                                         [newPrlItem setValue:validToDate forKey:@"validTo"];
                                                         [newPrlItem setValue:validFromDate forKey:@"validFrom"];
                                                         [newPrlItem setValue:price forKey:@"price"];
                                                         [newPrlItem setValue:priceIncTax forKey:@"priceIncTax"];
                                                         [newPrlItem setValue:currencyName forKey:@"currencyName"];

                                                         if ([NWTillHelper isDebug] == 1) {
                                                             NSLog(@"WebServices:fetchTillData:ItemId in loop = %@", itemId);
                                                             NSLog(@"WebServices:fetchTillData:newPrlItem = %@", newPrlItem);
                                                             NSLog(@"WebServices:fetchTillData:CoreData error = %@", error);
                                                         }
                                                     }
                                                     NSError *error = nil;
                                                     if (![context save:&error]) {
                                                         NSLog(@"Failure to save context: %@\n%@", [error localizedDescription], [error userInfo]);
                                                         abort();
                                                     } else {
                                                         NSUserDefaults *tillUserDefaults = [NSUserDefaults standardUserDefaults];
                                                         [tillUserDefaults setInteger:1 forKey:@"hasPriceList"];
                                                         [tillUserDefaults synchronize];
                                                     }
                                                 }];
                                             }
                                         }
                                     }
                                 }] resume];
}

当NSURLSession完成块达到内存使用量大约为250时,它仍会升至2 GB并终止,我认为是在将整个数据集下载到NSArray之后,但之后我想写入核心所有数据都非常错误,它会变为2 GB并被终止

为什么?

1 个答案:

答案 0 :(得分:0)

首先将大型数组拆分为数组数组。试验一个不太大的批量大小(应用程序会崩溃)或太小(需要很长时间)。我建议从500开始。看这里怎么做:What is an easy way to break an NSArray with 4000+ objects in it into multiple arrays with 30 objects each?。我假设您可以将该代码转换为数组扩展名。

    NSArray *arrayOfArrays = [tillBasicDataArray splitIntoArrayBatchSize:500];

接下来,您可以将许多块排入队列,每个块只处理多个阵列中的一个,并在最后保存它。

    for(NSArray *batch in arrayOfArrays){
         [container performBackgroundTask:^(NSManagedObjectContext *context ) {
          ...
          for (id element in batch){
          ...

每个performBackgroundTask都被排入内部操作,并且每次处理一个。

其余代码基本保持不变。