首先让我说我对存储过程的了解非常基础。我知道如何编写基本查询并在VBA中返回值。我也知道你基本上可以从SQL中编写程序，这是我的知识崩溃的地方。我只是不必这么做。无论如何，在VBA中，我运行了一系列查询。正如我在该项目的概念阶段所担心的那样，它会产生一些真正的性能问题，从单个例程运行太多查询。这是常规。
Public Sub linePoll()
errorPosition = "aofResults.linePoll"
On Error GoTo errorTrap
Err.Clear
Dim rst As ADODB.Recordset
Dim rstA As ADODB.Recordset
Dim rstB As ADODB.Recordset
Dim rstC As ADODB.Recordset
Dim rstD As ADODB.Recordset
Dim rstE As ADODB.Recordset
Dim packQty As Integer
Dim m As Integer
Dim formFactor As Integer
m = 0
constr = "Provider=sqloledb;data source=i.p.add.ress;initial catalog=catalog;user id=user;password=password"
Set conn = New ADODB.connection
Set cmd = New ADODB.Command
conn.Open constr
cmd.ActiveConnection = conn
LogDiagnosticsMessage "Getting order quantity"
cmd.CommandText = "SELECT ISNULL(SUM(lQ.[QUANTITY]), 0) FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] AS lQ LEFT JOIN [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_QUEUE] AS oQ ON lQ.[SALES_ORDER_NUMBER] = oQ.[SALES_ORDER_NUMBER]"
Set rst = cmd.execute 'Get total order quantity, may change if inventory depletes.
If Not rst.EOF = True Then
LogDiagnosticsMessage "Found order quantity as " & rst(0)
Set eTag = ThisDisplay.eGroup.item("AOF\soQuantity")
eTag.value = rst(0)
Else
LogDiagnosticsMessage "No order found in line queue DB"
End If
If Not rst(0) = 0 Then
LogDiagnosticsMessage "Getting optic order quantity packed"
cmd.CommandText = "SELECT Count(rL.SERIAL_NUMBER) FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_OPTIC_RESULTS] AS rL WHERE EXISTS (SELECT [SO_LINE_NUMBER] FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] AS lQ LEFT JOIN [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_QUEUE] AS oQ ON lQ.[SALES_ORDER_NUMBER] = oQ.SALES_ORDER_NUMBER) AND [REJECT] = 'False'"
Set rst = cmd.execute
If Not rst.EOF = True Then
LogDiagnosticsMessage "Found optics order quantity packed as " & rst(0)
Set eTag = ThisDisplay.eGroup.item("AOF\soQuantityPacked")
eTag.value = rst(0)
Else
LogDiagnosticsMessage "No packed optics found in results DB"
End If
Set eTag = ThisDisplay.eGroup.item("Machine\itoSettings0") 'Evaluate packing quantity against machine settings (stored in DB, written to PLC at first startup)
LogDiagnosticsMessage "Evaluating manual pack need"
If rst(0) < eTag.value Then
Set eTag = ThisDisplay.eGroup.item("AOF\manualPack") 'Evaluate packing quantity
eTag.value = True
Else
eTag.value = False
End If
LogDiagnosticsMessage "Getting the top line order information"
cmd.CommandText = "SELECT lQ.[SO_LINE_NUMBER],lQ.[QUANTITY],lQ.[SELECTED],lQ.[FORM_FACTOR_ID], lQ.[FINISHED_PART_NUMBER], ISNULL(lQ.[OEM_PART_NUMBER], ''),ISNULL(lQ.[COMPATIBILITY], ''), oQ.[INDIVIDUAL_PACKAGING], oQ.[SALES_ORDER_NUMBER] FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_QUEUE] AS oQ LEFT JOIN [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] AS lQ ON oQ.[SALES_ORDER_NUMBER] = lQ.[SALES_ORDER_NUMBER] WHERE lQ.[SO_LINE_NUMBER] IS NOT NULL ORDER BY lQ.[SELECTED] DESC,lQ.[COMPLETED] ASC"
Set rstA = cmd.execute() 'Returns the line orders associated to the sales order
If Not rstA.EOF = True Then
Set eTag = ThisDisplay.eGroup.item("AOF\SOLineNumber")
If Not eTag.value = rstA(0) Then '************************************Updates the line order if the line order is different than what's already selected
Set eTag = ThisDisplay.eGroup.item("AOF\SOLineNumber")
eTag.value = rstA(0)
Set eTag = ThisDisplay.eGroup.item("AOF\QuantityOrdered")
eTag.value = rstA(1)
Set eTag = ThisDisplay.eGroup.item("AOF\FinishedPartNumber")
eTag.value = rstA(4)
Set eTag = ThisDisplay.eGroup.item("AOF\OEMPartNumber")
eTag.value = rstA(5)
Set eTag = ThisDisplay.eGroup.item("AOF\Compatibility")
eTag.value = rstA(6)
Set eTag = ThisDisplay.eGroup.item("AOF\IndividualPack") 'PLC expects "Double Pack" true\false, ITO sends "Single Pack" true\false
eTag.value = Not rstA(7)
End If '************************************
LogDiagnosticsMessage "Getting the quantity of parts passed for this line order"
cmd.CommandText = "SELECT COUNT(oL.[SERIAL_NUMBER]) FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_OPTICS] AS oL WHERE NOT EXISTS ( SELECT [SERIAL_NUMBER] FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_OPTIC_RESULTS] rL WHERE oL.[SERIAL_NUMBER] = rL.[SERIAL_NUMBER]) AND oL.[SO_LINE_NUMBER] = " & rstA(0)
Set rstB = cmd.execute() 'Returns the count of the parts associated to the above line order that passed
If Not rstB.EOF = True Then
Set eTag = ThisDisplay.eGroup.item("AOF\QuantityPassed")
eTag.value = rstB(0)
LogDiagnosticsMessage "Evaluating parts remaining for this line order as " & rstB(0)
Select Case rstB(0) 'Evaluate Qty left to process in active line order
Case Is = 0 'Qty Zero (Line order complete)
LogDiagnosticsMessage "Setting line order as completed"
cmd.CommandText = "UPDATE [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] SET [SELECTED] = 'False', [COMPLETED] = 'True' WHERE [SO_LINE_NUMBER] = " & rstA(0)
cmd.execute 'Unselect the currently index line order and Set order as completed
LogDiagnosticsMessage "Checking line order quantity against sales order quantity"
cmd.CommandText = "SELECT ((SELECT COUNT(lQ.[SO_LINE_NUMBER]) FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] AS lQ LEFT JOIN [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_QUEUE] AS oQ ON oQ.[SALES_ORDER_NUMBER] = lQ.[SALES_ORDER_NUMBER]) - (SELECT COUNT(lQ.[SO_LINE_NUMBER]) FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] AS lQ LEFT JOIN [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_QUEUE] AS oQ ON oQ.[SALES_ORDER_NUMBER] = lQ.[SALES_ORDER_NUMBER] WHERE lQ.[COMPLETED] = 'True'))"
Set rstD = cmd.execute() 'Check line queue quantity associated to the sales order, count the line orders associated to the current sales order in the queue that are incomplete
'Set the currently indexed line order as selected
If rstD(0) = 0 Then
cmd.CommandText = "SELECT [ID] FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_BOXES] WHERE [SELECTED] = 'True'"
Set rstE = cmd.execute()
If Not rstE.EOF = False Then
Set eTag = ThisDisplay.eGroup.item("AOF\soFinished")
eTag.value = True
Set eTag = ThisDisplay.eGroup.item("AOF\PLC_FinishBox")
If eTag.value = 1 Then
LogDiagnosticsMessage "Checking whether or not the PLC ready to complete the order"
Set eTag = ThisDisplay.eGroup.item("AOF\PLC_CompleteOrder") 'Checks that order fulfillment mode is turned off
If eTag.value = 1 Then
boxNum = 0
LogDiagnosticsMessage "Unselecting sales order " & rstA(8) & ", deleting results for this sales order, and setting status to ERP"
cmd.CommandText = "UPDATE [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_QUEUE] SET [SELECTED] = 'False' WHERE [SALES_ORDER_NUMBER] = '" & rstA(8) & "'"
cmd.execute 'Set's the current sales order selected bit to off
cmd.CommandText = "UPDATE [ROBOTICS_OPTICS_MECHUAT].[dbo].[MACHINE_STATE] SET [STATUS] = 'USER' where [OPERATING_STATE] = 2"
cmd.execute 'sets the status back to USER
cmd.CommandText = "DELETE FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_OPTIC_RESULTS]"
cmd.execute
Set eTag = ThisDisplay.eGroup.item("AOF\orderFulfillmentMode")
eTag.value = 0
Set eTag = ThisDisplay.eGroup.item("AOF\PLC_CompleteOrder")
eTag.value = 0
End If
End If
End If
rstE.Close
Else
rstA.MoveNext 'Index to the next line order in the record set
LogDiagnosticsMessage "Indexing to the next order in the list, setting" & rstA(0) & " selected."
cmd.CommandText = "UPDATE [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] SET [SELECTED] = 'True' WHERE [SO_LINE_NUMBER] = " & rstA(0)
cmd.execute
rstD.Close
End If
Case Is > 0 'Qty Remaining > Line Order Qty (Line Order Select)
LogDiagnosticsMessage "Getting the form factor for this line order"
cmd.CommandText = "SELECT fF.[FORM_FACTOR_DESCRIPTION] FROM [ROBOTICS_OPTICS_MECHUAT].[dbo].[FORM_FACTOR] AS fF LEFT JOIN [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] AS lQ ON lQ.[FORM_FACTOR_ID] = fF.[FORM_FACTOR_ID] WHERE lQ.[SELECTED] = 'True'"
Set rstC = cmd.execute() 'Returns the form factor description that is currently selected in the order line queue
If Not rstC.EOF = True Then
Set eTag = ThisDisplay.eGroup.item("AOF\FormFactor")
eTag.value = rstC(0)
Set eTag = ThisDisplay.eGroup.item("AOF\NextOpticXFP")
Select Case rstC(0)
Case Is = "XFP"
eTag.value = True
Case Is <> "XFP"
eTag.value = Not True
End Select
End If
rstC.Close
LogDiagnosticsMessage "Setting " & rstA(0) & " as selected"
cmd.CommandText = "UPDATE [ROBOTICS_OPTICS_MECHUAT].[dbo].[AOF_ORDER_LINE_QUEUE] SET [SELECTED] = 'True' WHERE [SO_LINE_NUMBER] = " & rstA(0)
cmd.execute 'Set line as selected
Case Else
End Select
Else
MsgBox ("Error: No line orders exist for sales order " & rstA(4) & ".")
End If
ElseIf rstA.EOF = True Then
MsgBox ("Error: No sales order exists or no line orders associated to sales order: " & rstA(4) & " exists.")
End If
End If
Set eTag = ThisDisplay.eGroup.item("AOF\ITO_OpticsReady")
eTag.value = True
GoTo cleanExit
cleanExit:
On Error Resume Next
If Not rst Is Nothing Then
rst.Close
End If
If Not rstA Is Nothing Then
rstA.Close
End If
If Not rstB Is Nothing Then
rstB.Close
End If
If Not rstC Is Nothing Then
rstC.Close
End If
If Not rstD Is Nothing Then
rstD.Close
End If
If Not rstE Is Nothing Then
rstE.Close
End If
conn.Close
Exit Sub
errorTrap:
LogDiagnosticsMessage "_Eventwatcher2.gfx, Position: " & errorPosition & " , Error Code: [ " & Hex(Err.number) & "], Description: " & Err.Description & ""
Resume cleanExit
End Sub
所以，我的想法是在服务器端进行更多处理。我创建了单独的存储过程来封装大多数这些查询，但它对性能没有足够强大的影响。我现在把我带到这里的主要想法是，我可以把所有这些都放到一个存储过程中吗？如果我从存储过程执行七个查询，我该如何在VBA代码中处理它？一个查询与下一个查询的区别如何？如何将查询的输出用作存储过程中另一个查询的输入？
提前致谢！
编辑：所以我正在整合我使用select语句的查询。我最终得到了以下内容，这似乎有效。
Private Sub Button1_Released()
Dim rst(1 To 8) As ADODB.Recordset
errorPosition = "ThisDisplay.Button1 Test"
On Error GoTo errorTrap
Err.Clear
Set conn = New ADODB.Connection
Set cmd = New ADODB.Command
constr = "Provider=sqloledb;data source=i.p.add.ress;initial catalog=CATALOG;user id=user;password=pass"
conn.Open constr
With cmd
.ActiveConnection = conn
.CommandText = "rt_test"
.CommandType = adCmdStoredProc
.CommandTimeout = 2
End With
Set rst(1) = cmd.Execute()
For i = 2 To 8
Set rst(i) = rst(i - 1).NextRecordset
Next
i = 1
GoTo cleanExit
cleanExit:
On Error Resume Next
For i = 1 To 8
If Not rst(i) Is Nothing Then
rst(i).Close
End If
Next
conn.Close
Exit Sub
errorTrap:
LogDiagnosticsMessage "_Eventwatcher2.gfx, Position: " & errorPosition & " , Error Code: [ " & Hex(Err.Number) & "], Description: " & Err.Description & ""
Resume cleanExit
End Sub
最终更新：
对上面的一个小改动产生了我需要的结果。事实证明，当调用NextRecordSet方法时，ADO会自动关闭先前的记录集。所以我需要打开记录集，然后将其克隆到数组中，然后移动到下一个记录集。 我添加了另一个充当占位符的记录集。
Dim recordSet, rst(1 To 8) As ADODB.recordSet
然后按如下方式修改我的代码：
conn.CursorLocation = adUseClient 'Needed to index through and clone recordsets
conn.Open constr
With cmd 'Run stored procedure
.ActiveConnection = conn
.CommandText = "rt_test"
.CommandType = adCmdStoredProc
.CommandTimeout = 2
End With
Set recordSet = cmd.execute()
For i = 1 To 8
Set rst(i) = recordSet.Clone
Set recordSet = recordSet.NextRecordset
Next
...
...
...
cleanExit:
On Error Resume Next
If Not recordSet Is Nothing Then
recordSet.Close
End If
For i = 1 To 8
If Not rst(i) Is Nothing Then
rst(i).Close
End If
Next
conn.Close
Exit Sub
errorTrap:
LogDiagnosticsMessage "_Eventwatcher2.gfx, Position: " & errorPosition & " , Error Code: [ " & Hex(Err.number) & "], Description: " & Err.Description & ""
Resume cleanExit
End Sub
答案 0 :(得分：1)
这比你想象的要复杂得多，我很害怕。
性能问题可能是由于查询本身，而不是它们的执行方式。如果从SSMS运行所有程序，性能如何？好的，类似于从Excel运行它们？也许你需要做一些调整 - 不一定是简单的任务，但有一些工具可以自动完成。在显示单个查询的估计执行计划，并查看该工具是否会推荐一个可能有用的索引。
您可以运行SP返回多个记录集。通常，您将获得一个对象 - RecordSet - 通常带有第一个查询的结果。您可以正常使用它，一旦完成调用方法NextRecordset，您将可以访问第二个查询的RecordSet，依此类推。
不幸的是，T-SQL部分看起来比回答你的问题要多得多。