Question

我试图弄清楚为什么以下代码仅在调试模式下工作...

当我点击我的＆＃34; Save＆＃34;按钮宏保存每个数据条目，即使它是相同的公司名称。当我调试宏进入for循环并给我消息＆＃34;公司已存在＆＃34;。

我的错误在哪里？

Sub Copy_Values()

Dim sapcolleague As String, str1 As String, str2 As String, str3 As String

Dim i As Integer, ValueToFind As String, ValueToCheck As String
Dim totalAccRows As Integer
Dim accColumn As Integer
Dim currentAccRow As Integer

accColumn = 2
totalAccRows = Worksheets("DB").Cells(Rows.Count, accColumn).End(xlUp).Row
ValueToFind = Worksheets("Maintain").Range("F13").Value

For currentAccRow = 2 To totalAccRows
    If Cells(currentAccRow, accColumn).Value = ValueToFind Then
        MsgBox ("Company already exists!")
        Exit Sub
    End If

Next


Worksheets("DB").Range("A8").EntireRow.Insert

Worksheets("DB").Range("A8").Value = 
Worksheets("Maintain").Range("F11").Value
Worksheets("DB").Range("B8").Value = 
Worksheets("Maintain").Range("F13").Value
Worksheets("DB").Range("C8").Value = 
Worksheets("Maintain").Range("F15").Value

str1 = Worksheets("Maintain").Range("F18").Value
str2 = Worksheets("Maintain").Range("F19").Value
str3 = Worksheets("Maintain").Range("F20").Value

sapcolleague = str1 & " " & str2 & " " & str3

Worksheets("DB").Range("D8").Value = sapcolleague

' This MsgBox will only show if the loop completes with no success
MsgBox "Successfully saved!"


End Sub

Answer 1

在If Cells(currentAccRow, accColumn).Value = ValueToFind Then中，Cells没有父工作表，因此在运行时它将成为ActiveSheet。

快速重写：

Option Explicit

Sub Copy_Values()

    Dim sapcolleague As String, valueToFind As String, accColumn As Long

    With Worksheets("DB")

        accColumn = 2
        valueToFind = Worksheets("Maintain").Range("F13").Value

        If Not IsError(Application.Match(valueToFind, .Columns(accColumn), 0)) Then
                MsgBox ("Company already exists!")
                Exit Sub
        End If


        .Range("A8").EntireRow.Insert

        .Range("A8:C8").Value = Array(Worksheets("Maintain").Range("F11").Value, _
                                      valueToFind, _
                                      Worksheets("Maintain").Range("F15").Value)

        sapcolleague = Join(Array(Worksheets("Maintain").Range("F18").Value, _
                                  Worksheets("Maintain").Range("F19").Value, _
                                  Worksheets("Maintain").Range("F20").Value), Chr(32))

        .Range("D8").Value = sapcolleague
    End With

    'Shouldn't it be saved somewhere around here?

    ' This MsgBox will only show if the loop completes with no success
    MsgBox "Successfully saved!"

End Sub

Excel VBA For-Loop仅在调试模式下运行

1 个答案: