Question

嗯，我对使用Rails编写的新手和Michael Hartl教程非常棒，直到现在我能够找到我的编码错误......现在我正在第10章＆＃34;友好转发＆＃34 ;在进行成功编辑的测试时，我偶然发现了一个我无法看到的错误。

test_successful_edit_with_friendly_forwarding＃UserEditTest（1.07s）预期的响应是＆lt; 3XX：重定向＆gt;，但是＆lt; 200：OK＆gt; test / integration / user_edit_test.rb：32：在`block in＆＃39;

我的user_edit_test是：

require 'test_helper'

class UserEditTest < ActionDispatch::IntegrationTest

  def setup
    @user = users(:michael)
  end

  test "unsuccessful edit" do
    log_in_as(@user)
    get edit_user_path(@user)
    assert_template 'users/edit'
    patch user_path(@user), params: { user: { name:  "",
                                              email: "foo@invalid",
                                              password:              "foo",
                                              password_confirmation: "bar" } }

    assert_template 'users/edit'
  end

test "successful edit with friendly forwarding" do
    get edit_user_path(@user)
    log_in_as(@user)
    assert_redirected_to edit_user_url(@user)
    name  = "Foo Bar"
    email = "foo@bar.com"
    patch user_path(@user), params: { user: { name:  name,
                                              email: email,
                                              password:              "",
                                              password_confirmation: "" } }
    assert_not flash.empty?
    assert_redirected_to @user <---  this is line 32 from the test
    @user.reload
    assert_equal name,  @user.name
    assert_equal email, @user.email
  end
end

我的用户控制器是：

class UsersController < ApplicationController
  before_action :logged_in_user, only: [:edit, :update]
  before_action :correct_user,   only: [:edit, :update]
  def show
    @user  = User.find(params[:id])
      end

  def new
    @user = User.new
  end

  def create
    @user = User.new(user_params) # Not the final implementation!
    if @user.save
      log_in @user
      flash[:success] = "Welcome to the Sample App"
      redirect_to @user
    else
      render 'new'
    end
  end

  def edit
      end

  def update
       if @user.update_attributes(user_params)
          flash[:success] = "Profile updated"
          redirect_to @user
      # Handle a successful update.
    else
      render 'edit'
    end
  end

  private

    def user_params
    params.require(:user).permit(:name, :email, :password,
                                 :password_confirmation)
    end 

#Before Filters

#Confirms a logged-in user
   def logged_in_user
      unless logged_in?
        store_location
        flash[:danger] = "Please log in."
        redirect_to login_url
      end
    end

    # Confirms the correct user.
    def correct_user
      @user = User.find(params[:id])
      redirect_to(root_url) unless current_user?(@user)
    end
end

我的会话。帮助是：

  module SessionsHelper

    #logs in the given user
    def log_in(user)
        session[:user_id] = user.id
    end

# Remembers a user in a persistent session.
  def remember(user)
    user.remember
    cookies.permanent.signed[:user_id] = user.id
    cookies.permanent[:remember_token] = user.remember_token
  end

    def current_user
           if (user_id = session[:user_id])
      @current_user ||= User.find_by(id: user_id)
    elsif (user_id = cookies.signed[:user_id])
      user = User.find_by(id: user_id)
      if user && user.authenticated?(cookies[:remember_token])
        log_in user
        @current_user = user
      end
    end
 end 

#returns true if the current user is the given user
def current_user?(user)
  user == current_user
end

 # Returns true if the user is logged in, false otherwise.
    def logged_in?
        !current_user.nil?
    end

def forget(user)
  user.forget
  cookies.delete(:user_id)
  cookies.delete(:remember_token)
end

 # Logs out current user
    def log_out
        forget(current_user)
    session.delete(:user_id)
        @current_user = nil
    end

# Redirects to stored location (or to the default).
  def redirect_back_or(default)
    redirect_to(session[:forwarding_url] || default)
    session.delete(:forwarding_url)
  end

  # Stores the URL trying to be accessed.
  def store_location
    session[:forwarding_url] = request.original_url if request.get?
  end
end

我的会话控制器是：

class SessionsController < ApplicationController

  def new
  end

  def create
    @user = User.find_by(email: params[:session][:email].downcase)
    if @user && @user.authenticate(params[:session][:password])
      log_in @user
      params[:session][:remember_me] == '1' ? remember(@user) : forget(@user)
      redirect_back_or @user
    else
      flash.now[:danger] = 'Invalid email/password combination'
      render 'new'
    end
  end

  def destroy
    log_out if logged_in?
    redirect_to root_url
  end
end

从我在其他问题中看到的我理解问题但似乎找不到解决问题的方法，我感觉就在我脸上，但没有看到它。

Answer 1

FWIW，您的友好转发工作正常，并在您的测试用例的前3行进行测试。 assert_redirected_to @user测试对应于您的UsersController＃update，更具体地说，对应于if分支中的redirect_to @user语句。如果您登录网站并更新用户的个人资料会怎样？此时也要检查日志。

Rails教程第10章（友好转发）测试错误，预期响应是＆lt; 3XX：重定向＆gt;，但是＆lt; 200：OK＆gt;

1 个答案: