Question

此过程的重点是刷新并为每个客户生成ID，以便通过将这些ID添加到某种类型的名为PHONENUMS的索引表中来加快销售点方面的查找过程。

此proc只是一个数据初始化过程，但目前在此客户端的数据库上运行最多需要2天。显然这是禁止的，因为这会让他们在等待的时候停止工作2天。该函数从PHONENUM_REFRESH_ALL运行，该客户端在customers表上运行For循环，然后调用相应处理每条记录的过程。我已经粘贴了以下两个程序。

坦率地说，我尝试使用Interbase PLANAnalyzer来尝试缩小这个过程中的重要部分，但是如果我运行它就像处理单个记录一样，它真的很快。我找不到任何可以关闭或单独输出的循环来加速这个过程，但是我们对客户名称有一个类似的过程，它的工作速度非常快，但并排并列并没有给我答案。这里有一些明显的问题会导致它如此缓慢地运行吗？

运行for循环的主程序。

CREATE PROCEDURE PHONENUM_REFRESH_ALL   AS 
declare variable custid varchar(8);
declare variable KEYWORD varchar(30);
declare variable AREACODE VARCHAR(3);
declare variable PRIMARYTEL VARCHAR(8);
declare variable PRIMARYTELID VARCHAR(8);
declare variable configdefault varchar(8);
begin
  /* 2016-03-16 - Creation */

insert into timetracker(time_stamp) values (cast('NOW' as timestamp));
  for select custid, areacode, primarytel, PRIMARYTELID 
    from customers 
    where (primarytelid || '' is null or primarytelid || '' = '')
    and areacode is not null and areacode <> ''
    and primarytel is not null and primarytel <> ''
    into :custid, :AREACODE, :primarytel,:PRIMARYTELID do
  begin
    select primarytelid from PHONENUM_REFRESH(:CUSTID,:AREACODE,:PRIMARYTEL,'') into :primarytelid;
    update customers set primarytelid = :primarytelid where custid = :custid;
  end
insert into timetracker(time_stamp) values (cast('NOW' as timestamp));   
END

PHONENUM_REFRESH过程（处理从主过程传递的单个记录）。

CREATE PROCEDURE PHONENUM_REFRESH (
  CUSTID VARCHAR(8),
  AREACODE VARCHAR(3),
  PRIMARYTEL VARCHAR(8),
  TRIGG VARCHAR(8)
) RETURNS (
  PRIMARYTELID VARCHAR(8)
) AS 
DECLARE VARIABLE NEWTELID INTEGER;
DECLARE VARIABLE FOUNDTELID VARCHAR(6);
DECLARE VARIABLE BRANCHID VARCHAR(2);
DECLARE VARIABLE DBTYPE CHAR(2);
DECLARE VARIABLE CNT INTEGER;
DECLARE VARIABLE TELNOTE VARCHAR(40);
DECLARE VARIABLE GENTELIDPREFIX varchar(2);

BEGIN
  /* 2013-07-13 V1.0  - Creation. Procedure is binding customer to an existing phonenum (if not bound), creates it if none is matching.
     2015-05-04 V1.1  - If matching primarytel is found, update customer's primarytelid
     2015-07-22 V1.2 - Not updating CUSTOMERS table if called from trigger (TRIGG = 'trIgg')
     2015-08-20 - To add GENTELIDPREFIX for fixing conversion string error with TELID
  */    
  /* CustId mandatory */
  IF ((CUSTID <> '') AND (CUSTID IS NOT NULL)) THEN
  BEGIN
    IF ((TRIGG = '') OR (TRIGG IS NULL)) THEN
      TRIGG = 'SYSDBA';
    /* PRIMARYTELID NOT SET, TRY TO GET ONE */
    IF ((AREACODE <> '') AND (PRIMARYTEL <> '')) THEN
    BEGIN
      SELECT MIN(TELID) FROM PHONENUMS WHERE AREACODE=:AREACODE AND PRIMARYTEL=:PRIMARYTEL AND CUSTID=:CUSTID INTO :PRIMARYTELID;

      SELECT F_LEFT(config_value,1) FROM branch_config WHERE branchid = '00' and config_name = 'GEN_TELID_PREFIX' into :GENTELIDPREFIX;

      /* No PRIMARYTELID found. Go create one with 'PR' */
      IF (PRIMARYTELID IS NULL) THEN 
        PRIMARYTELID = '';

      IF (PRIMARYTELID = '') THEN
      BEGIN
        /* If SF, we force it to use the generators */
        SELECT MIN(DBTYPE) FROM DATABASEID INTO :DBTYPE;
        IF (DBTYPE = 'SF') THEN
        BEGIN
          FOUNDTELID='X';
          BRANCHID='00';
        END
        ELSE
        BEGIN
          SELECT TELID, BRANCHID FROM CTRLFILE WHERE BRANCHID = (SELECT MIN(DBID) FROM DATABASEID) ROWS 1 INTO  :FOUNDTELID,:BRANCHID;
        END

        IF (FOUNDTELID = 'X') THEN
        BEGIN
          SELECT GEN_ID(GENTELID,1) FROM RDB$DATABASE INTO :NEWTELID;

          if ((GENTELIDPREFIX is not null) AND (GENTELIDPREFIX <> '')) then
          BEGIN
            PRIMARYTELID = GENTELIDPREFIX || CAST(NEWTELID AS VARCHAR(7));
          END
          ELSE
          BEGIN
            PRIMARYTELID = BRANCHID || CAST(NEWTELID AS VARCHAR(6));
          END
          TELNOTE = '';
          select count(*) from phonenums where telid = :PRIMARYTELID into :cnt;

          IF (CNT = 1) THEN
          BEGIN
            /* Whaaaaaat? Twilight zone glitch, gotta save the moment! */
            TELNOTE = '(Shifted from telid ' || PRIMARYTELID || ')';
            SELECT GEN_ID(GENTELID,1) FROM RDB$DATABASE INTO :NEWTELID;

            if ((GENTELIDPREFIX is not null) AND (GENTELIDPREFIX <> '')) then
            BEGIN
              PRIMARYTELID = GENTELIDPREFIX || CAST(NEWTELID AS VARCHAR(7));
            END
            ELSE
            BEGIN
              PRIMARYTELID = BRANCHID || CAST(NEWTELID AS VARCHAR(6));
            END
          END
          INSERT INTO PHONENUMS (TELID,PRIMARYTEL,AREACODE,TELTYPE,CUSTID,EDU_,TELNOTE) VALUES(:PRIMARYTELID,:PRIMARYTEL,:AREACODE,'PR',:CUSTID,:TRIGG,:TELNOTE);
        END
        ELSE
        BEGIN
          NEWTELID = CAST(FOUNDTELID AS INTEGER) + 1;
          if ((GENTELIDPREFIX is not null) AND (GENTELIDPREFIX <> '')) then
          BEGIN
            PRIMARYTELID = GENTELIDPREFIX || CAST(NEWTELID AS VARCHAR(7));
          END
          ELSE
          BEGIN
            PRIMARYTELID = BRANCHID || CAST(NEWTELID AS VARCHAR(6));
          END
          INSERT INTO PHONENUMS (TELID,PRIMARYTEL,AREACODE,TELTYPE,CUSTID,EDU_) VALUES(:PRIMARYTELID,:PRIMARYTEL,:AREACODE,'PR',:CUSTID,:TRIGG);
          UPDATE CTRLFILE SET TELID = :NEWTELID WHERE BRANCHID = :BRANCHID;
        END

      END
      ELSE IF (TRIGG <> 'trIgg') THEN
      BEGIN
        UPDATE CUSTOMERS SET PRIMARYTELID = :PRIMARYTELID WHERE CUSTID = :CUSTID;
      END
    END

  END

  SUSPEND;
  END

Answer 1

似乎有点愚蠢地将记录逐个插入PHONENUMS。难道你不能只写一些SQL来从CUSTOMERS中读取你需要的记录并将它们与一些ID生成一起插入一次吗？您也可以在一次通过后更新CTRL文件。或者我错过了什么？

尝试优化此Interbase过程的运行时

1 个答案: