引用单元格时,下标超出范围错误

时间:2016-11-24 23:14:14

标签: arrays excel vba subscript

我的代码的目标是获取单元格的旧值,并根据输入的新值检查它。如果旧值更改为新值,则更新指定单元格中的日期。

我的代码存在的问题是,如果没有我的代码破坏,我似乎无法找到解决此错误的方法,因此我无法尝试修复这一行代码。我知道我的阵列是出于界限或类似的东西,但我无法弄清楚如何绕过它。

这是我的代码:

Dim oldValue()

Public Sub Worksheet_SelectionChange(ByVal Target As Range)
oldValue = Me.Range("D4", "D21").Value
End Sub

Private Sub Worksheet_Change(ByVal Target As Range)
If Not Intersect(Target, Me.Range("D4:D21")) Is Nothing Then
    Dim c As Range
    For Each c In Intersect(Target, Me.Range("D4:D21"))
        'Here's where my code is breaking "Subscript out of range error"
        If oldValue(c.Row) <> c.Value Then
            'Update value in column L (8 columns to the right of column D)
            c.Offset(0, 7).Value = Date 'or possibly "= Now()" if you need the time of day that the cell was updated
        End If
    Next
End If
End Sub

如果它破坏了,我已经定义了如果旧值更改为新值,则更新日期。但它给了我一个错误,我无法找到解决方法。

如何修复我的代码以使其在范围内,任何建议?

编辑:我现在修复了我的代码:

Dim oldValue As Variant

Public Sub Worksheet_SelectionChange(ByVal Target As Range)
'I changed "D4", "D21" to the following:
oldValue = Me.Range("D4:D21").Value
End Sub

Private Sub Worksheet_Change(ByVal Target As Range)
If Not Intersect(Target, Me.Range("D4:D21")) Is Nothing Then
    'Application.EnableEvents = False
    Dim c As Range
    For Each c In Intersect(Target, Me.Range("D4:D21"))
        'Check value against what is stored in "oldValue" (row 4 is in position 1, row 5 in position 2, etc)
        'I also changed the array reference
        If oldValue(c.Row - 3, 1) <> c.Value Then
            'Update value in column L (8 columns to the right of column D)
            c.Offset(0, 7).Value = Date 'or possibly "= Now()" if you need the time of day that the cell was updated
        End If
    Next
    'Application.EnableEvents = True
End If
End Sub

1 个答案:

答案 0 :(得分:1)

Dim oldValue as Variant

....

' oldValue is a 2D array
' and there is a shift between c.Row and the index of oldValue 
If oldValue(c.Row - 3, 1) <> c.Value Then ...