Question

我有一个具有多个条件和多个面板连接在一起的搜索功能，如下所示

hospitals = Hospital.order(created_at: :desc).group(:id)
hospitals = hospitals.joins(medical_subjects: :sicks).where("(medical_subjects.name LIKE ? OR sicks.name LIKE ?) AND hospitals.name LIKE ?" ,
                                                            "%#{params[:freeword_medical_subject_sick_name].strip}%" ,
                                                            "%#{params[:freeword_medical_subject_sick_name].strip}%" ,
                                                            "%#{params[:freeword_hospital_name].strip}%") if params[:freeword_medical_subject_sick_name].present?
hospitals = hospitals.joins(prefecture: [:cities, :stations]).where("cities.name LIKE ? OR stations.name LIKE ?" ,
                                                                                    "%#{params[:freeword_city_station_name]}%" ,
                                                                                    "%#{params[:freeword_city_station_name].strip}%") if params[:freeword_city_station_name].present?
hospitals = hospitals.where(["hospitals.name LIKE ?" , "%#{params[:freeword_hospital_name].strip}%"]) if params[:freeword_hospital_name]
hospitals = hospitals.where(woman_doctor_existed: params[:woman_doctor_existed]) if params[:woman_doctor_existed].present?
hospitals = hospitals.where(emergency_enabled: params[:emergency_enabled]) if params[:emergency_enabled].present?
hospitals = hospitals.where(checkup_enabled: params[:checkup_enabled]) if params[:checkup_enabled].present?
hospitals = hospitals.where(dpc_enabled: params[:dpc_enabled]) if params[:dpc_enabled].present?
hospitals = hospitals.where(parking_enabled: params[:parking_enabled]) if params[:parking_enabled].present?
hospitals = hospitals.where(card_enabled: params[:card_enabled]) if params[:card_enabled].present?
hospitals = hospitals.where(newest_medicine_enabled: params[:newest_medicine_enabled]) if params[:newest_medicine_enabled].present?
hospitals = hospitals.page(params[:page])
hospitals

但是当我运行rubocop这个文件时遇到了一些错误

分配分支搜索大小的条件太高。
用于搜索的Cyclomatic CompLexity太高。
方法有太多行。 [14/10]
感知CompLexity for search太高

有解决方案吗？感谢阅读并抱歉我的英语不好

Answer 1

它说你在一种方法中做了很多事情。您可以尝试将其分解为更小的方法。另一个想法是删除一些重复。例如，如果存在某个param，则经常添加WHERE子句。考虑这样的事情：

%i(woman_doctor_existed emergency_enabled checkup_enabled more...).each do |key|
  hospitals = hospitals.where(key => params[key]) if params.has? key
end

如何在rubocop中恢复问题检查样式？

1 个答案: