nodejs - 帮助“宣传”使用嵌套承诺

时间:2016-10-16 12:52:47

标签: javascript node.js excel bluebird pg-promise

因此,由于javascripts异步行为,我最近一直试图理解承诺及其背后的目的。当我“思考”我理解时,我仍然在努力如何宣传某些东西以返回未来的价值,然后执行一个新的代码块来做其他事情。我正在使用的两个主要节点模块:

  • pg-promise
  • exceljs

我想要做的是读取一个文件,然后一旦完全读取,迭代执行DB命令的每个工作表。然后,处理完所有工作表后,返回并删除我读取的原始文件。这是我的代码。 即使有多个工作表,我也可以将所有内容写入数据库。我没有工作的是设置它以确定所有工作表何时完全处理,然后去除文件

workbook.csv.readFile(fileName)
            .then(function () {
                // this array I was going to use to somehow populate a true/false array.  
                // Then when done with each sheet, push a true into the array.  
                // When all elements were true could signify all the processing is done... 
                // but have no idea how to utilize this!  
                // So left it in to take up space because wtf...
                var arrWorksheetComplete = [];

                workbook.eachSheet(function (worksheet) {
                    console.log(worksheet.name);
                    db.tx(function (t) {
                        var insertStatements = [];
                        for (var i = 2; i <= worksheet._rows.length; i++) {
                            // here we create a new array from the worksheet, as we need a 0 index based array.
                            // the worksheet values actually begins at element 1.  We will splice to dump the undefined element at index 0.
                            // This will allow the batch promises to work correctly... otherwise everything will be offset by 1
                            var arrValues = Array.from(worksheet.getRow(i).values);
                            arrValues.splice(0, 1);

                            // these queries are upsert.  Inserts will occur first, however if they error on the constraint, an update will occur instead.
                            insertStatements.push(t.one('insert into rq_data' +
                                '(col1, col2, col3) ' +
                                'values($1, $2, $3) ' +
                                'ON CONFLICT ON CONSTRAINT key_constraint DO UPDATE SET ' +
                                '(prodname) = ' +
                                '($3) RETURNING autokey',
                                arrValues));
                        }
                        return t.batch(insertStatements);
                    })
                    .then(function (data) {
                        console.log('Success:', 'Inserted/Updated ' + data.length + ' records');
                    })
                    .catch(function (error) {
                        console.log('ERROR:', error.message || error);
                    });
                });
            });

我希望能够说

.then(function(){
    // everything processed!
    removeFile(fileName)
    // this probably also wouldn't work as by now fileName is out of context?
});

但是当我在promise中有一个promise时,我感到非常困惑。我有db.tx调用,它本质上是一个嵌套在.eachSheet函数中的promise。 请帮助一个愚蠢的程序员理解!在这一个人的头上撞了好几个小时。 :)

1 个答案:

答案 0 :(得分:0)

如果我理解正确,那你就是在试图将承诺联系在一起。

我建议你阅读great article on Promises anti-pattern(参见'The Collection Kerfuffle'部分)

如果您需要连续执行promises,本文建议使用reduce

我会将您的代码段重写为:

workbook.csv.readFile(fileName).then(function () {

  processWorksheets().then(function() {
    // all worksheets processed!
  });

});

function processWorksheets() {
    var worksheets = [];

    // first, build an array of worksheet
    workbook.eachSheet(function (worksheet) {
        worksheets.push(worksheet);
    }); 

    // then chain promises using Array.reduce
    return worksheets.reduce(function(promise, item) {
        // promise is the the value previously returned in the last invocation of the callback.
        // item is a worksheet

        // when the previous promise will be resolved, call saveWorksheet on the next worksheet
        return promise.then(function(result) {
            return saveWorksheet(item, result);
        });        

    }, Promise.resolve()); // start chain with a 'fake' promise
}

// this method returns a promise
function saveWorksheet(worksheet, result) {

    return db.tx(function (t) {

      var insertStatements = [];
      for (var i = 2; i <= worksheet._rows.length; i++) {
        // here we create a new array from the worksheet, as we need a 0 index based array.
        // the worksheet values actually begins at element 1.  We will splice to dump the undefined element at index 0.
        // This will allow the batch promises to work correctly... otherwise everything will be offset by 1
        var arrValues = Array.from(worksheet.getRow(i).values);
        arrValues.splice(0, 1);

        // these queries are upsert.  Inserts will occur first, however if they error on the constraint, an update will occur instead.
        insertStatements.push(t.one('insert into rq_data' +
                                    '(col1, col2, col3) ' +
                                    'values($1, $2, $3) ' +
                                    'ON CONFLICT ON CONSTRAINT key_constraint DO UPDATE SET ' +
                                    '(prodname) = ' +
                                    '($3) RETURNING autokey',
                                    arrValues));
      }

      return t.batch(insertStatements);
    })
    // this two below can be removed...
    .then(function (data) {
       return new Promise((resolve, reject) => { 
          console.log('Success:', 'Inserted/Updated ' + data.length + ' records');
          resolve();
       });
    })
    .catch(function (error) {
        return new Promise((resolve, reject) => {
        console.log('ERROR:', error.message || error);
        reject();
      });
    });

}

不要忘记包含promise模块:

var Promise = require('promise');

我没有测试过我的代码,可能包含一些拼写错误。