Swift方法链接成功&失败

时间:2016-08-08 15:06:36

标签: ios swift method-chaining

我正在尝试在我的代码中实现成功和失败调用的方法链接,但我似乎无法实际调用onSuccess方法。

  1. 视图控制器调用getProduct(_:)函数。
  2. getProduct(_:)进行API调用,然后使用检索到的json
  3. 调用storeProduct(_:)
  4. storeProduct(_:)来电fetchProduct(_:)
  5. fetchProduct(_:)来电doSuccess(_:),但这绝不会回到之前通话的onSuccess
  6. 部分代码段

    BSProductChainable.swift

    import Foundation
    
    class BSProductChainable<SuccessParams, FailureParams> {
    
        var successClosure: ((SuccessParams) -> ())? = nil
        var failureClosure: ((FailureParams) -> ())? = nil
    
        func onSuccess(closure: (SuccessParams) -> ()) -> BSProductChainable {
            successClosure = closure
            return self
        }
        func onFailure(closure: (FailureParams) -> ()) -> BSProductChainable {
            failureClosure = closure
            return self
        }
        func doSuccess(params: SuccessParams) {
            if let closure = successClosure {
                closure(params)
            }
        }
        func doFailure(params: FailureParams) {
            if let closure = failureClosure {
                closure(params)
            }
        }
    }
    

    BSProductManagerSwift.swift

    class BSProductManagerSwift: NSObject {
    
    typealias productResponseChain = BSProductChainable<Product, NSError?>
    typealias productsResponseChain = BSProductChainable<[Product], NSError?>
    
    var serviceClient: BSNetworkingServiceClient!
    var objectContext: NSManagedObjectContext!
    var productChains: BSProductChainable<Product, NSError?>!
    var productsChains: BSProductChainable<[Product], NSError?>!
    
    convenience init(serviceClient: BSNetworkingServiceClient) {
        self.init()
        self.serviceClient = serviceClient
        self.objectContext = managedObjectContext
        self.productChains = BSProductChainable<Product, NSError?>()
        self.productsChains = BSProductChainable<[Product], NSError?>()
    }
    
    func getProduct(ean: String) -> productResponseChain {
    
        let urlString = BSConstants.BarcodeScanner.productEndpoint.stringByAppendingString(ean)
        serviceClient.GET(urlString, failure: { (error) in
            print("Could not get product")
        }) { (response) in
            if let json = response {
                self.storeProduct(json).onSuccess({ (returedProduct) in
                    print("Stored product")
                })
            }
        }
    
        return productChains
    }
    
    func storeProduct(json: JSON) -> productResponseChain {
    
        fetchProduct(json["ean"].stringValue).onSuccess { (returedProduct) in
            self.productChains.doSuccess(returedProduct)
        }
    
        return productChains
    }
    
    func fetchProduct(ean: String) -> productResponseChain {
    
        let fetchRequest = NSFetchRequest(entityName: "Product")
        let predicateEAN = NSPredicate(format: "%K == %@", "ean", ean)
        let predicateMarket = NSPredicate(format: "%K == %@", "market", BSCountryManager.sharedInstance().getCurrentCountry().market)
        let predicateLocale = NSPredicate(format: "%K == %@", "locale", BSLocalizationManager.sharedManager().currentLocalization.localeIdentifier())
        let predicateCurrency = NSPredicate(format: "%K == %@", "currency", BSLocalizationManager.sharedManager().currentLocalization.country.currencyIdentifierDMW)
        let compoundPredicate = NSCompoundPredicate(andPredicateWithSubpredicates: [predicateEAN, predicateMarket, predicateLocale, predicateCurrency])
        fetchRequest.predicate = compoundPredicate
    
        do {
            let matchingProuducts = try objectContext.executeFetchRequest(fetchRequest)
    
            if matchingProuducts.count == 0 {
                print("No matching products found")
                let entity = NSEntityDescription.entityForName("Product", inManagedObjectContext: objectContext)
                productChains.doSuccess(Product(entity: entity!, insertIntoManagedObjectContext: objectContext))
            } else {
                print("Found matching product")
                let d = matchingProuducts.first as! Product
                productChains.doSuccess(d)
            }
        } catch let error as NSError {
            print("Could not fetch \(error), \(error.userInfo)")
            productChains.doFailure(error)
        }
    
        return productChains
    }
    

    我最初初始化了每个函数的可链接类,但是它有自己的问题,我认为(可能不正确)我应该只初始化可链接类一次并传递它的引用。

    关于我出错的地方/我接下来可以尝试的内容的一些输入将会很棒。

1 个答案:

答案 0 :(得分:0)

根据@john元素的建议,我决定使用PromiseKit

这并不需要进行大量的代码更改,现在这些功能现在看起来像是什么样的(仍然需要进行一些代码清理,但它确实有用!):

func getProduct(ean: String) -> Promise<Product> {
    return Promise { fullfill, reject in
        let urlString = BSConstants.BarcodeScanner.productEndpoint.stringByAppendingString(ean)
        serviceClient.GET(urlString, failure: { (error) in
            reject(error!)
        }) { (response) in
            if let json = response {
                self.storeProduct(json).then ({ returnedProduct in
                    print("We stored the product: \(returnedProduct.ean)")
                    fullfill(returnedProduct)
                }).error { returnedError in
                    print("We had a problem storing the product: \(returnedError)")
                }
            }
        }
    }
}

func storeProduct(json: JSON) -> Promise<Product> {
    return Promise { fullfill, reject in
        fetchProduct(json["ean"].stringValue).then ({ returnedProduct in

            var storedProduct: Product!
            var isNewProduct = false

            print("Fetched Product: \(returnedProduct.ean)")

            isNewProduct = returnedProduct.valueForKey("ean") == nil
            storedProduct = returnedProduct
            storedProduct.setValue(json["name"].stringValue, forKey: "name")
            storedProduct.setValue(json["ean"].stringValue, forKey: "ean")
            storedProduct.setValue(json["image"].stringValue, forKey: "image")
            storedProduct.setValue(json["price"].doubleValue, forKey: "price")
            storedProduct.setValue(json["status"].intValue, forKey: "status")
            storedProduct.setValue(json["pdp"].stringValue, forKey: "pdp")
            storedProduct.setValue(BSCountryManager.sharedInstance().getCurrentCountry().market, forKey: "market")
            storedProduct.setValue(BSLocalizationManager.sharedManager().currentLocalization.localeIdentifier(), forKey: "locale")
            storedProduct.setValue(BSLocalizationManager.sharedManager().currentLocalization.country.currencyIdentifierDMW, forKey: "currency")

            do {
                try self.objectContext.save()
                print("Stored Product: \(returnedProduct.ean)")
                fullfill(returnedProduct)

                if isNewProduct {
                    NSNotificationCenter.defaultCenter().postNotificationName("DidAddScanEntry", object: nil)
                }

            } catch let error as NSError {
                print("Could not save \(error), \(error.userInfo)")
                reject(error)
            }

        }).error { returnedError in
            print("We had a problem fetching the product: \(returnedError)")
            reject(returnedError)
        }
    }
}

func fetchProduct(ean: String) -> Promise<Product> {
    return Promise { fullfill, reject in

        let fetchRequest = NSFetchRequest(entityName: "Product")
        let predicateEAN = NSPredicate(format: "%K == %@", "ean", ean)
        let predicateMarket = NSPredicate(format: "%K == %@", "market", BSCountryManager.sharedInstance().getCurrentCountry().market)
        let predicateLocale = NSPredicate(format: "%K == %@", "locale", BSLocalizationManager.sharedManager().currentLocalization.localeIdentifier())
        let predicateCurrency = NSPredicate(format: "%K == %@", "currency", BSLocalizationManager.sharedManager().currentLocalization.country.currencyIdentifierDMW)
        let compoundPredicate = NSCompoundPredicate(andPredicateWithSubpredicates: [predicateEAN, predicateMarket, predicateLocale, predicateCurrency])
        fetchRequest.predicate = compoundPredicate

        do {
            let matchingProuducts = try objectContext.executeFetchRequest(fetchRequest)

            if matchingProuducts.count == 0 {
                print("No matching products found")
                let entity = NSEntityDescription.entityForName("Product", inManagedObjectContext: objectContext)
                fullfill(Product(entity: entity!, insertIntoManagedObjectContext: objectContext))
            } else {
                print("Found matching product")
                let d = matchingProuducts.first as! Product
                fullfill(d)
            }
        } catch let error as NSError {
            print("Could not fetch \(error), \(error.userInfo)")
            reject(error)
        }
    }
}