TicTacToe游戏中的一个不必要的转弯

时间:2016-07-30 14:25:48

标签: java

我正在尝试在JavaFX中为TicTacToe游戏制作此代码。但是现在即使有胜利者(意思是有人将他的三个X或者Os放在一行/列/对角线上),该程序仍然允许其他玩家将他的标志放在棋盘上。只有在此之后,更改获胜按钮并禁用按钮。我该如何改变?

package tictactoe;

import javafx.collections.ObservableList;
import javafx.event.ActionEvent;
import javafx.fxml.FXML;
import javafx.scene.Node;
import javafx.scene.control.Button;
import javafx.scene.control.MenuItem;
import javafx.scene.layout.GridPane;

public class TicTacToeController {
private boolean isFirstPlayer = true;

public void buttonClickHandler(ActionEvent evt) { 
    this.find3InARow();  

    Button clickedButton = (Button) evt.getTarget();
    String buttonLabel = clickedButton.getText();

    if ("".equals(buttonLabel) && isFirstPlayer){
        clickedButton.setText("X");
        isFirstPlayer = false;
    } else if("".equals(buttonLabel) && !isFirstPlayer) {
        clickedButton.setText("O");
        isFirstPlayer = true;
    }

}
@FXML Button b1; 
@FXML Button b2;
@FXML Button b3;
@FXML Button b4;
@FXML Button b5;
@FXML Button b6;
@FXML Button b7;
@FXML Button b8;
@FXML Button b9;   
@FXML GridPane gameBoard;
@FXML MenuItem Play; 

private boolean find3InARow() {
    if (""!=b1.getText() && b1.getText() == b2.getText() 
        && b2.getText() == b3.getText()){
        highlightWinningCombo(b1,b2,b3);
        return true; 
    }

    if (""!=b4.getText() && b4.getText() == b5.getText() 
        && b5.getText() == b6.getText()){
        highlightWinningCombo(b4,b5,b6);
        return true; 
    }

    if (""!=b7.getText() && b7.getText() == b8.getText() 
        && b8.getText() == b9.getText()){
        highlightWinningCombo(b7,b8,b9);
        return true; 
    }

    if (""!=b1.getText() && b1.getText() == b4.getText() 
        && b4.getText() == b7.getText()){
        highlightWinningCombo(b1,b4,b7);
        return true; 
    }

    if (""!=b2.getText() && b2.getText() == b5.getText() 
        && b5.getText() == b8.getText()){
        highlightWinningCombo(b2,b5,b8);
        return true; 
    }

    if (""!=b3.getText() && b3.getText() == b6.getText() 
        && b6.getText() == b9.getText()){
        highlightWinningCombo(b3,b6,b9);
        return true; 
    }

    if (""!=b1.getText() && b1.getText() == b5.getText() 
        && b5.getText() == b9.getText()){
        highlightWinningCombo(b1,b5,b9);
        return true; 
    }

    if (""!=b3.getText() && b3.getText() == b5.getText() 
        && b5.getText() == b7.getText()){
        highlightWinningCombo(b3,b5,b7);
        return true; 
    }
    return false;

    }

    private void highlightWinningCombo(Button first, Button second, Button third) {
        gameBoard.setDisable(true);
        first.getStyleClass().add("winning-button");
        second.getStyleClass().add("winning-button");
        third.getStyleClass().add("winning-button");
    }

    public void menuClickHandler(ActionEvent evt){
        MenuItem clickedMenu = (MenuItem) evt.getTarget();
        String menuLabel = clickedMenu.getText();

        if ("Play".equals(menuLabel)){ 
            ObservableList<Node> buttons =  gameBoard.getChildren(); 
gameBoard.setDisable(false);

            buttons.forEach(btn -> { 
                ((Button) btn).setText("");  
                btn.getStyleClass().remove("winning-button");
            });
            isFirstPlayer = true;  
        }
        else if("Quit".equals(menuLabel)) {
            System.exit(0);
   }

    }

}

1 个答案:

答案 0 :(得分:0)

您在设置玩家的最后一次输入之前正在检查棋盘,所以如果玩家进行了获胜动作,只有在您检查了获胜条件后才会设置,所以程序不知道是否最后一次球员赢了。要解决此问题,首先需要处理输入,然后检查获胜条件。为此,只需将this.find3InARow();移至方法buttonClickHandler()的末尾。